From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 3/5] arm: mach-omap2: pm33xx: Add support for rtc+ddr in self refresh mode Date: Mon, 1 Apr 2019 10:52:45 -0700 Message-ID: <20190401175245.GJ49658@atomide.com> References: <20190322171619.4180-1-j-keerthy@ti.com> <20190322171619.4180-4-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190322171619.4180-4-j-keerthy@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Keerthy Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi, * Keerthy [190322 17:16]: > +static int am43xx_check_off_mode_enable(void) > +{ > + /* > + * Check for am437x-sk-evm which due to HW design cannot support > + * this mode reliably. > + */ > + if (of_machine_is_compatible("ti,am437x-sk-evm") && enable_off_mode) { > + pr_warn("WARNING: This platform does not support off-mode, entering DeepSleep suspend.\n"); > + return 0; > + } > + > + return enable_off_mode; > +} Considering off-mode suspend depends on how the board is wired for various things such as memory, PMIC and the related signal lines, I agree using the machine compatible is the best check we can do here. But since the device can hang during suspend unless things are configured right for the board, I suggest you rather list allowed boards here that are known to work with off-mode. Otherwise many out-of-tree boards might hang during suspend mysteriously. Regards, Tony