From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Krzysztof Halasa <khalasa@piap.pl>,
Russell King <linux@armlinux.org.uk>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Lubomir Rintel <lkundrak@v3.sk>,
Kevin Hilman <khilman@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>, Arnd Bergmann <arnd@arnd>
Subject: Re: [PATCH 02/18] ARM: replace setup_irq() by request_irq()
Date: Thu, 13 Feb 2020 00:27:16 +0100 [thread overview]
Message-ID: <20200213002716.99258cfd73002fdd4bbd17d9@gmail.com> (raw)
In-Reply-To: <da7d11b6cf808ea95e2d852a2e8cbca3fde28b6f.1581478324.git.afzal.mohd.ma@gmail.com>
Hi!
On Wed, 12 Feb 2020 13:32:43 +0530
afzal mohammed <afzal.mohd.ma@gmail.com> wrote:
> request_irq() is preferred over setup_irq(). Existing callers of
> setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
> memory allocators are ready by 'mm_init()'.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
For the EP93xx part:
Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> index de998830f534..0335f3b93340 100644
> --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> @@ -117,13 +117,6 @@ static irqreturn_t ep93xx_timer_interrupt(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -static struct irqaction ep93xx_timer_irq = {
> - .name = "ep93xx timer",
> - .flags = IRQF_TIMER | IRQF_IRQPOLL,
> - .handler = ep93xx_timer_interrupt,
> - .dev_id = &ep93xx_clockevent,
> -};
> -
> void __init ep93xx_timer_init(void)
> {
> /* Enable and register clocksource and sched_clock on timer 4 */
> @@ -136,7 +129,10 @@ void __init ep93xx_timer_init(void)
> EP93XX_TIMER4_RATE);
>
> /* Set up clockevent on timer 3 */
> - setup_irq(IRQ_EP93XX_TIMER3, &ep93xx_timer_irq);
> + if (request_irq(IRQ_EP93XX_TIMER3, ep93xx_timer_interrupt,
> + IRQF_TIMER | IRQF_IRQPOLL, "ep93xx timer",
> + &ep93xx_clockevent))
> + pr_err("request_irq() on %s failed\n", "ep93xx timer");
> clockevents_config_and_register(&ep93xx_clockevent,
> EP93XX_TIMER123_RATE,
> 1,
--
Alexander Sverdlin.
next prev parent reply other threads:[~2020-02-12 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:01 [PATCH 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-12 8:02 ` [PATCH 02/18] ARM: replace setup_irq() by request_irq() afzal mohammed
2020-02-12 8:10 ` Viresh Kumar
2020-02-12 23:27 ` Alexander Sverdlin [this message]
2020-02-27 10:31 ` [PATCH 00/18] genirq: Remove setup_irq() Thomas Gleixner
2020-02-27 11:07 ` afzal mohammed
2020-03-21 17:43 ` afzal mohammed
2020-03-27 16:08 ` [PATCH 0/6] Kill setup_irq() afzal mohammed
2020-03-28 2:48 ` Brian Cain
2020-03-28 7:32 ` afzal mohammed
2020-04-02 15:03 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213002716.99258cfd73002fdd4bbd17d9@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=afzal.mohd.ma@gmail.com \
--cc=allison@lohutok.net \
--cc=andrew@lunn.ch \
--cc=arnd@arnd \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hsweeten@visionengravers.com \
--cc=jason@lakedaemon.net \
--cc=khalasa@piap.pl \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).