From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E149CC35E01 for ; Tue, 25 Feb 2020 14:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4F302176D for ; Tue, 25 Feb 2020 14:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CGZyWGEu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730386AbgBYONe (ORCPT ); Tue, 25 Feb 2020 09:13:34 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:59484 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730307AbgBYONe (ORCPT ); Tue, 25 Feb 2020 09:13:34 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 999C743F; Tue, 25 Feb 2020 15:13:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582640011; bh=lANSWxpohu5hwdRd9vZoy4VXRidLBBX31eLcIhlAkK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CGZyWGEuROwD/3xXK+b4yxrCZPfrSXTaZORG2N/wI4xbzgMUIZdePXRLkp5LG9KgT A2AOVo4b3oiUGwNSQNANZMUdUWgP8gu6JM6Kq5lReeY2sHzmXSPzXOGGOe4Oz6S/Ja elP1Up9BM++2W3ewIhMsDq/yXkHKc2JOBhG4Mr+o= Date: Tue, 25 Feb 2020 16:13:11 +0200 From: Laurent Pinchart To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Merlijn Wajer , "H. Nikolaus Schaller" , Rob Herring , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCHv2 06/56] drm/omap: constify write buffers Message-ID: <20200225141311.GE4764@pendragon.ideasonboard.com> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200224232126.3385250-7-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200224232126.3385250-7-sebastian.reichel@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:36AM +0100, Sebastian Reichel wrote: > The write buffers are not modified, so they can be constant. > > Signed-off-by: Sebastian Reichel Assuming this compiles :-), Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 24 ++++++++++++------------ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +++++----- > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index bb2548d091ef..f01e0476296d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -2601,11 +2601,11 @@ static inline void dsi_vc_write_long_payload(struct dsi_data *dsi, int channel, > } > > static int dsi_vc_send_long(struct dsi_data *dsi, int channel, u8 data_type, > - u8 *data, u16 len, u8 ecc) > + const u8 *data, u16 len, u8 ecc) > { > /*u32 val; */ > int i; > - u8 *p; > + const u8 *p; > int r = 0; > u8 b1, b2, b3, b4; > > @@ -2698,7 +2698,7 @@ static int dsi_vc_send_null(struct dsi_data *dsi, int channel) > } > > static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel, > - u8 *data, int len, > + const u8 *data, int len, > enum dss_dsi_content_type type) > { > int r; > @@ -2729,7 +2729,7 @@ static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel, > } > > static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len) > + const u8 *data, int len) > { > struct dsi_data *dsi = to_dsi_data(dssdev); > > @@ -2738,7 +2738,7 @@ static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel, > } > > static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len) > + const u8 *data, int len) > { > struct dsi_data *dsi = to_dsi_data(dssdev); > > @@ -2747,7 +2747,7 @@ static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int chann > } > > static int dsi_vc_write_common(struct omap_dss_device *dssdev, > - int channel, u8 *data, int len, > + int channel, const u8 *data, int len, > enum dss_dsi_content_type type) > { > struct dsi_data *dsi = to_dsi_data(dssdev); > @@ -2776,15 +2776,15 @@ static int dsi_vc_write_common(struct omap_dss_device *dssdev, > return r; > } > > -static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel, u8 *data, > - int len) > +static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel, > + const u8 *data, int len) > { > return dsi_vc_write_common(dssdev, channel, data, len, > DSS_DSI_CONTENT_DCS); > } > > -static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel, u8 *data, > - int len) > +static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel, > + const u8 *data, int len) > { > return dsi_vc_write_common(dssdev, channel, data, len, > DSS_DSI_CONTENT_GENERIC); > @@ -2810,7 +2810,7 @@ static int dsi_vc_dcs_send_read_request(struct dsi_data *dsi, int channel, > } > > static int dsi_vc_generic_send_read_request(struct dsi_data *dsi, int channel, > - u8 *reqdata, int reqlen) > + const u8 *reqdata, int reqlen) > { > u16 data; > u8 data_type; > @@ -2983,7 +2983,7 @@ static int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int channel, u8 dcs_c > } > > static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int channel, > - u8 *reqdata, int reqlen, u8 *buf, int buflen) > + const u8 *reqdata, int reqlen, u8 *buf, int buflen) > { > struct dsi_data *dsi = to_dsi_data(dssdev); > int r; > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index 53fea1cbbc2d..b909b3a8c835 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -308,18 +308,18 @@ struct omapdss_dsi_ops { > > /* data transfer */ > int (*dcs_write)(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len); > + const u8 *data, int len); > int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len); > + const u8 *data, int len); > int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd, > u8 *data, int len); > > int (*gen_write)(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len); > + const u8 *data, int len); > int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel, > - u8 *data, int len); > + const u8 *data, int len); > int (*gen_read)(struct omap_dss_device *dssdev, int channel, > - u8 *reqdata, int reqlen, > + const u8 *reqdata, int reqlen, > u8 *data, int len); > > int (*bta_sync)(struct omap_dss_device *dssdev, int channel); -- Regards, Laurent Pinchart