From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8F3C3F2CD for ; Fri, 28 Feb 2020 15:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF670246AF for ; Fri, 28 Feb 2020 15:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbgB1PeT (ORCPT ); Fri, 28 Feb 2020 10:34:19 -0500 Received: from muru.com ([72.249.23.125]:58180 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727077AbgB1PeT (ORCPT ); Fri, 28 Feb 2020 10:34:19 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 70E1F806C; Fri, 28 Feb 2020 15:35:03 +0000 (UTC) Date: Fri, 28 Feb 2020 07:34:15 -0800 From: Tony Lindgren To: Laurent Pinchart Cc: Sebastian Reichel , Sebastian Reichel , Tomi Valkeinen , Merlijn Wajer , "H. Nikolaus Schaller" , Rob Herring , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCHv2 02/56] ARM: dts: omap4-droid4: add panel compatible Message-ID: <20200228153415.GL37466@atomide.com> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200224232126.3385250-3-sebastian.reichel@collabora.com> <20200224233708.GG16163@pendragon.ideasonboard.com> <20200224234759.GE37466@atomide.com> <20200227221052.GC4959@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227221052.GC4959@pendragon.ideasonboard.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Laurent Pinchart [200227 22:12]: > Hi Tony, > > On Mon, Feb 24, 2020 at 03:47:59PM -0800, Tony Lindgren wrote: > > * Laurent Pinchart [200224 23:38]: > > > On Tue, Feb 25, 2020 at 12:20:32AM +0100, Sebastian Reichel wrote: > > > > Add Droid 4 specific compatible value in addition to the > > > > generic one, so that we have the ability to add panel > > > > specific quirks in the future. > > > > > > We need to document this compatible string in DT bindings, I don't think > > > this is included in this series. Furthermore, could we use a compatible > > > string that actually matches the panel vendor and model, instead of the > > > device name ? > > > > To me it seems there are multiple similar panels from various > > vendors in use for xt875/xt894/xt910/xt912 phones, I'm not sure > > if anybody has this list? > > Are they all truly compatible ? Well that is still unknown. We know that x894 panel config works with xt875 at least. The panels are different looking the original dtb files. Best to use device specific compatibles like Sebastian is doing. If we ever get some real manufacturer and model data, we can add that. Regards, Tony