Linux-OMAP Archive on
 help / color / Atom feed
* [PATCH] ARM: dts: omap4-droid4: Fix lost touchscreen interrupts
@ 2020-03-14 20:55 Tony Lindgren
  0 siblings, 0 replies; only message in thread
From: Tony Lindgren @ 2020-03-14 20:55 UTC (permalink / raw)
  To: linux-omap
  Cc: Benoît Cousson, devicetree, maemo-leste, Arthur Demchenkov,
	Ivaylo Dimitrov, Merlijn Wajer, Pavel Machek, Sebastian Reichel

Looks like we can have the maxtouch touchscreen stop producing interrupts
if an edge interrupt is lost. This can happen easily when the SoC idles as
the gpio controller may not see any state for an edge interrupt if it
is briefly triggered when the system is idle.

Also it looks like maxtouch stops sending any further interrupts if the
interrupt is not handled. And we do have several cases of maxtouch already
configured with a level interrupt, so let's do that.

With level interrupt the gpio controller has the interrupt state visible
after idle. Note that eventually we will probably also be using the
Linux generic wakeirq configured for the controller, but that cannot be
done until the maxtouch driver supports runtime PM.

Cc: Arthur Demchenkov <>
Cc: Ivaylo Dimitrov <>
Cc: Merlijn Wajer <>
Cc: Pavel Machek <>
Cc: Sebastian Reichel <>
Signed-off-by: Tony Lindgren <>
 arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
--- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
+++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
@@ -429,7 +429,7 @@ touchscreen@4a {
 		reset-gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>; /* gpio173 */
 		/* gpio_183 with sys_nirq2 pad as wakeup */
-		interrupts-extended = <&gpio6 23 IRQ_TYPE_EDGE_FALLING>,
+		interrupts-extended = <&gpio6 23 IRQ_TYPE_LEVEL_LOW>,
 				      <&omap4_pmx_core 0x160>;
 		interrupt-names = "irq", "wakeup";

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 20:55 [PATCH] ARM: dts: omap4-droid4: Fix lost touchscreen interrupts Tony Lindgren

Linux-OMAP Archive on

Archives are clonable:
	git clone --mirror linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ \
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone