From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F8DC18E5B for ; Sun, 15 Mar 2020 16:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C95C20736 for ; Sun, 15 Mar 2020 16:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728916AbgCOQq1 (ORCPT ); Sun, 15 Mar 2020 12:46:27 -0400 Received: from muru.com ([72.249.23.125]:60506 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgCOQq1 (ORCPT ); Sun, 15 Mar 2020 12:46:27 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4893F81D5; Sun, 15 Mar 2020 16:47:13 +0000 (UTC) Date: Sun, 15 Mar 2020 09:46:24 -0700 From: Tony Lindgren To: Arthur Demchenkov Cc: Merlijn Wajer , Pavel Machek , sre@kernel.org, linux-pm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 02/15] power: supply: cpcap-battery: Improve battery full status detection Message-ID: <20200315164624.GI37466@atomide.com> References: <20200315151206.30909-1-spinal.by@gmail.com> <20200315151206.30909-2-spinal.by@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200315151206.30909-2-spinal.by@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Arthur Demchenkov [200315 15:15]: > If the battery status is detected as full for the charging current that > doesn't exceed 100 mA, it will then be reported as full for charging > currents in the range of 100-150 mA. This is needed because > charge_current value has a spread. > > We don't use avg_current here because it can trigger wrong battery full > status on charger connected event. Hmm oh so this is against my earlier RFC patches. Care to respin the series against v5.6-rc? Feel free tweak my patches to leave out the unnecessary stuff as we decided to do things in a better way :) Just add a note like: [spinal: dropped out unusable foo and bar] So we know what got changed compared to the RFC patches. And then we might have a nice working set for merging in subject to others approving this approach of course :) Regards, Tony