From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B55B7C2BA15 for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6119E207FF for ; Fri, 3 Apr 2020 17:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OrR7ulO7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403824AbgDCRSW (ORCPT ); Fri, 3 Apr 2020 13:18:22 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41284 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403976AbgDCRSW (ORCPT ); Fri, 3 Apr 2020 13:18:22 -0400 Received: by mail-pl1-f194.google.com with SMTP id d24so2945639pll.8 for ; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=OrR7ulO7CQcgKwh4Z0ptkVpD+g4IWz0YSQouVgIJkq8zylNmdM9VjUkYCI+zVEXHq1 lrjk0v+SzzklSA+3mXp5BODy0jlzOmVXnhkQZrA5LosYzEJPjTc+DVjL3q19L6W2p/2Y GSb8p2z3ej4vxJWgTaITIQwIo7RZ5qCAjuCHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rNydFgIXCSgJ49gDNlW+t8MZPAxnkdmyTdnJc8LVEbc=; b=jyMz4X5fEvNHCfuYCP3jn09UB0IjfysYr+n+nScSO5rUhGWlEjocxoGhX7zLWh/7wA sckrdEB3JIUgR/44smTuc8xzjjHWaVeGIuI3R4H709mn1IOuz/H1r0A7TX00pqiBnj7C 34xD9AOz7VXxTjtzzFmHt9FTgSGf8sgwk3muBWm/Rz/EstIOi4Qktqx2yug5IjHMrMvI BZVNzpwgpT8iNwshpeTHT/AwJvZYq8+rN7jtUKYPoJiJAqf1Nnoj96CSfE/iJJ6TOwX/ dQRXYY7j1o3UZrdyx7gAjrQQSst1S/HcG88QZMwqyj1b8/lLmcgPK4WDMPo1gqwh+Wze pbKg== X-Gm-Message-State: AGi0Puaz3Y7stdHLiGPep91TQgFR1Fg1vxTXOVHElxrNQ2C40nPxBTd3 iX8fNJKO2SYqvO2M+5AhD5E98Q== X-Google-Smtp-Source: APiQypKQpzA+XTDciIpGBBtkz7UQo2nLfVOgWlxENb8GSyeAvVRwH6+mhz6UsIGNuBo3cdO/izbarA== X-Received: by 2002:a17:90a:20ad:: with SMTP id f42mr10684986pjg.135.1585934301262; Fri, 03 Apr 2020 10:18:21 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 13sm6219335pfn.131.2020.04.03.10.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 10:18:20 -0700 (PDT) Date: Fri, 3 Apr 2020 10:18:18 -0700 From: Matthias Kaehlcke To: Daniel Lezcano Cc: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, qperret@google.com, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org Subject: Re: [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Message-ID: <20200403171818.GO199755@google.com> References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-4-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Daniel, On Fri, Apr 03, 2020 at 06:43:20PM +0200, Daniel Lezcano wrote: > On 18/03/2020 12:45, Lukasz Luba wrote: > > From: Matthias Kaehlcke > > > > Now that devfreq supports limiting the frequency range of a device > > through PM QoS make use of it instead of disabling OPPs that should > > not be used. > > > > The switch from disabling OPPs to PM QoS introduces a subtle behavioral > > change in case of conflicting requests (min > max): PM QoS gives > > precedence to the MIN_FREQUENCY request, while higher OPPs disabled > > with dev_pm_opp_disable() would override MIN_FREQUENCY. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Lukasz Luba > > Reviewed-by: Chanwoo Choi > > This patch is standalone, right? If yes, I will apply it. Yes, it is standalone, please apply Thanks Matthias