Re: [PATCH 4/6] dt-bindings: gnss: Add binding for Motorola Mapphone MDM6600 GNSS

[Rob Herring <robh@kernel.org>]

On Thu, Apr 30, 2020 at 10:46:13AM -0700, Tony Lindgren wrote:
> Add a binding document for Motorola Mapphone MDM6600 GNSS driver that
> can be used with phones such as droid4.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  .../devicetree/bindings/gnss/motmdm.yaml      | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gnss/motmdm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Motorola Mapphone MDM6600 GNSS binding
> +
> +maintainers:
> +  - Tony Lindgren <tony@atomide.com>
> +
> +properties:
> +  compatible:
> +    const: motorola,mapphone-mdm6600-gnss
> +
> +  reg:
> +    items:
> +      description: TS 27.010 channel the GNSS device is using
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    gnss@4 {

This is a child of what's in patch 2? I think I'd just combine this 
schema into it.

Or you can leave it, but better to have complete examples (which will 
help fix what my bot reports). Examples have a default 
#address/size-cells of 1.

> +      compatible = "motorola,mapphone-mdm6600-gnss";
> +      reg = <4>;
> +    };
> -- 
> 2.26.2