Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Johan Hovold <johan@kernel.org>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	Lee Jones <lee.jones@linaro.org>, Jiri Slaby <jslaby@suse.cz>,
	Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
	Peter Hurley <peter@hurleysoftware.com>,
	Sebastian Reichel <sre@kernel.org>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: gnss: Add binding for Motorola Mapphone MDM6600 GNSS
Date: Fri, 1 May 2020 16:19:24 -0500
Message-ID: <20200501211924.GB6222@bogus> (raw)
In-Reply-To: <20200430174615.41185-5-tony@atomide.com>

On Thu, Apr 30, 2020 at 10:46:13AM -0700, Tony Lindgren wrote:
> Add a binding document for Motorola Mapphone MDM6600 GNSS driver that
> can be used with phones such as droid4.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  .../devicetree/bindings/gnss/motmdm.yaml      | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gnss/motmdm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Motorola Mapphone MDM6600 GNSS binding
> +
> +maintainers:
> +  - Tony Lindgren <tony@atomide.com>
> +
> +properties:
> +  compatible:
> +    const: motorola,mapphone-mdm6600-gnss
> +
> +  reg:
> +    items:
> +      description: TS 27.010 channel the GNSS device is using
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    gnss@4 {

This is a child of what's in patch 2? I think I'd just combine this 
schema into it.

Or you can leave it, but better to have complete examples (which will 
help fix what my bot reports). Examples have a default 
#address/size-cells of 1.

> +      compatible = "motorola,mapphone-mdm6600-gnss";
> +      reg = <4>;
> +    };
> -- 
> 2.26.2

  parent reply index

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 17:46 [PATCHv6 0/6] n_gsm serdev support and GNSS driver for droid4 Tony Lindgren
2020-04-30 17:46 ` [PATCH 1/6] tty: n_gsm: Add support for serdev drivers Tony Lindgren
2020-05-01 20:31   ` Pavel Machek
2020-05-01 21:31     ` Tony Lindgren
2020-04-30 17:46 ` [PATCH 2/6] dt-bindings: serdev: ngsm: Add binding for serdev-ngsm Tony Lindgren
2020-05-01 20:33   ` Pavel Machek
2020-05-12 15:37   ` Rob Herring
2020-04-30 17:46 ` [PATCH 3/6] serdev: ngsm: Add generic serdev-ngsm driver Tony Lindgren
2020-05-01 20:44   ` Pavel Machek
2020-04-30 17:46 ` [PATCH 4/6] dt-bindings: gnss: Add binding for Motorola Mapphone MDM6600 GNSS Tony Lindgren
2020-05-01 20:45   ` Pavel Machek
2020-05-01 21:14   ` Rob Herring
2020-05-01 21:19   ` Rob Herring [this message]
2020-05-01 21:25     ` Tony Lindgren
2020-04-30 17:46 ` [PATCH 5/6] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem Tony Lindgren
2020-05-01 20:51   ` Pavel Machek
2020-04-30 17:46 ` [PATCH 6/6] ARM: dts: omap4-droid4: Configure modem for serdev-ngsm Tony Lindgren
2020-05-01 20:53   ` Pavel Machek
2020-04-30 22:26 ` [PATCHv6 0/6] n_gsm serdev support and GNSS driver for droid4 Pavel Machek
2020-05-01 14:52   ` Tony Lindgren
2020-05-01 22:06     ` Pavel Machek
2020-05-01  8:21 ` Pavel Machek
2020-05-01 14:20   ` Tony Lindgren
2020-05-01 20:19 ` Pavel Machek
2020-05-01 20:32   ` Tony Lindgren
2020-05-01 20:23 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501211924.GB6222@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=jslaby@suse.cz \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=pavel@ucw.cz \
    --cc=peter@hurleysoftware.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git