From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6320C54E4A for ; Thu, 7 May 2020 06:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6258207DD for ; Thu, 7 May 2020 06:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588834062; bh=hUD5exA4dNKvCcKV83BYNh5VFO685TqU5GU5ToDg3us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=s8rLTne2cHG2cyxoiC6ffsMs1qdgXaU63XxkAo2GApSXw6Kwqm4pYPjVe45u62BO4 lkEJBImiE5+9uZ51iCnK4pvnkxq8E1I4+mYqknNTcOii3eLhjnbopao6yCh9iUibET wsUSl7yIg5fp8V3v6IUtZlf23XgtU8RMhEGRdBz4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725893AbgEGGrh (ORCPT ); Thu, 7 May 2020 02:47:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:36338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbgEGGrh (ORCPT ); Thu, 7 May 2020 02:47:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D794F2078C; Thu, 7 May 2020 06:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588834056; bh=hUD5exA4dNKvCcKV83BYNh5VFO685TqU5GU5ToDg3us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCZ6mLUcN1lIcruUpjFnEcOhlyrmSgxjeyHHlnFw/4co12Hwb9W/Qsgzq6nZ+HnJp DibKlr9P4RQGxGYL3/8X8BfHpXRz53ezegCOp/1lVZvRByJvVXChNS4+D1DL4tpB3T fOVh6T5cCACfVwnSp8ZDtkKBDaj/Y7C6rRFAF5rg= Date: Thu, 7 May 2020 08:47:34 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Naresh Kamboju , linux- stable , Sasha Levin , "David S. Miller" , Vince Bridgers , Florian Fainelli , Fugang Duan , Pantelis Antoniou , Vitaly Bordug , Claudiu Manoil , Li Yang , Thomas Petazzoni , Felix Fietkau , John Crispin , Matthias Brugger , Sergei Shtylyov , Lars Persson , Mugunthan V N , Grygorii Strashko , Rob Herring , Frank Rowand , Andrew Lunn , Vivien Didelot , Netdev , nios2-dev@lists.rocketboards.org, open list , linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200507064734.GA798308@kroah.com> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> <20200507064412.GL2042@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507064412.GL2042@localhost> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, May 07, 2020 at 08:44:12AM +0200, Johan Hovold wrote: > On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote: > > On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > > > > > Make sure to deregister and free any fixed-link PHY registered using > > > of_phy_register_fixed_link() on probe errors and on driver unbind. > > > > > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > > > Signed-off-by: Johan Hovold > > > --- > > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > > index 0c0a45af950f..707bc4680b9b 100644 > > > --- a/drivers/net/ethernet/marvell/mvneta.c > > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > > > clk_disable_unprepare(pp->clk); > > > err_put_phy_node: > > > of_node_put(phy_node); > > > + if (of_phy_is_fixed_link(dn)) > > > + of_phy_deregister_fixed_link(dn); > > > > While building kernel Image for arm architecture on stable-rc 4.4 branch > > the following build error found. > > > > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit > > declaration of function 'of_phy_deregister_fixed_link'; did you mean > > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] > > | of_phy_deregister_fixed_link(dn); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > | of_phy_register_fixed_link > > > > ref: > > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > PHYs") needs to be backported as well for these. > > Original series can be found here: > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org Ah, thanks for that, I thought I dropped all of the ones that caused build errors, but missed the above one. I'll go take the whole series instead. greg k-h