From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Zack Pearsall <zpearsall@yahoo.com>,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mfd: tps65910: Correct power-off programming sequence
Date: Fri, 15 May 2020 15:30:11 +0200 [thread overview]
Message-ID: <20200515110754.GB20564@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200514205022.7024-1-digetx@gmail.com>
On Thu, May 14, 2020 at 11:50:21PM +0300, Dmitry Osipenko wrote:
> This patch fixes system shutdown on a devices that use TPS65910 as a
> system's power controller. In accordance to the TPS65910 datasheet, the
> PMIC's state-machine transitions into the OFF state only when DEV_OFF
> bit of DEVCTRL_REG is set. The ON / SLEEP states also should be cleared,
> otherwise PMIC won't get into a proper state on shutdown. Devices like
> Nexus 7 tablet and Ouya game console are now shutting down properly.
>
> Tested-by: Zack Pearsall <zpearsall@yahoo.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/mfd/tps65910.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 11959021b50a..22116cee411d 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -440,8 +440,16 @@ static void tps65910_power_off(void)
> DEVCTRL_PWR_OFF_MASK) < 0)
> return;
>
> - tps65910_reg_clear_bits(tps65910, TPS65910_DEVCTRL,
> - DEVCTRL_DEV_ON_MASK);
> + if (tps65910_reg_clear_bits(tps65910, TPS65910_DEVCTRL,
> + DEVCTRL_DEV_SLP_MASK) < 0)
> + return;
> +
> + if (tps65910_reg_clear_bits(tps65910, TPS65910_DEVCTRL,
> + DEVCTRL_DEV_ON_MASK) < 0)
> + return;
> +
> + tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
> + DEVCTRL_DEV_OFF_MASK);
> }
Isn't it enough to update the DEVCTRL with just one
tps65910_reg_update_bits()?
Best Regards
Michał Mirosław
next prev parent reply other threads:[~2020-05-15 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 20:50 [PATCH v1] mfd: tps65910: Correct power-off programming sequence Dmitry Osipenko
2020-05-15 13:30 ` Michał Mirosław [this message]
2020-05-15 17:30 ` Dmitry Osipenko
2020-05-24 19:09 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515110754.GB20564@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=zpearsall@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).