From: Drew Fustini <drew@beagleboard.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Robert Nelson" <robertcnelson@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux kernel" <linux-kernel@vger.kernel.org>,
"Jason Kridner" <jkridner@beagleboard.org>
Subject: Re: [PATCH v2] arm: dts: am33xx-bone-common: add gpio-line-names
Date: Thu, 21 May 2020 21:23:39 +0200 [thread overview]
Message-ID: <20200521192339.GA429020@x1> (raw)
In-Reply-To: <cdf82f9c-48fb-49a0-99e4-926dc292c109@ti.com>
On Thu, May 21, 2020 at 08:26:42PM +0300, Grygorii Strashko wrote:
>
>
> On 21/05/2020 17:41, Robert Nelson wrote:
> > > Not sure if it should be in am335x-bone-common.dtsi.
> > >
> > > For example:
> > > am335x-boneblack.dts
> > > #include "am335x-bone-common.dtsi"
> > > #include "am335x-boneblack-common.dtsi" <-- hdmi defined only here
> >
> > Ah crap, yeah that's a good point.. So if we stick it in...
> > am335x-boneblack-common.dtsi
> >
> > Then the Black-Wireless now has Ethernet...
> >
> > am335x-boneblack-wireless.dts
> > #include "am335x-bone-common.dtsi"
> > #include "am335x-boneblack-common.dtsi"
> >
> > It's going to be ugly, copy and paste mess, but i guess we might as
> > well stick it in the device " am335x-boneblack.dts"?
>
> Seems like.
>
> Unfortunately, there is no way to partially overwrite "gpio-line-names"
> property.
>
> --
> Best regards,
> grygorii
Thank you for pointing out that those gpio-line-names are really
specific to the BeagleBone Black and not applicable for other boards
like the BeagleBone Green which lack eMMC.
I will post a new patch for am335x-boneblack.dts.
After that is reviewed and applied, I will then create patches for the
the other BeagleBone models.
thanks,
drew
prev parent reply other threads:[~2020-05-21 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 21:47 [PATCH v2] arm: dts: am33xx-bone-common: add gpio-line-names Drew Fustini
2020-05-21 14:34 ` Grygorii Strashko
2020-05-21 14:41 ` Robert Nelson
2020-05-21 17:26 ` Grygorii Strashko
2020-05-21 19:23 ` Drew Fustini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521192339.GA429020@x1 \
--to=drew@beagleboard.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).