Linux-OMAP Archive on
 help / color / Atom feed
* [PATCH v2] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend
@ 2020-05-22 17:09 Grygorii Strashko
  0 siblings, 0 replies; only message in thread
From: Grygorii Strashko @ 2020-05-22 17:09 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski
  Cc: netdev, Sekhar Nori, linux-kernel, linux-omap, Suman Anna,
	Grygorii Strashko

vlan_for_each() are required to be called with rtnl_lock taken, otherwise
ASSERT_RTNL() warning will be triggered - which happens now during System
resume from suspend:
  |- cpsw_ndo_stop()
    |- __hw_addr_ref_unsync_dev()
      |- cpsw_purge_all_mc()
         |- vlan_for_each()
            |- ASSERT_RTNL();

Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.

Fixes: 15180eca569b ("net: ethernet: ti: cpsw: fix vlan mcast")
Signed-off-by: Grygorii Strashko <>
v2: fix "fixes" tag

 drivers/net/ethernet/ti/cpsw.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c2c5bf87da01..ffeb8633e530 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1753,11 +1753,15 @@ static int cpsw_suspend(struct device *dev)
 	struct cpsw_common *cpsw = dev_get_drvdata(dev);
 	int i;
+	rtnl_lock();
 	for (i = 0; i < cpsw->data.slaves; i++)
 		if (cpsw->slaves[i].ndev)
 			if (netif_running(cpsw->slaves[i].ndev))
+	rtnl_unlock();
 	/* Select sleep pin state */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 17:09 [PATCH v2] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend Grygorii Strashko

Linux-OMAP Archive on

Archives are clonable:
	git clone --mirror linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ \
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone