From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87009C433DF for ; Wed, 27 May 2020 16:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64B6E20873 for ; Wed, 27 May 2020 16:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390733AbgE0QFr (ORCPT ); Wed, 27 May 2020 12:05:47 -0400 Received: from muru.com ([72.249.23.125]:55848 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389399AbgE0QFq (ORCPT ); Wed, 27 May 2020 12:05:46 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 26A6B80DB; Wed, 27 May 2020 16:06:36 +0000 (UTC) Date: Wed, 27 May 2020 09:05:43 -0700 From: Tony Lindgren To: Tomi Valkeinen Cc: Faiz Abbas , Keerthy , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, bcousson@baylibre.com Subject: Re: [PATCH v2] arm: dts: Move am33xx and am43xx mmc nodes to sdhci-omap driver Message-ID: <20200527160543.GI37466@atomide.com> References: <20200512203804.9340-1-faiz_abbas@ti.com> <20200513162327.GM37466@atomide.com> <94025425-95e2-e53d-cfac-a1e73e6c011a@ti.com> <53c815db-dd7d-e6e1-f81a-cf05ef340c71@ti.com> <20200519154807.GT37466@atomide.com> <20200519160458.GU37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519160458.GU37466@atomide.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tony Lindgren [200519 09:05]: > * Tomi Valkeinen [200519 15:55]: > > (Dropping DT from cc) > > > > On 19/05/2020 18:48, Tony Lindgren wrote: > > > > > > > Suspend/resume on am43xx-gpevm is broken right now in mainline and the regression looks > > > > > like it is caused by the display subsystem. I have reported this to Tomi and > > > > > its being investigated. > > > > > > > > > > Meanwhile I have tested this patch with display configs disabled and Keerthy's > > > > > suspend/resume tests pass on both am3 and am4. > > > > > > OK great thanks for checking it. Do you have the display subsystem > > > related commit that broke PM? I'm wondering if my recent DSS platform > > > data removal changes might have caused the regression. > > > > I spent a bit time looking at this, but unfortunately I wasn't even able to > > resume my AM4 evm from suspend. I tried with rtcwake and with plain console > > (with no_console_suspend). I did not have DSS loaded. > > My test-bbb-suspend script seems to have: > > sudo modprobe wkup_m3_ipc > sudo modprobe pm33xx > sudo modprobe rtc-omap > rtcwake -m mem -s 5 > > I think the same should work for am437x. But some boards do not support > deep sleep like am437x-idk. > > > Anyone have quick hints on how to debug why resume doesn't seem to happen? > > You might get some info with no_console_suspend, but that might also > cause other issues. To me it seems we may have some dss clock missing with the ti-sysc dts changes that makes resume fail. Or else there is some ordering issue between the dss components now on resume, I'll try to debug more. Regards, Tony