From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BB1C433DF for ; Sat, 13 Jun 2020 22:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5302A2078A for ; Sat, 13 Jun 2020 22:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbgFMWiD (ORCPT ); Sat, 13 Jun 2020 18:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgFMWiD (ORCPT ); Sat, 13 Jun 2020 18:38:03 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0719FC03E96F; Sat, 13 Jun 2020 15:38:02 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4801B11F5F637; Sat, 13 Jun 2020 15:38:02 -0700 (PDT) Date: Sat, 13 Jun 2020 15:38:01 -0700 (PDT) Message-Id: <20200613.153801.1383724005122062451.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, kuba@kernel.org, m-karicheri2@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: ale: fix allmulti for nu type ale From: David Miller In-Reply-To: <20200613145414.17190-1-grygorii.strashko@ti.com> References: <20200613145414.17190-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 13 Jun 2020 15:38:02 -0700 (PDT) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Grygorii Strashko Date: Sat, 13 Jun 2020 17:54:14 +0300 > On AM65xx MCU CPSW2G NUSS and 66AK2E/L NUSS allmulti setting does not allow > unregistered mcast packets to pass. > > This happens, because ALE VLAN entries on these SoCs do not contain port > masks for reg/unreg mcast packets, but instead store indexes of > ALE_VLAN_MASK_MUXx_REG registers which intended for store port masks for > reg/unreg mcast packets. > This path was missed by commit 9d1f6447274f ("net: ethernet: ti: ale: fix > seeing unreg mcast packets with promisc and allmulti disabled"). > > Hence, fix it by taking into account ALE type in cpsw_ale_set_allmulti(). > > Fixes: 9d1f6447274f ("net: ethernet: ti: ale: fix seeing unreg mcast packets with promisc and allmulti disabled") > Signed-off-by: Grygorii Strashko Applied and queued up for v5.7 -stable.