From: Drew Fustini <drew@beagleboard.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Rob Herring <robh+dt@kernel.org>,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] ARM: dts: am335x-pocketbeagle: set default mux for gpio pins
Date: Tue, 30 Jun 2020 04:01:02 +0200 [thread overview]
Message-ID: <20200630020102.GA45128@x1> (raw)
In-Reply-To: <20200629170358.GT37466@atomide.com>
On Mon, Jun 29, 2020 at 10:03:58AM -0700, Tony Lindgren wrote:
> Hi,
>
> * Drew Fustini <drew@beagleboard.org> [200628 08:26]:
> > v2 changes:
> > - change default mux from output to input. Input is safer as it does
> > not drive the line. If the user wants output, they will need to edit
> > this device tree.
>
> So can you please clarify this a bit, are you saying that gpio output can't
> be done via userspace?
As it stands, there is no way for userspace to change a pin from gpio
input to gpio output as it is based on the reciever active bit in the
pin control register (table 9-60 in the AM3358 datasheet [0]).
I thought it would be useful to at least define the GPIOs available for
use on the PocketBeagle by default (and eventually the other BeagleBone
device trees). Input seems to be the safest value. This patch at least
makes it more clear where the user should edit to switch from input to
output.
> Needing to change the dts does not sound good to me.. But maybe you mean
> this is needed until the gpio-omap and pinctrl-single patches are merged?
>
> Regards,
>
> Tony
I agree that I would like for userspace to be able to do run-time
changes. However, I think something would need to be added to the
pinconf support in pinctrl-single for that to be possible. There are
bias properties but non for receiver enable.
Does it seem sensible to add that?
thanks,
drew
[0] http://www.ti.com/lit/ds/symlink/am3358.pdf
next prev parent reply other threads:[~2020-06-30 2:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 15:24 [PATCH v2] ARM: dts: am335x-pocketbeagle: set default mux for gpio pins Drew Fustini
2020-06-29 17:03 ` Tony Lindgren
2020-06-30 2:01 ` Drew Fustini [this message]
2020-06-30 18:20 ` Tony Lindgren
2020-06-30 21:31 ` Drew Fustini
2020-06-30 21:34 ` Tony Lindgren
2020-06-30 21:42 ` Drew Fustini
2020-07-01 14:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630020102.GA45128@x1 \
--to=drew@beagleboard.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).