Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on omap/for-next]
[also build test WARNING on robh/for-next keystone/next v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/Add-initial-genpd-support-for-omap-PRM-driver/20200623-004919
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
config: arm-randconfig-r011-20200629 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a28d38a6bca1726d56c9b373f4c7dc5264fc7716)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/soc/ti/omap_prm.c:98:21: warning: attribute declaration must precede definition [-Wignored-attributes]
   static const struct __maybe_unused omap_prm_domain_map omap_prm_noinact = {
                       ^
   include/linux/compiler_attributes.h:259:56: note: expanded from macro '__maybe_unused'
   #define __maybe_unused                  __attribute__((__unused__))
                                                          ^
   drivers/soc/ti/omap_prm.c:30:8: note: previous definition is here
   struct omap_prm_domain_map {
          ^
   drivers/soc/ti/omap_prm.c:105:21: warning: attribute declaration must precede definition [-Wignored-attributes]
   static const struct __maybe_unused omap_prm_domain_map omap_prm_onoff_noauto = {
                       ^
   include/linux/compiler_attributes.h:259:56: note: expanded from macro '__maybe_unused'
   #define __maybe_unused                  __attribute__((__unused__))
                                                          ^
   drivers/soc/ti/omap_prm.c:30:8: note: previous definition is here
   struct omap_prm_domain_map {
          ^
   2 warnings generated.

vim +98 drivers/soc/ti/omap_prm.c

    97	
  > 98	static const struct __maybe_unused omap_prm_domain_map omap_prm_noinact = {
    99		.usable_modes = BIT(OMAP_PRMD_ON_ACTIVE) | BIT(OMAP_PRMD_RETENTION) |
   100				BIT(OMAP_PRMD_OFF),
   101		.statechange = 1,
   102		.logicretstate = 1,
   103	};
   104	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org