From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Sam Ravnborg <sam@ravnborg.org>, Tony Lindgren <tony@atomide.com>,
Pavel Machek <pavel@ucw.cz>, Merlijn Wajer <merlijn@wizzup.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv1 2/4] ARM: dts: omap: add channel to DSI panels
Date: Sat, 11 Jul 2020 01:51:54 +0300 [thread overview]
Message-ID: <20200710225154.GA5964@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200629223315.118256-3-sebastian.reichel@collabora.com>
Hi Sebastian,
Thank you for the patch.
On Tue, Jun 30, 2020 at 12:33:13AM +0200, Sebastian Reichel wrote:
> The standard binding for DSI requires, that the channel number
s/requires,/requires/
> of the panel is encoded in DT. This adds the channel number in
> all OMAP3-5 boards, in preparation for using common infrastructure.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/motorola-mapphone-common.dtsi | 3 ++-
> arch/arm/boot/dts/omap3-n950.dts | 3 ++-
> arch/arm/boot/dts/omap3.dtsi | 3 +++
> arch/arm/boot/dts/omap4-sdp.dts | 6 ++++--
> arch/arm/boot/dts/omap4.dtsi | 6 ++++++
> arch/arm/boot/dts/omap5.dtsi | 6 ++++++
> 6 files changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> index 06fbffa81636..4ffe461c3808 100644
> --- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> +++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
> @@ -207,8 +207,9 @@ dsi1_out_ep: endpoint {
> };
> };
>
> - lcd0: display {
> + lcd0: panel@0 {
> compatible = "panel-dsi-cm";
> + reg = <0>;
> label = "lcd0";
> vddi-supply = <&lcd_regulator>;
> reset-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* gpio101 */
> diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts
> index 31d47a1fad84..80cf4e1177da 100644
> --- a/arch/arm/boot/dts/omap3-n950.dts
> +++ b/arch/arm/boot/dts/omap3-n950.dts
> @@ -225,8 +225,9 @@ dsi_out_ep: endpoint {
> };
> };
>
> - lcd0: display {
> + lcd0: panel@0 {
> compatible = "nokia,himalaya", "panel-dsi-cm";
> + reg = <0>;
> label = "lcd0";
>
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 1296d0643943..0ebbb6c11f04 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -898,6 +898,9 @@ dsi: encoder@4804fc00 {
> ti,hwmods = "dss_dsi1";
> clocks = <&dss1_alwon_fck>, <&dss2_alwon_fck>;
> clock-names = "fck", "sys_clk";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> };
>
> rfbi: encoder@48050800 {
> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
> index 91480ac1f328..8a8307517dab 100644
> --- a/arch/arm/boot/dts/omap4-sdp.dts
> +++ b/arch/arm/boot/dts/omap4-sdp.dts
> @@ -662,8 +662,9 @@ dsi1_out_ep: endpoint {
> };
> };
>
> - lcd0: display {
> + lcd0: panel@0 {
> compatible = "tpo,taal", "panel-dsi-cm";
> + reg = <0>;
> label = "lcd0";
>
> reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
> @@ -687,8 +688,9 @@ dsi2_out_ep: endpoint {
> };
> };
>
> - lcd1: display {
> + lcd1: panel@0 {
> compatible = "tpo,taal", "panel-dsi-cm";
> + reg = <0>;
> label = "lcd1";
>
> reset-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; /* 104 */
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 4400f5f8e099..c5b426616443 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -551,6 +551,9 @@ dsi1: encoder@0 {
> clocks = <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 8>,
> <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 10>;
> clock-names = "fck", "sys_clk";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> };
> };
>
> @@ -583,6 +586,9 @@ dsi2: encoder@0 {
> clocks = <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 8>,
> <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 10>;
> clock-names = "fck", "sys_clk";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index fb889c5b00c9..0855c0a4050f 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -491,6 +491,9 @@ dsi1: encoder@0 {
> status = "disabled";
> clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> clock-names = "fck";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> };
> };
>
> @@ -522,6 +525,9 @@ dsi2: encoder@0 {
> status = "disabled";
> clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> clock-names = "fck";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> };
> };
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-07-10 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 22:33 [PATCHv1 0/4] panel-dsi-cm: update bindings Sebastian Reichel
2020-06-29 22:33 ` [PATCHv1 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
2020-06-30 5:50 ` Sam Ravnborg
2020-07-10 23:02 ` Laurent Pinchart
2020-07-15 20:30 ` Rob Herring
2020-06-29 22:33 ` [PATCHv1 2/4] ARM: dts: omap: add channel to DSI panels Sebastian Reichel
2020-07-10 22:51 ` Laurent Pinchart [this message]
2020-06-29 22:33 ` [PATCHv1 3/4] ARM: dts: omap4-droid4: add panel compatible Sebastian Reichel
2020-07-10 22:50 ` Laurent Pinchart
2020-06-29 22:33 ` [PATCHv1 4/4] ARM: dts: omap4-droid4: add panel orientation Sebastian Reichel
2020-07-10 22:52 ` Laurent Pinchart
2020-06-30 5:51 ` [PATCHv1 0/4] panel-dsi-cm: update bindings Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710225154.GA5964@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=kernel@collabora.com \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).