From: Stephen Rothwell <sfr@canb.auug.org.au>
To: dillon min <dillon.minfei@gmail.com>
Cc: Benoit Cousson <bcousson@baylibre.com>,
tony@atomide.com, Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Since am437x have the same clock structure with am335x [1][2], reuse the code from Tony Lindgren's patch [3] to fix dcan probe failed on am437x platform.
Date: Tue, 14 Jul 2020 13:54:07 +1000 [thread overview]
Message-ID: <20200714135407.35992389@canb.auug.org.au> (raw)
In-Reply-To: <CAL9mu0JurdBoXbSxvHUmNFSBOa=RneNyYtzT=C1MvJs10Y-Geg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]
Hi Dillon,
On Tue, 14 Jul 2020 11:43:31 +0800 dillon min <dillon.minfei@gmail.com> wrote:
>
> On Tue, Jul 14, 2020 at 11:38 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 14 Jul 2020 11:23:18 +0800 dillon.minfei@gmail.com wrote:
> > >
> > > From: dillon min <dillon.minfei@gmail.com>
> > >
> > > Fixes: 1a5cd7c23cc5 ("bus: ti-sysc: Enable all clocks directly during init to read revision")
> > >
> > > [1]: https://www.ti.com/lit/pdf/spruh73 Chapter-23, Figure 23-1. DCAN
> > > Integration
> > > [2]: https://www.ti.com/lit/pdf/spruhl7 Chapter-25, Figure 25-1. DCAN
> > > Integration
> > > [3]: commit 516f1117d0fb ("ARM: dts: Configure osc clock for d_can on am335x")
> > >
> > > Signed-off-by: dillon min <dillon.minfei@gmail.com>
> > > ---
> > >
> > > Hi Stephen,
> > >
> > > This changes correct commit messages based on your reviewing.
> > > make Fixes tags to oneline.
> > > make all commit message tags at the end of commit message
> >
> > But the Fixes: line should be down with the Signed-off-by: line ...
> >
> Ok, should it be like this，i will resubmit it.
>
> Subject: [PATCH v2] Since am437x have the same clock structure with am335x
> [1][2], reuse the code from Tony Lindgren's patch [3] to fix dcan
> probe failed on the am437x platform.
You should have a shorter subject and maybe the above could be the
first paragraph of the commit message.
>
> [1]: https://www.ti.com/lit/pdf/spruh73 Chapter-23, Figure 23-1. DCAN
> Integration
> [2]: https://www.ti.com/lit/pdf/spruhl7 Chapter-25, Figure 25-1. DCAN
> Integration
> [3]: commit 516f1117d0fb ("ARM: dts: Configure osc clock for d_can on am335x")
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> Fixes: 1a5cd7c23cc5 ("bus: ti-sysc: Enable all clocks directly during
> init to read revision")
No wrapping the the Fixes line, please and it would usually go before
your Signed=off-by line
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-14 3:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 3:23 [PATCH v2] ARM: dts: Configure osc clock for d_can on am437x dillon.minfei
2020-07-14 3:23 ` [PATCH v2] Since am437x have the same clock structure with am335x [1][2], reuse the code from Tony Lindgren's patch [3] to fix dcan probe failed on am437x platform dillon.minfei
2020-07-14 3:38 ` Stephen Rothwell
2020-07-14 3:43 ` dillon min
2020-07-14 3:54 ` Stephen Rothwell [this message]
2020-07-14 5:21 ` dillon min
2020-07-14 5:36 ` Stephen Rothwell
2020-07-14 6:33 ` dillon min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714135407.35992389@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).