Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings
@ 2020-07-16 12:57 Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 12:57 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel, Sebastian Reichel

The cleanup series for omapdrm's DSI code got too big. Reviewing
this is not fun and the same goes for keeping track of the change
requests. Let's do the cleanup in smaller steps instead. This is
the first batch, which updates the binding (txt -> yaml) and
modifies the DT slightly.

Changes since PATCHv1 [0]:

PATCHv1..PATCHv2:
 * Update binding as suggested by Sam
  * Remove 'port' from required list
  * Drop 'lanes' and 'port' from example ('lanes' is a port property
    used by OMAP's DSI controller)
  * Drop the label from example
  * Add '...' at end of file
 * Fix , in patch description from patch 2
 * Apply Reviewed-by tags

[0] https://lore.kernel.org/dri-devel/20200629223315.118256-1-sebastian.reichel@collabora.com/

-- Sebastian

Sebastian Reichel (4):
  dt-bindings: display: panel-dsi-cm: convert to YAML
  ARM: dts: omap: add channel to DSI panels
  ARM: dts: omap4-droid4: add panel compatible
  ARM: dts: omap4-droid4: add panel orientation

 .../bindings/display/panel/panel-dsi-cm.txt   | 29 -------
 .../bindings/display/panel/panel-dsi-cm.yaml  | 86 +++++++++++++++++++
 .../boot/dts/motorola-mapphone-common.dtsi    |  6 +-
 arch/arm/boot/dts/omap3-n950.dts              |  3 +-
 arch/arm/boot/dts/omap3.dtsi                  |  3 +
 arch/arm/boot/dts/omap4-sdp.dts               |  6 +-
 arch/arm/boot/dts/omap4.dtsi                  |  6 ++
 arch/arm/boot/dts/omap5.dtsi                  |  6 ++
 8 files changed, 111 insertions(+), 34 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml

-- 
2.27.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML
  2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
@ 2020-07-16 12:57 ` Sebastian Reichel
  2020-07-16 17:52   ` Sam Ravnborg
  2020-07-16 12:57 ` [PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels Sebastian Reichel
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 12:57 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel, Sebastian Reichel, Rob Herring

Convert panel-dsi-cm bindings to YAML and add
missing properties while at it.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 .../bindings/display/panel/panel-dsi-cm.txt   | 29 -------
 .../bindings/display/panel/panel-dsi-cm.yaml  | 86 +++++++++++++++++++
 2 files changed, 86 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
deleted file mode 100644
index dce48eb9db57..000000000000
--- a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Generic MIPI DSI Command Mode Panel
-===================================
-
-Required properties:
-- compatible: "panel-dsi-cm"
-
-Optional properties:
-- label: a symbolic name for the panel
-- reset-gpios: panel reset gpio
-- te-gpios: panel TE gpio
-
-Required nodes:
-- Video port for DSI input
-
-Example
--------
-
-lcd0: display {
-	compatible = "tpo,taal", "panel-dsi-cm";
-	label = "lcd0";
-
-	reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
-
-	port {
-		lcd0_in: endpoint {
-			remote-endpoint = <&dsi1_out_ep>;
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
new file mode 100644
index 000000000000..d766c949c622
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/panel-dsi-cm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DSI command mode panels
+
+maintainers:
+  - Tomi Valkeinen <tomi.valkeinen@ti.com>
+  - Sebastian Reichel <sre@kernel.org>
+
+description: |
+  This binding file is a collection of the DSI panels that
+  are usually driven in command mode. If no backlight is
+  referenced via the optional backlight property, the DSI
+  panel is assumed to have native backlight support.
+  The panel may use an OF graph binding for the association
+  to the display, or it may be a direct child node of the
+  display.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+
+  compatible:
+    items:
+      - enum:
+        - motorola,droid4-panel        # Panel from Motorola Droid4 phone
+        - nokia,himalaya               # Panel from Nokia N950 phone
+        - tpo,taal                     # Panel from OMAP4 SDP board
+      - const: panel-dsi-cm            # Generic DSI command mode panel compatible fallback
+
+  reg:
+    maxItems: 1
+    description: DSI virtual channel
+
+  vddi-supply:
+    description:
+      Display panels require power to be supplied. While several panels need
+      more than one power supply with panel-specific constraints governing the
+      order and timings of the power supplies, in many cases a single power
+      supply is sufficient, either because the panel has a single power rail, or
+      because all its power rails can be driven by the same supply. In that case
+      the vddi-supply property specifies the supply powering the panel as a
+      phandle to a regulator.
+
+  vpnl-supply:
+    description:
+      When the display panel needs a second power supply, this property can be
+      used in addition to vddi-supply. Both supplies will be enabled at the
+      same time before the panel is being accessed.
+
+  width-mm: true
+  height-mm: true
+  label: true
+  rotation: true
+  panel-timing: true
+  port: true
+  reset-gpios: true
+  te-gpios: true
+  backlight: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi-controller {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "tpo,taal", "panel-dsi-cm";
+            reg = <0>;
+            reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
+        };
+    };
+
+...
-- 
2.27.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels
  2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
@ 2020-07-16 12:57 ` Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible Sebastian Reichel
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 12:57 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel, Sebastian Reichel

The standard binding for DSI requires that the channel number
of the panel is encoded in DT. This adds the channel number in
all OMAP3-5 boards in preparation for using common infrastructure.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm/boot/dts/motorola-mapphone-common.dtsi | 3 ++-
 arch/arm/boot/dts/omap3-n950.dts                | 3 ++-
 arch/arm/boot/dts/omap3.dtsi                    | 3 +++
 arch/arm/boot/dts/omap4-sdp.dts                 | 6 ++++--
 arch/arm/boot/dts/omap4.dtsi                    | 6 ++++++
 arch/arm/boot/dts/omap5.dtsi                    | 6 ++++++
 6 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
index 06fbffa81636..4ffe461c3808 100644
--- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
+++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
@@ -207,8 +207,9 @@ dsi1_out_ep: endpoint {
 		};
 	};
 
-	lcd0: display {
+	lcd0: panel@0 {
 		compatible = "panel-dsi-cm";
+		reg = <0>;
 		label = "lcd0";
 		vddi-supply = <&lcd_regulator>;
 		reset-gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>;	/* gpio101 */
diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts
index 31d47a1fad84..80cf4e1177da 100644
--- a/arch/arm/boot/dts/omap3-n950.dts
+++ b/arch/arm/boot/dts/omap3-n950.dts
@@ -225,8 +225,9 @@ dsi_out_ep: endpoint {
 		};
 	};
 
-	lcd0: display {
+	lcd0: panel@0 {
 		compatible = "nokia,himalaya", "panel-dsi-cm";
+		reg = <0>;
 		label = "lcd0";
 
 		pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index 1296d0643943..0ebbb6c11f04 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -898,6 +898,9 @@ dsi: encoder@4804fc00 {
 				ti,hwmods = "dss_dsi1";
 				clocks = <&dss1_alwon_fck>, <&dss2_alwon_fck>;
 				clock-names = "fck", "sys_clk";
+
+				#address-cells = <1>;
+				#size-cells = <0>;
 			};
 
 			rfbi: encoder@48050800 {
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 91480ac1f328..8a8307517dab 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -662,8 +662,9 @@ dsi1_out_ep: endpoint {
 		};
 	};
 
-	lcd0: display {
+	lcd0: panel@0 {
 		compatible = "tpo,taal", "panel-dsi-cm";
+		reg = <0>;
 		label = "lcd0";
 
 		reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;	/* 102 */
@@ -687,8 +688,9 @@ dsi2_out_ep: endpoint {
 		};
 	};
 
-	lcd1: display {
+	lcd1: panel@0 {
 		compatible = "tpo,taal", "panel-dsi-cm";
+		reg = <0>;
 		label = "lcd1";
 
 		reset-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>;	/* 104 */
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 4400f5f8e099..c5b426616443 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -551,6 +551,9 @@ dsi1: encoder@0 {
 						clocks = <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 8>,
 							 <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 10>;
 						clock-names = "fck", "sys_clk";
+
+						#address-cells = <1>;
+						#size-cells = <0>;
 					};
 				};
 
@@ -583,6 +586,9 @@ dsi2: encoder@0 {
 						clocks = <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 8>,
 						         <&l3_dss_clkctrl OMAP4_DSS_CORE_CLKCTRL 10>;
 						clock-names = "fck", "sys_clk";
+
+						#address-cells = <1>;
+						#size-cells = <0>;
 					};
 				};
 
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index fb889c5b00c9..0855c0a4050f 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -491,6 +491,9 @@ dsi1: encoder@0 {
 						status = "disabled";
 						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
 						clock-names = "fck";
+
+						#address-cells = <1>;
+						#size-cells = <0>;
 					};
 				};
 
@@ -522,6 +525,9 @@ dsi2: encoder@0 {
 						status = "disabled";
 						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
 						clock-names = "fck";
+
+						#address-cells = <1>;
+						#size-cells = <0>;
 					};
 				};
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible
  2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels Sebastian Reichel
@ 2020-07-16 12:57 ` Sebastian Reichel
  2020-07-16 12:57 ` [PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation Sebastian Reichel
  2020-08-04 10:52 ` [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Tomi Valkeinen
  4 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 12:57 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel, Sebastian Reichel

Add Droid 4 specific compatible value in addition to the
generic one, so that we have the ability to add panel
specific quirks in the future.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm/boot/dts/motorola-mapphone-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
index 4ffe461c3808..0e22fdfa42aa 100644
--- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
+++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
@@ -208,7 +208,7 @@ dsi1_out_ep: endpoint {
 	};
 
 	lcd0: panel@0 {
-		compatible = "panel-dsi-cm";
+		compatible = "motorola,droid4-panel", "panel-dsi-cm";
 		reg = <0>;
 		label = "lcd0";
 		vddi-supply = <&lcd_regulator>;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation
  2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
                   ` (2 preceding siblings ...)
  2020-07-16 12:57 ` [PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible Sebastian Reichel
@ 2020-07-16 12:57 ` Sebastian Reichel
  2020-08-04 10:52 ` [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Tomi Valkeinen
  4 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 12:57 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel, Sebastian Reichel

Add information about panel orientation, so that the
system boots into a properly rotated shell.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 arch/arm/boot/dts/motorola-mapphone-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
index 0e22fdfa42aa..e672e714fcbe 100644
--- a/arch/arm/boot/dts/motorola-mapphone-common.dtsi
+++ b/arch/arm/boot/dts/motorola-mapphone-common.dtsi
@@ -218,6 +218,7 @@ lcd0: panel@0 {
 
 		width-mm = <50>;
 		height-mm = <89>;
+		rotation = <90>;
 
 		panel-timing {
 			clock-frequency = <0>;		/* Calculated by dsi */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML
  2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
@ 2020-07-16 17:52   ` Sam Ravnborg
  2020-07-16 18:07     ` Sebastian Reichel
  0 siblings, 1 reply; 9+ messages in thread
From: Sam Ravnborg @ 2020-07-16 17:52 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Sebastian Reichel, Tomi Valkeinen, Tony Lindgren, Pavel Machek,
	Merlijn Wajer, Laurent Pinchart, H. Nikolaus Schaller,
	Rob Herring, dri-devel, devicetree, linux-omap, kernel,
	Rob Herring

On Thu, Jul 16, 2020 at 02:57:30PM +0200, Sebastian Reichel wrote:
> Convert panel-dsi-cm bindings to YAML and add
> missing properties while at it.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Hi Sebastian.

Look good now. Applied this patch to drm-misc-next.

$ ls Documentation/devicetree/bindings/display/panel/*.txt
Documentation/devicetree/bindings/display/panel/display-timing.txt

Nice :-)

The DTS file changes needs to go in via another route.

	Sam

> ---
>  .../bindings/display/panel/panel-dsi-cm.txt   | 29 -------
>  .../bindings/display/panel/panel-dsi-cm.yaml  | 86 +++++++++++++++++++
>  2 files changed, 86 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> deleted file mode 100644
> index dce48eb9db57..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -Generic MIPI DSI Command Mode Panel
> -===================================
> -
> -Required properties:
> -- compatible: "panel-dsi-cm"
> -
> -Optional properties:
> -- label: a symbolic name for the panel
> -- reset-gpios: panel reset gpio
> -- te-gpios: panel TE gpio
> -
> -Required nodes:
> -- Video port for DSI input
> -
> -Example
> --------
> -
> -lcd0: display {
> -	compatible = "tpo,taal", "panel-dsi-cm";
> -	label = "lcd0";
> -
> -	reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> -
> -	port {
> -		lcd0_in: endpoint {
> -			remote-endpoint = <&dsi1_out_ep>;
> -		};
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> new file mode 100644
> index 000000000000..d766c949c622
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-dsi-cm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DSI command mode panels
> +
> +maintainers:
> +  - Tomi Valkeinen <tomi.valkeinen@ti.com>
> +  - Sebastian Reichel <sre@kernel.org>
> +
> +description: |
> +  This binding file is a collection of the DSI panels that
> +  are usually driven in command mode. If no backlight is
> +  referenced via the optional backlight property, the DSI
> +  panel is assumed to have native backlight support.
> +  The panel may use an OF graph binding for the association
> +  to the display, or it may be a direct child node of the
> +  display.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    items:
> +      - enum:
> +        - motorola,droid4-panel        # Panel from Motorola Droid4 phone
> +        - nokia,himalaya               # Panel from Nokia N950 phone
> +        - tpo,taal                     # Panel from OMAP4 SDP board
> +      - const: panel-dsi-cm            # Generic DSI command mode panel compatible fallback
> +
> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  vddi-supply:
> +    description:
> +      Display panels require power to be supplied. While several panels need
> +      more than one power supply with panel-specific constraints governing the
> +      order and timings of the power supplies, in many cases a single power
> +      supply is sufficient, either because the panel has a single power rail, or
> +      because all its power rails can be driven by the same supply. In that case
> +      the vddi-supply property specifies the supply powering the panel as a
> +      phandle to a regulator.
> +
> +  vpnl-supply:
> +    description:
> +      When the display panel needs a second power supply, this property can be
> +      used in addition to vddi-supply. Both supplies will be enabled at the
> +      same time before the panel is being accessed.
> +
> +  width-mm: true
> +  height-mm: true
> +  label: true
> +  rotation: true
> +  panel-timing: true
> +  port: true
> +  reset-gpios: true
> +  te-gpios: true
> +  backlight: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi-controller {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "tpo,taal", "panel-dsi-cm";
> +            reg = <0>;
> +            reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> +
> +...
> -- 
> 2.27.0

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML
  2020-07-16 17:52   ` Sam Ravnborg
@ 2020-07-16 18:07     ` Sebastian Reichel
  2020-08-19  6:46       ` Tony Lindgren
  0 siblings, 1 reply; 9+ messages in thread
From: Sebastian Reichel @ 2020-07-16 18:07 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: Tomi Valkeinen, Tony Lindgren, Pavel Machek, Merlijn Wajer,
	Laurent Pinchart, H. Nikolaus Schaller, Rob Herring, dri-devel,
	devicetree, linux-omap, kernel, Rob Herring


[-- Attachment #1: Type: text/plain, Size: 5571 bytes --]

Hi,

On Thu, Jul 16, 2020 at 07:52:58PM +0200, Sam Ravnborg wrote:
> On Thu, Jul 16, 2020 at 02:57:30PM +0200, Sebastian Reichel wrote:
> > Convert panel-dsi-cm bindings to YAML and add
> > missing properties while at it.
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> Hi Sebastian.
> 
> Look good now. Applied this patch to drm-misc-next.

Thanks!

> $ ls Documentation/devicetree/bindings/display/panel/*.txt
> Documentation/devicetree/bindings/display/panel/display-timing.txt
> 
> Nice :-)

Indeed.

> The DTS file changes needs to go in via another route.

No worries. I guess Tony will queue them up when he finds some time.

-- Sebastian

> 
> 	Sam
> 
> > ---
> >  .../bindings/display/panel/panel-dsi-cm.txt   | 29 -------
> >  .../bindings/display/panel/panel-dsi-cm.yaml  | 86 +++++++++++++++++++
> >  2 files changed, 86 insertions(+), 29 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> > deleted file mode 100644
> > index dce48eb9db57..000000000000
> > --- a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
> > +++ /dev/null
> > @@ -1,29 +0,0 @@
> > -Generic MIPI DSI Command Mode Panel
> > -===================================
> > -
> > -Required properties:
> > -- compatible: "panel-dsi-cm"
> > -
> > -Optional properties:
> > -- label: a symbolic name for the panel
> > -- reset-gpios: panel reset gpio
> > -- te-gpios: panel TE gpio
> > -
> > -Required nodes:
> > -- Video port for DSI input
> > -
> > -Example
> > --------
> > -
> > -lcd0: display {
> > -	compatible = "tpo,taal", "panel-dsi-cm";
> > -	label = "lcd0";
> > -
> > -	reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> > -
> > -	port {
> > -		lcd0_in: endpoint {
> > -			remote-endpoint = <&dsi1_out_ep>;
> > -		};
> > -	};
> > -};
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> > new file mode 100644
> > index 000000000000..d766c949c622
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-dsi-cm.yaml
> > @@ -0,0 +1,86 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/panel-dsi-cm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: DSI command mode panels
> > +
> > +maintainers:
> > +  - Tomi Valkeinen <tomi.valkeinen@ti.com>
> > +  - Sebastian Reichel <sre@kernel.org>
> > +
> > +description: |
> > +  This binding file is a collection of the DSI panels that
> > +  are usually driven in command mode. If no backlight is
> > +  referenced via the optional backlight property, the DSI
> > +  panel is assumed to have native backlight support.
> > +  The panel may use an OF graph binding for the association
> > +  to the display, or it may be a direct child node of the
> > +  display.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +
> > +  compatible:
> > +    items:
> > +      - enum:
> > +        - motorola,droid4-panel        # Panel from Motorola Droid4 phone
> > +        - nokia,himalaya               # Panel from Nokia N950 phone
> > +        - tpo,taal                     # Panel from OMAP4 SDP board
> > +      - const: panel-dsi-cm            # Generic DSI command mode panel compatible fallback
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: DSI virtual channel
> > +
> > +  vddi-supply:
> > +    description:
> > +      Display panels require power to be supplied. While several panels need
> > +      more than one power supply with panel-specific constraints governing the
> > +      order and timings of the power supplies, in many cases a single power
> > +      supply is sufficient, either because the panel has a single power rail, or
> > +      because all its power rails can be driven by the same supply. In that case
> > +      the vddi-supply property specifies the supply powering the panel as a
> > +      phandle to a regulator.
> > +
> > +  vpnl-supply:
> > +    description:
> > +      When the display panel needs a second power supply, this property can be
> > +      used in addition to vddi-supply. Both supplies will be enabled at the
> > +      same time before the panel is being accessed.
> > +
> > +  width-mm: true
> > +  height-mm: true
> > +  label: true
> > +  rotation: true
> > +  panel-timing: true
> > +  port: true
> > +  reset-gpios: true
> > +  te-gpios: true
> > +  backlight: true
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi-controller {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        panel@0 {
> > +            compatible = "tpo,taal", "panel-dsi-cm";
> > +            reg = <0>;
> > +            reset-gpios = <&gpio4 6 GPIO_ACTIVE_HIGH>;
> > +        };
> > +    };
> > +
> > +...
> > -- 
> > 2.27.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings
  2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
                   ` (3 preceding siblings ...)
  2020-07-16 12:57 ` [PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation Sebastian Reichel
@ 2020-08-04 10:52 ` Tomi Valkeinen
  4 siblings, 0 replies; 9+ messages in thread
From: Tomi Valkeinen @ 2020-08-04 10:52 UTC (permalink / raw)
  To: Sebastian Reichel, Sebastian Reichel, Sam Ravnborg, Tony Lindgren
  Cc: Pavel Machek, Merlijn Wajer, Laurent Pinchart,
	H. Nikolaus Schaller, Rob Herring, dri-devel, devicetree,
	linux-omap, kernel

Hi Sebastian,

On 16/07/2020 15:57, Sebastian Reichel wrote:
> The cleanup series for omapdrm's DSI code got too big. Reviewing
> this is not fun and the same goes for keeping track of the change
> requests. Let's do the cleanup in smaller steps instead. This is
> the first batch, which updates the binding (txt -> yaml) and
> modifies the DT slightly.
> 
> Changes since PATCHv1 [0]:
> 
> PATCHv1..PATCHv2:
>  * Update binding as suggested by Sam
>   * Remove 'port' from required list
>   * Drop 'lanes' and 'port' from example ('lanes' is a port property
>     used by OMAP's DSI controller)
>   * Drop the label from example
>   * Add '...' at end of file
>  * Fix , in patch description from patch 2
>  * Apply Reviewed-by tags
> 
> [0] https://lore.kernel.org/dri-devel/20200629223315.118256-1-sebastian.reichel@collabora.com/
> 
> -- Sebastian
> 
> Sebastian Reichel (4):
>   dt-bindings: display: panel-dsi-cm: convert to YAML
>   ARM: dts: omap: add channel to DSI panels
>   ARM: dts: omap4-droid4: add panel compatible
>   ARM: dts: omap4-droid4: add panel orientation

For the series:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML
  2020-07-16 18:07     ` Sebastian Reichel
@ 2020-08-19  6:46       ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2020-08-19  6:46 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Sam Ravnborg, Tomi Valkeinen, Pavel Machek, Merlijn Wajer,
	Laurent Pinchart, H. Nikolaus Schaller, Rob Herring, dri-devel,
	devicetree, linux-omap, kernel, Rob Herring

* Sebastian Reichel <sre@kernel.org> [200716 18:07]:
> On Thu, Jul 16, 2020 at 07:52:58PM +0200, Sam Ravnborg wrote:
> > The DTS file changes needs to go in via another route.
> 
> No worries. I guess Tony will queue them up when he finds some time.

Thanks applying the dts changes into omap-for-v5.10/dt.

Regards,

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 12:57 [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 1/4] dt-bindings: display: panel-dsi-cm: convert to YAML Sebastian Reichel
2020-07-16 17:52   ` Sam Ravnborg
2020-07-16 18:07     ` Sebastian Reichel
2020-08-19  6:46       ` Tony Lindgren
2020-07-16 12:57 ` [PATCHv2 2/4] ARM: dts: omap: add channel to DSI panels Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 3/4] ARM: dts: omap4-droid4: add panel compatible Sebastian Reichel
2020-07-16 12:57 ` [PATCHv2 4/4] ARM: dts: omap4-droid4: add panel orientation Sebastian Reichel
2020-08-04 10:52 ` [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings Tomi Valkeinen

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git