From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA54BC433E2 for ; Fri, 17 Jul 2020 20:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0CA920704 for ; Fri, 17 Jul 2020 20:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rGwYawEl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728304AbgGQUsn (ORCPT ); Fri, 17 Jul 2020 16:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgGQUsm (ORCPT ); Fri, 17 Jul 2020 16:48:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3C6C0619D2; Fri, 17 Jul 2020 13:48:42 -0700 (PDT) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CE21371D; Fri, 17 Jul 2020 22:48:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1595018918; bh=XYHG8/2rl6p2XqnEsWEfoxx9RfN0fqz7yBhyxsmUQwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rGwYawElmR3YEQwm/N4Pfa9x5b9wkPNQvkInL7r8g6E+ROHcMuARJFRgyPJ22BLLU uZG6e/yInEmdTtd00cHew6ALJsXywvknnru5QOQxs9wcKZMMELuxY2kFn8zcKMcHeR i2YcNhCZnXYMWBu9QljkTvJRjoHhl/cg+NOu0ATs= Date: Fri, 17 Jul 2020 23:48:29 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, slongerbeam@gmail.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Tony Lindgren , linux-omap@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Maxime Coquelin , Alexandre Torgue , "moderated list:ARM/STM32 ARCHITECTURE" , Maxime Ripard , Chen-Yu Tsai , Andy Gross , Bjorn Andersson , Tero Kristo , Nishanth Menon Subject: Re: [PATCH 07/13] dt-bindings: media: ov5640: Remove clock-lanes Message-ID: <20200717204829.GI5961@pendragon.ideasonboard.com> References: <20200717132859.237120-1-jacopo+renesas@jmondi.org> <20200717132859.237120-8-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200717132859.237120-8-jacopo+renesas@jmondi.org> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Jacopo, Thank you for the patch. On Fri, Jul 17, 2020 at 03:28:53PM +0200, Jacopo Mondi wrote: > The ov5640 does not support routing the clock signal to a different > lane, and the property has value fixed to 0. > > Remove the property from the bindings and update its users > accordingly. > > Signed-off-by: Jacopo Mondi When we'll convert video-interface.txt to YAML, let's state clearly that properties should not be specified when the hardware is configurable. Reviewed-by: Laurent Pinchart > --- > Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 6 ------ > arch/arm/boot/dts/dra72-evm-common.dtsi | 1 - > arch/arm/boot/dts/dra76-evm.dts | 1 - > arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 1 - > arch/arm/boot/dts/imx6qdl-icore.dtsi | 1 - > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 1 - > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 - > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 - > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 - > 9 files changed, 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > index 8fd54575a1db..5e1662e848bd 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > @@ -76,9 +76,6 @@ properties: > bus-type: > enum: [4, 5] > > - clock-lanes: > - const: 0 > - > data-lanes: > description: | > Should be set to <1> or <1 2> (one or two CSI-2 lanes supported). > @@ -125,7 +122,6 @@ properties: > required: > - remote-endpoint > - bus-type > - - clock-lanes > - data-lanes > > - if: > @@ -134,7 +130,6 @@ properties: > const: 5 > then: > properties: > - clock-lanes: false > data-lanes: false > required: > - remote-endpoint > @@ -182,7 +177,6 @@ examples: > ov5640_to_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_from_ov5640>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi > index aba7eb55525d..b5b31dc927d4 100644 > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi > @@ -288,7 +288,6 @@ port { > csi2_cam0: endpoint { > remote-endpoint = <&csi2_phy0>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts > index ddf16e65ec7f..6fcb96abc41d 100644 > --- a/arch/arm/boot/dts/dra76-evm.dts > +++ b/arch/arm/boot/dts/dra76-evm.dts > @@ -421,7 +421,6 @@ port { > csi2_cam0: endpoint { > remote-endpoint = <&csi2_phy0>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi > index dd5765778e87..a12d80a2403e 100644 > --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi > +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi > @@ -275,7 +275,6 @@ port { > ov5640_to_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_in>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi > index 2b1f275b8cc4..05bd332f527b 100644 > --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi > @@ -214,7 +214,6 @@ port { > ov5640_to_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_in>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > index 5752abb48e68..5eb7fbf33069 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > @@ -383,7 +383,6 @@ port { > ov5640_to_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_in>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 990f4cc345da..02f78b46a8fd 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -314,7 +314,6 @@ port { > ov5640_to_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_in>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 5c79ad5e7b5d..8c24fd468a22 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -628,7 +628,6 @@ camera_rear@3b { > port { > ov5640_ep: endpoint { > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > remote-endpoint = <&csiphy0_ep>; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > index 33f4eceffbe5..dd6a636ba3af 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > @@ -255,7 +255,6 @@ port { > csi2_cam0: endpoint { > remote-endpoint = <&csi2_phy0>; > bus-type = <4>; > - clock-lanes = <0>; > data-lanes = <1 2>; > }; > }; -- Regards, Laurent Pinchart