From: Lee Jones <lee.jones@linaro.org>
To: Suman Anna <s-anna@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
David Lechner <david@lechnology.com>,
Tony Lindgren <tony@atomide.com>, Roger Quadros <rogerq@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [RESEND PATCH v2] mfd: syscon: Use a unique name with regmap_config
Date: Tue, 28 Jul 2020 09:01:39 +0100 [thread overview]
Message-ID: <20200728080139.GI1850026@dell> (raw)
In-Reply-To: <20200727211008.24225-1-s-anna@ti.com>
On Mon, 27 Jul 2020, Suman Anna wrote:
> The DT node full name is currently being used in regmap_config
> which in turn is used to create the regmap debugfs directories.
> This name however is not guaranteed to be unique and the regmap
> debugfs registration can fail in the cases where the syscon nodes
> have the same unit-address but are present in different DT node
> hierarchies. Replace this logic using the syscon reg resource
> address instead (inspired from logic used while creating platform
> devices) to ensure a unique name is given for each syscon.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Arnd,
> Lee is looking for your review on this patch. Can you please
> review and provide your comments.
>
> This is a resend of the patch that was posted previously, rebased
> now onto latest kernel.
>
> v2: https://patchwork.kernel.org/patch/11353355/
> - Fix build warning reported by kbuild test bot
> v1: https://patchwork.kernel.org/patch/11346363/
>
> drivers/mfd/syscon.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-28 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 21:10 [RESEND PATCH v2] mfd: syscon: Use a unique name with regmap_config Suman Anna
2020-07-28 7:44 ` Arnd Bergmann
2020-07-28 15:34 ` Suman Anna
2020-07-28 8:01 ` Lee Jones [this message]
2020-08-27 14:46 ` Marc Zyngier
2020-08-27 18:28 ` Suman Anna
2020-08-27 20:06 ` Marc Zyngier
2020-08-27 20:32 ` Suman Anna
2020-08-28 10:40 ` Mark Brown
2020-09-03 8:26 ` Marc Zyngier
2020-09-03 13:25 ` Suman Anna
2020-09-03 16:04 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728080139.GI1850026@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=david@lechnology.com \
--cc=grzegorz.jaszczyk@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).