From: Tony Lindgren <tony@atomide.com>
To: David Shah <dave@ds0.me>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>, Tero Kristo <t-kristo@ti.com>
Subject: Re: Understanding OMAP5 DPLL_ABE and CM_CLKSEL_WKUPAON
Date: Tue, 28 Jul 2020 01:42:57 -0700 [thread overview]
Message-ID: <20200728084257.GF2811@atomide.com> (raw)
In-Reply-To: <ac19052a552660c86838709f071cffe0f3e65932.camel@ds0.me>
* David Shah <dave@ds0.me> [200727 08:58]:
> On Mon, 2020-07-27 at 01:28 -0700, Tony Lindgren wrote:
> > If it only needs to be configured to 1 for reboot, sounds like it
> > should
> > be set in omap44xx_restart(). And we should also set it to 1 for
> > omap4
> > too.
>
> omap44xx_restart doesn't seem like the right place to me, as the bug
> also affects hard resets (i.e. NRESWARM assertion) and it would be nice
> to have these working, too.
Ah right, the device reboots fine, but the rebooted kernel
won't initialize properly.
> Would a better solution be to set it early during startup (the first
> part of clock init), and then clear it when the DPLLs are set up and
> locked?
Yes sounds like then the place to configure this is in the
drivers/clk/ti/clk-54xx.c omap5xxx_dt_clk_init(). Maybe add
a comment to the patch description that a similar patch may
be also needed for omap4 on some devices.
Regards,
Tony
next prev parent reply other threads:[~2020-07-28 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 20:55 Understanding OMAP5 DPLL_ABE and CM_CLKSEL_WKUPAON David Shah
2020-07-27 8:28 ` Tony Lindgren
2020-07-27 8:58 ` David Shah
2020-07-28 8:42 ` Tony Lindgren [this message]
2020-11-23 20:10 ` H. Nikolaus Schaller
2020-12-01 7:37 ` Tony Lindgren
2020-12-02 15:10 ` H. Nikolaus Schaller
2020-12-05 14:48 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728084257.GF2811@atomide.com \
--to=tony@atomide.com \
--cc=dave@ds0.me \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).