From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jingoohan1@gmail.com>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Murali Karicheri <m-karicheri2@ti.com>,
Yue Wang <yue.wang@Amlogic.com>,
Kevin Hilman <khilman@baylibre.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Xiaowei Song <songxiaowei@hisilicon.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Toan Le <toan@os.amperecomputing.com>,
Ley Foon Tan <ley.foon.tan@intel.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-amlogic@lists.infradead.org, linux-arm-kernel@axis.com,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
rfi@lists.rocketboards.org
Subject: [PATCH 10/10] PCI: xilinx-nwl: Remove dev_err() when handing an error from platform_get_irq()
Date: Mon, 3 Aug 2020 07:10:40 +0000 [thread overview]
Message-ID: <20200803071040.1663662-1-kw@linux.com> (raw)
In-Reply-To: <20200802142601.1635926-1-kw@linux.com>
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
This change is as per suggestion from Coccinelle:
drivers/pci/controller/pcie-xilinx-nwl.c:732:2-9: line 732 is
redundant because platform_get_irq() already prints an error
drivers/pci/controller/pcie-xilinx-nwl.c:589:2-9: line 589 is
redundant because platform_get_irq() already prints an error
drivers/pci/controller/pcie-xilinx-nwl.c:600:2-9: line 600 is
redundant because platform_get_irq() already prints an error
drivers/pci/controller/pcie-xilinx-nwl.c:801:2-9: line 801 is
redundant because platform_get_irq() already prints an error
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
index 9bd1427f2fd6..55489b728484 100644
--- a/drivers/pci/controller/pcie-xilinx-nwl.c
+++ b/drivers/pci/controller/pcie-xilinx-nwl.c
@@ -586,7 +586,6 @@ static int nwl_pcie_enable_msi(struct nwl_pcie *pcie)
/* Get msi_1 IRQ number */
msi->irq_msi1 = platform_get_irq_byname(pdev, "msi1");
if (msi->irq_msi1 < 0) {
- dev_err(dev, "failed to get IRQ#%d\n", msi->irq_msi1);
ret = -EINVAL;
goto err;
}
@@ -597,7 +596,6 @@ static int nwl_pcie_enable_msi(struct nwl_pcie *pcie)
/* Get msi_0 IRQ number */
msi->irq_msi0 = platform_get_irq_byname(pdev, "msi0");
if (msi->irq_msi0 < 0) {
- dev_err(dev, "failed to get IRQ#%d\n", msi->irq_msi0);
ret = -EINVAL;
goto err;
}
@@ -728,11 +726,8 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
/* Get misc IRQ number */
pcie->irq_misc = platform_get_irq_byname(pdev, "misc");
- if (pcie->irq_misc < 0) {
- dev_err(dev, "failed to get misc IRQ %d\n",
- pcie->irq_misc);
+ if (pcie->irq_misc < 0)
return -EINVAL;
- }
err = devm_request_irq(dev, pcie->irq_misc,
nwl_pcie_misc_handler, IRQF_SHARED,
@@ -797,10 +792,8 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,
/* Get intx IRQ number */
pcie->irq_intx = platform_get_irq_byname(pdev, "intx");
- if (pcie->irq_intx < 0) {
- dev_err(dev, "failed to get intx IRQ %d\n", pcie->irq_intx);
+ if (pcie->irq_intx < 0)
return pcie->irq_intx;
- }
irq_set_chained_handler_and_data(pcie->irq_intx,
nwl_pcie_leg_handler, pcie);
--
2.27.0
prev parent reply other threads:[~2020-08-03 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
2020-08-03 7:16 ` Jesper Nilsson
2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
2020-08-03 6:19 ` Tan, Ley Foon
2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
2020-08-03 2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
2020-08-03 11:10 ` Krzysztof Wilczyński
2020-08-03 14:55 ` Bjorn Helgaas
2020-08-03 7:10 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803071040.1663662-1-kw@linux.com \
--to=kw@linux.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=hongxing.zhu@nxp.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=ley.foon.tan@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=rfi@lists.rocketboards.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=songxiaowei@hisilicon.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toan@os.amperecomputing.com \
--cc=wangbinghui@hisilicon.com \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).