From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 141E9C433E4 for ; Mon, 3 Aug 2020 07:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E718C206E9 for ; Mon, 3 Aug 2020 07:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=axis.com header.i=@axis.com header.b="h6z/we2Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725853AbgHCHQv (ORCPT ); Mon, 3 Aug 2020 03:16:51 -0400 Received: from smtp1.axis.com ([195.60.68.17]:28798 "EHLO smtp1.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbgHCHQt (ORCPT ); Mon, 3 Aug 2020 03:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; l=2377; q=dns/txt; s=axis-central1; t=1596439009; x=1627975009; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=4eB+iWowqFuffEwqVhdlrnC6nMcvTTjY/U9qdPMCwa8=; b=h6z/we2ZpIVLYLtPfrlKHe8MgcoQbZkD8iF5759ykTOOzVbavYjAMZCb 6UeD6cVC7cbZZuYc9lMk3UhEonQvPgcyFCyfNliKgBF8TwaZ7d29UkhJX tPeXlFbJMsUvySweDFiMkj7az8qflbGxKxrU/AwMflKohmdrF2ol1WVF+ IN9t2ln4iOXcvcIvN9bkNgbZyD7o/WyUuT9o/azXb8c12oiYH1eqEZRhJ idUlzDwULCNsgpO9b7ptdU9mE9zICuE1ygPr8Ywz2clfpcdbjNPjKnKuZ N99Ctzr0gR7ZskdJ9cu6pmOe44Or25pz1k6OjwDf5v+XItSLntjCDCB2k w==; IronPort-SDR: UaNM9T7tIvhQ2yXPgIs4QcPcTkk/tfeHxx4jq1y9AeEkV586tSbCWZGo0H5qrtreyMPTjbFCDP Y+y01J24Qk+f1muOB9+jFlUTw/GiCYD6ZO6oqr3An7Wu5oBT/li8icS7SKZKOzsDp1RSGVRN/P JHFVLeyn+a3oH1VPQGhXBUvrV08tJXL9Wa8+LfCSxrQA1U3yNOiSmezqWk0BLNTfFwG1BhdbMz FL4tYFSx1r3MfsJ5/LVbLSSS2e7SbjJdVyXnLyuR9Epo7K9M2bAPofd6CFKML9itofxnvwJFEr Bac= X-IronPort-AV: E=Sophos;i="5.75,429,1589234400"; d="scan'208";a="11438926" Date: Mon, 3 Aug 2020 09:16:42 +0200 From: Jesper Nilsson To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= CC: Bjorn Helgaas , Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Murali Karicheri , Yue Wang , Kevin Hilman , Thomas Petazzoni , Jesper Nilsson , Xiaowei Song , Binghui Wang , Pratyush Anand , Hou Zhiqiang , Linus Walleij , Toan Le , Ley Foon Tan , Shawn Lin , Heiko Stuebner , "linux-amlogic@lists.infradead.org" , linux-arm-kernel , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "rfi@lists.rocketboards.org" Subject: Re: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq() Message-ID: <20200803071642.7qgua4qnwrre4s3v@axis.com> References: <20200802142601.1635926-1-kw@linux.com> <20200802142601.1635926-2-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200802142601.1635926-2-kw@linux.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Sun, Aug 02, 2020 at 04:25:53PM +0200, Krzysztof Wilczyński wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > This change is as per suggestion from Coccinelle: > > drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant > because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant > because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is > redundant because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant > because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant > because platform_get_irq() already prints an error > > drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant > because platform_get_irq() already prints an error > > Suggested-by: Bjorn Helgaas > Signed-off-by: Krzysztof Wilczyński Looks good, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com