linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix broken audio
@ 2020-08-14 12:53 Adam Ford
  2020-08-17 11:28 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2020-08-14 12:53 UTC (permalink / raw)
  To: linux-omap; +Cc: Adam Ford, Rob Herring, Mark Rutland, devicetree, linux-kernel

Older versions of U-Boot would pinmux the whole board, but as
the bootloader got updated, it started to only pinmux the pins
it needed, and expected Linux to configure what it needed.

Unfortunately this caused an issue with the audio, because the
mcbsp2 pins were configured in the device tree but never
referenced by the driver. When U-Boot stopped muxing the audio
pins, the audio died.

This patch adds the references to the associate the pin controller
with the mcbsp2 driver which makes audio operate again.

Fixes: 5cb8b0fa55a9 ("ARM: dts: Move most of logicpd-som-lv-37xx-devkit.dts to logicpd-som-lv-baseboard.dtsi")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
index 79e9e24328b9..395e05f10d36 100644
--- a/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
+++ b/arch/arm/boot/dts/logicpd-som-lv-baseboard.dtsi
@@ -51,6 +51,8 @@
 
 &mcbsp2 {
 	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mcbsp2_pins>;
 };
 
 &charger {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix broken audio
  2020-08-14 12:53 [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix broken audio Adam Ford
@ 2020-08-17 11:28 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-08-17 11:28 UTC (permalink / raw)
  To: Adam Ford; +Cc: linux-omap, Rob Herring, Mark Rutland, devicetree, linux-kernel

* Adam Ford <aford173@gmail.com> [200814 15:53]:
> Older versions of U-Boot would pinmux the whole board, but as
> the bootloader got updated, it started to only pinmux the pins
> it needed, and expected Linux to configure what it needed.
> 
> Unfortunately this caused an issue with the audio, because the
> mcbsp2 pins were configured in the device tree but never
> referenced by the driver. When U-Boot stopped muxing the audio
> pins, the audio died.
> 
> This patch adds the references to the associate the pin controller
> with the mcbsp2 driver which makes audio operate again.

Thanks applying into fixes.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-17 11:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 12:53 [PATCH] ARM: dts: logicpd-som-lv-baseboard: Fix broken audio Adam Ford
2020-08-17 11:28 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).