linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: <rogerq@ti.com>, <tony@atomide.com>, <krzk@kernel.org>,
	<ladis@linux-mips.org>, <bbrezillon@kernel.org>,
	<peter.ujfalusi@ti.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH v2] memory: omap-gpmc: Fix build error without CONFIG_OF
Date: Wed, 26 Aug 2020 20:59:19 +0800	[thread overview]
Message-ID: <20200826125919.22172-1-yuehaibing@huawei.com> (raw)
In-Reply-To: <20200818125338.58148-1-yuehaibing@huawei.com>

If CONFIG_OF is n, gcc fails:

drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'

Add gpmc_read_settings_dt() helper function to fix this.

Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: add gpmc_read_settings_dt() stub
---
 drivers/memory/omap-gpmc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index cd9e80748591..02c0c694ecaf 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -2310,6 +2310,9 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
 	}
 }
 #else
+void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
+{
+}
 static int gpmc_probe_dt(struct platform_device *pdev)
 {
 	return 0;
-- 
2.17.1



  parent reply	other threads:[~2020-08-26 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 12:53 [PATCH] memory: omap-gpmc: Fix build error without CONFIG_OF YueHaibing
2020-08-18 13:00 ` Krzysztof Kozlowski
2020-08-26 12:59 ` YueHaibing [this message]
2020-08-27  9:27   ` [PATCH v2] " Roger Quadros
2020-08-27 12:53   ` [PATCH v3] " YueHaibing
2020-08-27 13:21     ` Krzysztof Kozlowski
2020-08-27 16:37       ` Roger Quadros
2020-08-27 19:31         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826125919.22172-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=bbrezillon@kernel.org \
    --cc=krzk@kernel.org \
    --cc=ladis@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).