linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [balbi-usb:testing/next 24/24] drivers/usb/dwc3/gadget.c:1087:4: error: 'stream_id' undeclared; did you mean
@ 2020-08-31  9:51 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-08-31  9:51 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: kbuild-all, linux-usb, linux-omap, Felipe Balbi

[-- Attachment #1: Type: text/plain, Size: 6545 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
head:   e14441056da58213751d014bbe3bcb6d7421b2f1
commit: e14441056da58213751d014bbe3bcb6d7421b2f1 [24/24] usb: dwc3: gadget: fix checkpatch warnings
config: m68k-randconfig-r024-20200831 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout e14441056da58213751d014bbe3bcb6d7421b2f1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11,
                    from drivers/usb/dwc3/gadget.c:11:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   drivers/usb/dwc3/gadget.c: In function 'dwc3_prepare_one_trb':
>> drivers/usb/dwc3/gadget.c:1087:4: error: 'stream_id' undeclared (first use in this function); did you mean 'stream_open'?
    1087 |    stream_id, short_not_ok, no_interrupt, is_last);
         |    ^~~~~~~~~
         |    stream_open
   drivers/usb/dwc3/gadget.c:1087:4: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/usb/dwc3/gadget.c:1087:15: error: 'short_not_ok' undeclared (first use in this function)
    1087 |    stream_id, short_not_ok, no_interrupt, is_last);
         |               ^~~~~~~~~~~~
>> drivers/usb/dwc3/gadget.c:1087:29: error: 'no_interrupt' undeclared (first use in this function); did you mean 'note_interrupt'?
    1087 |    stream_id, short_not_ok, no_interrupt, is_last);
         |                             ^~~~~~~~~~~~
         |                             note_interrupt
>> drivers/usb/dwc3/gadget.c:1087:43: error: 'is_last' undeclared (first use in this function); did you mean 'sg_last'?
    1087 |    stream_id, short_not_ok, no_interrupt, is_last);
         |                                           ^~~~~~~
         |                                           sg_last

# https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?id=e14441056da58213751d014bbe3bcb6d7421b2f1
git remote add balbi-usb https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
git fetch --no-tags balbi-usb testing/next
git checkout e14441056da58213751d014bbe3bcb6d7421b2f1
vim +1087 drivers/usb/dwc3/gadget.c

c71fc37c191747 Felipe Balbi         2011-11-22  1055  
e49d3cf4926af0 Felipe Balbi         2017-01-05  1056  /**
e49d3cf4926af0 Felipe Balbi         2017-01-05  1057   * dwc3_prepare_one_trb - setup one TRB from one request
e49d3cf4926af0 Felipe Balbi         2017-01-05  1058   * @dep: endpoint for which this request is prepared
e49d3cf4926af0 Felipe Balbi         2017-01-05  1059   * @req: dwc3_request pointer
5d187c0454ef4c Thinh Nguyen         2020-08-06  1060   * @trb_length: buffer size of the TRB
e49d3cf4926af0 Felipe Balbi         2017-01-05  1061   * @chain: should this TRB be chained to the next?
e49d3cf4926af0 Felipe Balbi         2017-01-05  1062   * @node: only for isochronous endpoints. First TRB needs different type.
e49d3cf4926af0 Felipe Balbi         2017-01-05  1063   */
e49d3cf4926af0 Felipe Balbi         2017-01-05  1064  static void dwc3_prepare_one_trb(struct dwc3_ep *dep,
5d187c0454ef4c Thinh Nguyen         2020-08-06  1065  		struct dwc3_request *req, unsigned int trb_length,
e14441056da582 Felipe Balbi         2020-08-13  1066  		unsigned int chain, unsigned int node)
e49d3cf4926af0 Felipe Balbi         2017-01-05  1067  {
e49d3cf4926af0 Felipe Balbi         2017-01-05  1068  	struct dwc3_trb		*trb;
a31e63b608ff78 Anurag Kumar Vulisha 2018-03-27  1069  	dma_addr_t		dma;
a31e63b608ff78 Anurag Kumar Vulisha 2018-03-27  1070  
5d187c0454ef4c Thinh Nguyen         2020-08-06  1071  	if (req->request.num_sgs > 0)
a31e63b608ff78 Anurag Kumar Vulisha 2018-03-27  1072  		dma = sg_dma_address(req->start_sg);
5d187c0454ef4c Thinh Nguyen         2020-08-06  1073  	else
a31e63b608ff78 Anurag Kumar Vulisha 2018-03-27  1074  		dma = req->request.dma;
e49d3cf4926af0 Felipe Balbi         2017-01-05  1075  
e49d3cf4926af0 Felipe Balbi         2017-01-05  1076  	trb = &dep->trb_pool[dep->trb_enqueue];
e49d3cf4926af0 Felipe Balbi         2017-01-05  1077  
e49d3cf4926af0 Felipe Balbi         2017-01-05  1078  	if (!req->trb) {
e49d3cf4926af0 Felipe Balbi         2017-01-05  1079  		dwc3_gadget_move_started_request(req);
e49d3cf4926af0 Felipe Balbi         2017-01-05  1080  		req->trb = trb;
e49d3cf4926af0 Felipe Balbi         2017-01-05  1081  		req->trb_dma = dwc3_trb_dma_offset(dep, trb);
e49d3cf4926af0 Felipe Balbi         2017-01-05  1082  	}
e49d3cf4926af0 Felipe Balbi         2017-01-05  1083  
09fe1f8d7e2f46 Felipe Balbi         2018-08-01  1084  	req->num_trbs++;
09fe1f8d7e2f46 Felipe Balbi         2018-08-01  1085  
5d187c0454ef4c Thinh Nguyen         2020-08-06  1086  	__dwc3_prepare_one_trb(dep, trb, dma, trb_length, chain, node,
3eaecd0c2333aa Thinh Nguyen         2020-05-05 @1087  			stream_id, short_not_ok, no_interrupt, is_last);
e49d3cf4926af0 Felipe Balbi         2017-01-05  1088  }
e49d3cf4926af0 Felipe Balbi         2017-01-05  1089  

:::::: The code at line 1087 was first introduced by commit
:::::: 3eaecd0c2333aa9eeefce2ff130c9323cde53178 usb: dwc3: gadget: Handle XferComplete for streams

:::::: TO: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
:::::: CC: Felipe Balbi <balbi@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29798 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-31  9:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31  9:51 [balbi-usb:testing/next 24/24] drivers/usb/dwc3/gadget.c:1087:4: error: 'stream_id' undeclared; did you mean kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).