From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54C3C43461 for ; Wed, 9 Sep 2020 02:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A1382080C for ; Wed, 9 Sep 2020 02:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgIIC25 (ORCPT ); Tue, 8 Sep 2020 22:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbgIIC25 (ORCPT ); Tue, 8 Sep 2020 22:28:57 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3135C061573; Tue, 8 Sep 2020 19:28:56 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 087B411E3E4C2; Tue, 8 Sep 2020 19:12:00 -0700 (PDT) Date: Tue, 08 Sep 2020 19:28:45 -0700 (PDT) Message-Id: <20200908.192845.1191873689940729972.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, kuba@kernel.org, vigneshr@ti.com, m-karicheri2@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration From: David Miller In-Reply-To: <20200907143143.13735-3-grygorii.strashko@ti.com> References: <20200907143143.13735-1-grygorii.strashko@ti.com> <20200907143143.13735-3-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 08 Sep 2020 19:12:01 -0700 (PDT) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Grygorii Strashko Date: Mon, 7 Sep 2020 17:31:36 +0300 > + ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id); > + if (ale_dev_id) { > + params->ale_entries = ale_dev_id->tbl_entries; > + params->major_ver_mask = ale_dev_id->major_ver_mask; ... > - if (!ale->params.major_ver_mask) > - ale->params.major_ver_mask = 0xff; This is exactly the kind of change that causes regressions. The default for the mask if no dev_id is found is now zero, whereas before the default mask would be 0xff. Please don't make changes like this, they are very risky. In every step of these changes, existing behavior should be maintained as precisely as possible. Be as conservative as possible.