Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/arizona-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 000cb82023e3..bf48372db605 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c @@ -1043,8 +1043,9 @@ int arizona_dev_init(struct arizona *arizona) case CS47L24: break; /* No LDO1 regulator */ default: - ret = mfd_add_devices(arizona->dev, -1, early_devs, - ARRAY_SIZE(early_devs), NULL, 0, NULL); + ret = mfd_add_devices(arizona->dev, PLATFORM_DEVID_NONE, + early_devs, ARRAY_SIZE(early_devs), + NULL, 0, NULL); if (ret != 0) { dev_err(dev, "Failed to add early children: %d\n", ret); return ret; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/as3711.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/as3711.c b/drivers/mfd/as3711.c index 3adaec6c37df..5933f322ad52 100644 --- a/drivers/mfd/as3711.c +++ b/drivers/mfd/as3711.c @@ -184,8 +184,9 @@ static int as3711_i2c_probe(struct i2c_client *client, as3711_subdevs[AS3711_BACKLIGHT].pdata_size = 0; } - ret = devm_mfd_add_devices(as3711->dev, -1, as3711_subdevs, - ARRAY_SIZE(as3711_subdevs), NULL, 0, NULL); + ret = devm_mfd_add_devices(as3711->dev, PLATFORM_DEVID_NONE, + as3711_subdevs, ARRAY_SIZE(as3711_subdevs), + NULL, 0, NULL); if (ret < 0) dev_err(&client->dev, "add mfd devices failed: %d\n", ret); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/as3722.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/as3722.c b/drivers/mfd/as3722.c index 59dfeff71592..b2151f56f3d2 100644 --- a/drivers/mfd/as3722.c +++ b/drivers/mfd/as3722.c @@ -397,7 +397,7 @@ static int as3722_i2c_probe(struct i2c_client *i2c, return ret; } - ret = devm_mfd_add_devices(&i2c->dev, -1, as3722_devs, + ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_NONE, as3722_devs, ARRAY_SIZE(as3722_devs), NULL, 0, regmap_irq_get_domain(as3722->irq_data)); if (ret) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/atmel-hlcdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index 3c2414ba4b01..8ba13bc6fcf8 100644 --- a/drivers/mfd/atmel-hlcdc.c +++ b/drivers/mfd/atmel-hlcdc.c @@ -129,7 +129,7 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) dev_set_drvdata(dev, hlcdc); - return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, atmel_hlcdc_cells, ARRAY_SIZE(atmel_hlcdc_cells), NULL, 0, NULL); } -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/axp20x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index aa59496e4376..70aa538a4b64 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -967,7 +967,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x) return ret; } - ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells, + ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells, axp20x->nr_cells, NULL, 0, NULL); if (ret) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/bcm2835-pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c index 42fe67f1538e..a76014512bde 100644 --- a/drivers/mfd/bcm2835-pm.c +++ b/drivers/mfd/bcm2835-pm.c @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev) if (IS_ERR(pm->base)) return PTR_ERR(pm->base); - ret = devm_mfd_add_devices(dev, -1, + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs), NULL, 0, NULL); if (ret) @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev) if (IS_ERR(pm->asb)) return PTR_ERR(pm->asb); - ret = devm_mfd_add_devices(dev, -1, + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, bcm2835_power_devs, ARRAY_SIZE(bcm2835_power_devs), NULL, 0, NULL); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/bcm590xx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c index bfac5dc091ca..2f7186a6f6c0 100644 --- a/drivers/mfd/bcm590xx.c +++ b/drivers/mfd/bcm590xx.c @@ -78,8 +78,9 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri, goto err; } - ret = devm_mfd_add_devices(&i2c_pri->dev, -1, bcm590xx_devs, - ARRAY_SIZE(bcm590xx_devs), NULL, 0, NULL); + ret = devm_mfd_add_devices(&i2c_pri->dev, PLATFORM_DEVID_NONE, + bcm590xx_devs, ARRAY_SIZE(bcm590xx_devs), + NULL, 0, NULL); if (ret < 0) { dev_err(&i2c_pri->dev, "failed to add sub-devices: %d\n", ret); goto err; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/da9055-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c index 6d0af8486269..ff8fe165b937 100644 --- a/drivers/mfd/da9055-core.c +++ b/drivers/mfd/da9055-core.c @@ -400,7 +400,7 @@ int da9055_device_init(struct da9055 *da9055) da9055->irq_base = regmap_irq_chip_get_base(da9055->irq_data); - ret = mfd_add_devices(da9055->dev, -1, + ret = mfd_add_devices(da9055->dev, PLATFORM_DEVID_NONE, da9055_devs, ARRAY_SIZE(da9055_devs), NULL, da9055->irq_base, NULL); if (ret) -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/da9150-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c index 7f0aa1e8db96..e335cf718442 100644 --- a/drivers/mfd/da9150-core.c +++ b/drivers/mfd/da9150-core.c @@ -453,7 +453,7 @@ static int da9150_probe(struct i2c_client *client, enable_irq_wake(da9150->irq); - ret = mfd_add_devices(da9150->dev, -1, da9150_devs, + ret = mfd_add_devices(da9150->dev, PLATFORM_DEVID_NONE, da9150_devs, ARRAY_SIZE(da9150_devs), NULL, da9150->irq_base, NULL); if (ret) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/intel_msic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c index bb24c2a07900..e9944a81dc44 100644 --- a/drivers/mfd/intel_msic.c +++ b/drivers/mfd/intel_msic.c @@ -317,8 +317,9 @@ static int intel_msic_init_devices(struct intel_msic *msic) if (!pdata->irq[i]) continue; - ret = mfd_add_devices(&pdev->dev, -1, &msic_devs[i], 1, NULL, - pdata->irq[i], NULL); + ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, + &msic_devs[i], 1, NULL, pdata->irq[i], + NULL); if (ret) goto fail; } -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/intel_soc_pmic_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index ddd64f9e3341..b7bbe58dedcc 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -86,7 +86,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, /* Add lookup table for crc-pwm */ pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); - ret = mfd_add_devices(dev, -1, config->cell_dev, + ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE, config->cell_dev, config->n_cell_devs, NULL, 0, regmap_irq_get_domain(pmic->irq_chip_data)); if (ret) -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/kempld-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 52bec01149e5..71d484f31f04 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -105,7 +105,8 @@ static int kempld_register_cells_generic(struct kempld_device_data *pld) if (pld->feature_mask & KEMPLD_FEATURE_MASK_UART) devs[i++].name = kempld_dev_names[KEMPLD_UART]; - return mfd_add_devices(pld->dev, -1, devs, i, NULL, 0, NULL); + return mfd_add_devices(pld->dev, PLATFORM_DEVID_NONE, devs, i, NULL, 0, + NULL); } static struct resource kempld_ioresource = { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/lp8788.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/lp8788.c b/drivers/mfd/lp8788.c index 768d556b3fe9..8abd98bb1d9d 100644 --- a/drivers/mfd/lp8788.c +++ b/drivers/mfd/lp8788.c @@ -195,7 +195,7 @@ static int lp8788_probe(struct i2c_client *cl, const struct i2c_device_id *id) if (ret) return ret; - return mfd_add_devices(lp->dev, -1, lp8788_devs, + return mfd_add_devices(lp->dev, PLATFORM_DEVID_NONE, lp8788_devs, ARRAY_SIZE(lp8788_devs), NULL, 0, NULL); } -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/lp3943.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/lp3943.c b/drivers/mfd/lp3943.c index 13cb89be3d66..3e5d7336f59b 100644 --- a/drivers/mfd/lp3943.c +++ b/drivers/mfd/lp3943.c @@ -120,9 +120,8 @@ static int lp3943_probe(struct i2c_client *cl, const struct i2c_device_id *id) lp3943->mux_cfg = lp3943_mux_cfg; i2c_set_clientdata(cl, lp3943); - return devm_mfd_add_devices(dev, -1, lp3943_devs, - ARRAY_SIZE(lp3943_devs), - NULL, 0, NULL); + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, lp3943_devs, + ARRAY_SIZE(lp3943_devs), NULL, 0, NULL); } static const struct i2c_device_id lp3943_ids[] = { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index be185e9d5f16..93df79748a45 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -445,7 +445,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c, goto err_max77836; } - ret = mfd_add_devices(max14577->dev, -1, mfd_devs, + ret = mfd_add_devices(max14577->dev, PLATFORM_DEVID_NONE, mfd_devs, mfd_devs_size, NULL, 0, NULL); if (ret < 0) goto err_mfd; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index 71faf503844b..1f26d00fdd37 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -217,8 +217,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c) return ret; } - ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL, - 0, NULL); + ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells, + n_devs, NULL, 0, NULL); if (ret < 0) { dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret); return ret; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c index 596ed85cab3b..02fbdf0a66c3 100644 --- a/drivers/mfd/max77693.c +++ b/drivers/mfd/max77693.c @@ -274,7 +274,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c, pm_runtime_set_active(max77693->dev); - ret = mfd_add_devices(max77693->dev, -1, max77693_devs, + ret = mfd_add_devices(max77693->dev, PLATFORM_DEVID_NONE, max77693_devs, ARRAY_SIZE(max77693_devs), NULL, 0, NULL); if (ret < 0) goto err_mfd; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max77843.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max77843.c b/drivers/mfd/max77843.c index 209ee24d9ce1..da9c32c44e3d 100644 --- a/drivers/mfd/max77843.c +++ b/drivers/mfd/max77843.c @@ -148,7 +148,7 @@ static int max77843_probe(struct i2c_client *i2c, goto err_pmic_id; } - ret = mfd_add_devices(max77843->dev, -1, max77843_devs, + ret = mfd_add_devices(max77843->dev, PLATFORM_DEVID_NONE, max77843_devs, ARRAY_SIZE(max77843_devs), NULL, 0, NULL); if (ret < 0) { dev_err(&i2c->dev, "Failed to add mfd device\n"); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max8907.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c index d44baafd9d14..5119d4092d3d 100644 --- a/drivers/mfd/max8907.c +++ b/drivers/mfd/max8907.c @@ -257,7 +257,7 @@ static int max8907_i2c_probe(struct i2c_client *i2c, enable_irq(max8907->i2c_gen->irq); - ret = mfd_add_devices(max8907->dev, -1, max8907_cells, + ret = mfd_add_devices(max8907->dev, PLATFORM_DEVID_NONE, max8907_cells, ARRAY_SIZE(max8907_cells), NULL, 0, NULL); if (ret != 0) { dev_err(&i2c->dev, "failed to add MFD devices %d\n", ret); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c index 68d8f2b95287..0c5b8baead62 100644 --- a/drivers/mfd/max8997.c +++ b/drivers/mfd/max8997.c @@ -212,7 +212,7 @@ static int max8997_i2c_probe(struct i2c_client *i2c, max8997_irq_init(max8997); - ret = mfd_add_devices(max8997->dev, -1, max8997_devs, + ret = mfd_add_devices(max8997->dev, PLATFORM_DEVID_NONE, max8997_devs, ARRAY_SIZE(max8997_devs), NULL, 0, NULL); if (ret < 0) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/max8998.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c index 785f8e9841b7..33d92eddfd06 100644 --- a/drivers/mfd/max8998.c +++ b/drivers/mfd/max8998.c @@ -208,12 +208,12 @@ static int max8998_i2c_probe(struct i2c_client *i2c, switch (max8998->type) { case TYPE_LP3974: - ret = mfd_add_devices(max8998->dev, -1, + ret = mfd_add_devices(max8998->dev, PLATFORM_DEVID_NONE, lp3974_devs, ARRAY_SIZE(lp3974_devs), NULL, 0, NULL); break; case TYPE_MAX8998: - ret = mfd_add_devices(max8998->dev, -1, + ret = mfd_add_devices(max8998->dev, PLATFORM_DEVID_NONE, max8998_devs, ARRAY_SIZE(max8998_devs), NULL, 0, NULL); break; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/mc13xxx-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 1abe7432aad8..659e72cdac3d 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -379,8 +379,8 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx, if (!cell.name) return -ENOMEM; - return mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0, - regmap_irq_get_domain(mc13xxx->irq_data)); + return mfd_add_devices(mc13xxx->dev, PLATFORM_DEVID_NONE, &cell, 1, NULL, + 0, regmap_irq_get_domain(mc13xxx->irq_data)); } static int mc13xxx_add_subdevice(struct mc13xxx *mc13xxx, const char *format) -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/rc5t583.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c index d0dc48f99096..a4915f411ee8 100644 --- a/drivers/mfd/rc5t583.c +++ b/drivers/mfd/rc5t583.c @@ -270,8 +270,9 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c, dev_warn(&i2c->dev, "IRQ init failed: %d\n", ret); } - ret = devm_mfd_add_devices(rc5t583->dev, -1, rc5t583_subdevs, - ARRAY_SIZE(rc5t583_subdevs), NULL, 0, NULL); + ret = devm_mfd_add_devices(rc5t583->dev, PLATFORM_DEVID_NONE, + rc5t583_subdevs, ARRAY_SIZE(rc5t583_subdevs), + NULL, 0, NULL); if (ret) { dev_err(&i2c->dev, "add mfd devices failed: %d\n", ret); return ret; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/rdc321x-southbridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rdc321x-southbridge.c b/drivers/mfd/rdc321x-southbridge.c index fbb1faf95e27..6fb0d625cec9 100644 --- a/drivers/mfd/rdc321x-southbridge.c +++ b/drivers/mfd/rdc321x-southbridge.c @@ -71,7 +71,7 @@ static int rdc321x_sb_probe(struct pci_dev *pdev, rdc321x_gpio_pdata.sb_pdev = pdev; rdc321x_wdt_pdata.sb_pdev = pdev; - return devm_mfd_add_devices(&pdev->dev, -1, + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, rdc321x_sb_cells, ARRAY_SIZE(rdc321x_sb_cells), NULL, 0, NULL); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/retu-mfd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c index e7d27b7861c1..55e24e8343f3 100644 --- a/drivers/mfd/retu-mfd.c +++ b/drivers/mfd/retu-mfd.c @@ -271,9 +271,9 @@ static int retu_probe(struct i2c_client *i2c, const struct i2c_device_id *id) if (ret < 0) return ret; - ret = mfd_add_devices(rdev->dev, -1, rdat->children, rdat->nchildren, - NULL, regmap_irq_chip_get_base(rdev->irq_data), - NULL); + ret = mfd_add_devices(rdev->dev, PLATFORM_DEVID_NONE, rdat->children, + rdat->nchildren, NULL, + regmap_irq_chip_get_base(rdev->irq_data), NULL); if (ret < 0) { regmap_del_irq_chip(i2c->irq, rdev->irq_data); return ret; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/rt5033.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index 48381d9bf740..8ec245cc4393 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers/mfd/rt5033.c @@ -94,7 +94,7 @@ static int rt5033_i2c_probe(struct i2c_client *i2c, return ret; } - ret = devm_mfd_add_devices(rt5033->dev, -1, rt5033_devs, + ret = devm_mfd_add_devices(rt5033->dev, PLATFORM_DEVID_NONE, rt5033_devs, ARRAY_SIZE(rt5033_devs), NULL, 0, regmap_irq_get_domain(rt5033->irq_data)); if (ret < 0) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/sec-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 8d55992da19e..804f32d0ae22 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -457,8 +457,8 @@ static int sec_pmic_probe(struct i2c_client *i2c, sec_pmic->device_type); return -ENODEV; } - ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, NULL); + ret = devm_mfd_add_devices(sec_pmic->dev, PLATFORM_DEVID_NONE, + sec_devs, num_sec_devs, NULL, 0, NULL); if (ret) return ret; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/sky81452.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c index 3ad35bf0c015..a45cad77b87c 100644 --- a/drivers/mfd/sky81452.c +++ b/drivers/mfd/sky81452.c @@ -51,8 +51,8 @@ static int sky81452_probe(struct i2c_client *client, cells[1].platform_data = pdata->regulator_init_data; cells[1].pdata_size = sizeof(*pdata->regulator_init_data); - ret = devm_mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), - NULL, 0, NULL); + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, cells, + ARRAY_SIZE(cells), NULL, 0, NULL); if (ret) dev_err(dev, "failed to add child devices. err=%d\n", ret); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/sta2x11-mfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c index 1819c8fe4d8f..fafb3292dce8 100644 --- a/drivers/mfd/sta2x11-mfd.c +++ b/drivers/mfd/sta2x11-mfd.c @@ -594,7 +594,7 @@ static int sta2x11_mfd_probe(struct pci_dev *pdev, /* Just 2 bars for all mfd's at present */ for (i = 0; i < 2; i++) { - err = mfd_add_devices(&pdev->dev, -1, + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, setup_data->bars[i].cells, setup_data->bars[i].ncells, &pdev->resource[i], -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tc3589x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c index 7882a37ffc35..22821112cc6b 100644 --- a/drivers/mfd/tc3589x.c +++ b/drivers/mfd/tc3589x.c @@ -287,7 +287,8 @@ static int tc3589x_device_init(struct tc3589x *tc3589x) unsigned int blocks = tc3589x->pdata->block; if (blocks & TC3589x_BLOCK_GPIO) { - ret = mfd_add_devices(tc3589x->dev, -1, tc3589x_dev_gpio, + ret = mfd_add_devices(tc3589x->dev, PLATFORM_DEVID_NONE, + tc3589x_dev_gpio, ARRAY_SIZE(tc3589x_dev_gpio), NULL, 0, tc3589x->domain); if (ret) { @@ -298,7 +299,8 @@ static int tc3589x_device_init(struct tc3589x *tc3589x) } if (blocks & TC3589x_BLOCK_KEYPAD) { - ret = mfd_add_devices(tc3589x->dev, -1, tc3589x_dev_keypad, + ret = mfd_add_devices(tc3589x->dev, PLATFORM_DEVID_NONE, + tc3589x_dev_keypad, ARRAY_SIZE(tc3589x_dev_keypad), NULL, 0, tc3589x->domain); if (ret) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/timberdale.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c index faecbca6dba3..de1589fa2120 100644 --- a/drivers/mfd/timberdale.c +++ b/drivers/mfd/timberdale.c @@ -740,25 +740,25 @@ static int timb_probe(struct pci_dev *dev, ip_setup = priv->fw.config & TIMB_HW_VER_MASK; switch (ip_setup) { case TIMB_HW_VER0: - err = mfd_add_devices(&dev->dev, -1, + err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE, timberdale_cells_bar0_cfg0, ARRAY_SIZE(timberdale_cells_bar0_cfg0), &dev->resource[0], msix_entries[0].vector, NULL); break; case TIMB_HW_VER1: - err = mfd_add_devices(&dev->dev, -1, + err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE, timberdale_cells_bar0_cfg1, ARRAY_SIZE(timberdale_cells_bar0_cfg1), &dev->resource[0], msix_entries[0].vector, NULL); break; case TIMB_HW_VER2: - err = mfd_add_devices(&dev->dev, -1, + err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE, timberdale_cells_bar0_cfg2, ARRAY_SIZE(timberdale_cells_bar0_cfg2), &dev->resource[0], msix_entries[0].vector, NULL); break; case TIMB_HW_VER3: - err = mfd_add_devices(&dev->dev, -1, + err = mfd_add_devices(&dev->dev, PLATFORM_DEVID_NONE, timberdale_cells_bar0_cfg3, ARRAY_SIZE(timberdale_cells_bar0_cfg3), &dev->resource[0], msix_entries[0].vector, NULL); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps6507x.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c index 1f308c4e3694..15bb92ef64c7 100644 --- a/drivers/mfd/tps6507x.c +++ b/drivers/mfd/tps6507x.c @@ -100,8 +100,9 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c, tps6507x->read_dev = tps6507x_i2c_read_device; tps6507x->write_dev = tps6507x_i2c_write_device; - return devm_mfd_add_devices(tps6507x->dev, -1, tps6507x_devs, - ARRAY_SIZE(tps6507x_devs), NULL, 0, NULL); + return devm_mfd_add_devices(tps6507x->dev, PLATFORM_DEVID_NONE, + tps6507x_devs, ARRAY_SIZE(tps6507x_devs), + NULL, 0, NULL); } static const struct i2c_device_id tps6507x_i2c_id[] = { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps65090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c index 6cdf6c315034..f8f7170f5822 100644 --- a/drivers/mfd/tps65090.c +++ b/drivers/mfd/tps65090.c @@ -209,7 +209,7 @@ static int tps65090_i2c_probe(struct i2c_client *client, tps65090s[CHARGER].num_resources = 0; } - ret = mfd_add_devices(tps65090->dev, -1, tps65090s, + ret = mfd_add_devices(tps65090->dev, PLATFORM_DEVID_NONE, tps65090s, ARRAY_SIZE(tps65090s), NULL, 0, regmap_irq_get_domain(tps65090->irq_data)); if (ret) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps65217.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c index 2d9c282ec917..ef941bd611d2 100644 --- a/drivers/mfd/tps65217.c +++ b/drivers/mfd/tps65217.c @@ -351,7 +351,7 @@ static int tps65217_probe(struct i2c_client *client) tps65217s[i].num_resources = 0; } - ret = devm_mfd_add_devices(tps->dev, -1, tps65217s, + ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_NONE, tps65217s, ARRAY_SIZE(tps65217s), NULL, 0, tps->irq_domain); if (ret < 0) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps6586x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index c36597797ddd..18158fd8aa7d 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -550,7 +550,7 @@ static int tps6586x_i2c_probe(struct i2c_client *client, } } - ret = mfd_add_devices(tps6586x->dev, -1, + ret = mfd_add_devices(tps6586x->dev, PLATFORM_DEVID_NONE, tps6586x_cell, ARRAY_SIZE(tps6586x_cell), NULL, 0, tps6586x->irq_domain); if (ret < 0) { -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps65910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c index 11959021b50a..d332072ee9de 100644 --- a/drivers/mfd/tps65910.c +++ b/drivers/mfd/tps65910.c @@ -502,7 +502,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c, pm_power_off = tps65910_power_off; } - ret = devm_mfd_add_devices(tps65910->dev, -1, + ret = devm_mfd_add_devices(tps65910->dev, PLATFORM_DEVID_NONE, tps65910s, ARRAY_SIZE(tps65910s), NULL, 0, regmap_irq_get_domain(tps65910->irq_data)); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/tps80031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tps80031.c b/drivers/mfd/tps80031.c index 907452b86e32..c8ea8fbae281 100644 --- a/drivers/mfd/tps80031.c +++ b/drivers/mfd/tps80031.c @@ -488,7 +488,7 @@ static int tps80031_probe(struct i2c_client *client, tps80031_init_ext_control(tps80031, pdata); - ret = mfd_add_devices(tps80031->dev, -1, + ret = mfd_add_devices(tps80031->dev, PLATFORM_DEVID_NONE, tps80031_cell, ARRAY_SIZE(tps80031_cell), NULL, 0, regmap_irq_get_domain(tps80031->irq_data)); -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/twl6040.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c index b9c6d94b4002..702f9e216d42 100644 --- a/drivers/mfd/twl6040.c +++ b/drivers/mfd/twl6040.c @@ -794,8 +794,8 @@ static int twl6040_probe(struct i2c_client *client, regcache_cache_only(twl6040->regmap, true); regcache_mark_dirty(twl6040->regmap); - ret = mfd_add_devices(&client->dev, -1, twl6040->cells, children, - NULL, 0, NULL); + ret = mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, twl6040->cells, + children, NULL, 0, NULL); if (ret) goto readyirq_err; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/vx855.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/vx855.c b/drivers/mfd/vx855.c index 985f81c1739c..a53fb4c1ebdb 100644 --- a/drivers/mfd/vx855.c +++ b/drivers/mfd/vx855.c @@ -86,8 +86,8 @@ static int vx855_probe(struct pci_dev *pdev, vx855_gpio_resources[1].start = gpio_io_offset + VX855_PMIO_R_GPO; vx855_gpio_resources[1].end = vx855_gpio_resources[1].start + 3; - ret = mfd_add_devices(&pdev->dev, -1, vx855_cells, ARRAY_SIZE(vx855_cells), - NULL, 0, NULL); + ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, vx855_cells, + ARRAY_SIZE(vx855_cells), NULL, 0, NULL); /* we always return -ENODEV here in order to enable other * drivers like old, not-yet-platform_device ported i2c-viapro */ -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/wl1273-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wl1273-core.c b/drivers/mfd/wl1273-core.c index 1ab5e15a65eb..0af1322fd393 100644 --- a/drivers/mfd/wl1273-core.c +++ b/drivers/mfd/wl1273-core.c @@ -214,7 +214,7 @@ static int wl1273_core_probe(struct i2c_client *client, dev_dbg(&client->dev, "%s: number of children: %d.\n", __func__, children); - r = devm_mfd_add_devices(&client->dev, -1, core->cells, + r = devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, core->cells, children, NULL, 0, NULL); if (r) goto err; -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/wm8400-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c index 0fe32a05421b..9efca6f3fbb2 100644 --- a/drivers/mfd/wm8400-core.c +++ b/drivers/mfd/wm8400-core.c @@ -38,7 +38,8 @@ static int wm8400_register_codec(struct wm8400 *wm8400) .pdata_size = sizeof(*wm8400), }; - return devm_mfd_add_devices(wm8400->dev, -1, &cell, 1, NULL, 0, NULL); + return devm_mfd_add_devices(wm8400->dev, PLATFORM_DEVID_NONE, &cell, 1, + NULL, 0, NULL); } /* -- 2.17.1
Use PLATFORM_DEVID_NONE define instead of "-1" value because: - it brings some meaning, - it might point attention why auto device ID was not used. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mfd/wm8994-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c index 3b2b93c5bbcb..5a8d4cc00cc1 100644 --- a/drivers/mfd/wm8994-core.c +++ b/drivers/mfd/wm8994-core.c @@ -578,7 +578,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq) wm8994_irq_init(wm8994); - ret = mfd_add_devices(wm8994->dev, -1, + ret = mfd_add_devices(wm8994->dev, PLATFORM_DEVID_NONE, wm8994_devs, ARRAY_SIZE(wm8994_devs), NULL, 0, NULL); if (ret != 0) { -- 2.17.1
On 9/21/20 1:49 PM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
On 9/21/20 1:49 PM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
On 21/09/2020 22:49:38+0200, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/mfd/atmel-hlcdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c > index 3c2414ba4b01..8ba13bc6fcf8 100644 > --- a/drivers/mfd/atmel-hlcdc.c > +++ b/drivers/mfd/atmel-hlcdc.c > @@ -129,7 +129,7 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, hlcdc); > > - return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, > + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, atmel_hlcdc_cells, > ARRAY_SIZE(atmel_hlcdc_cells), > NULL, 0, NULL); > } > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Mon, Sep 21, 2020 at 11:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mfd/axp20x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index aa59496e4376..70aa538a4b64 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -967,7 +967,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x) > return ret; > } > > - ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells, > + ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells, > axp20x->nr_cells, NULL, 0, NULL); > > if (ret) { > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
On Mon, Sep 21, 2020 at 11:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mfd/intel_msic.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c > index bb24c2a07900..e9944a81dc44 100644 > --- a/drivers/mfd/intel_msic.c > +++ b/drivers/mfd/intel_msic.c > @@ -317,8 +317,9 @@ static int intel_msic_init_devices(struct intel_msic *msic) > if (!pdata->irq[i]) > continue; > > - ret = mfd_add_devices(&pdev->dev, -1, &msic_devs[i], 1, NULL, > - pdata->irq[i], NULL); > + ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, > + &msic_devs[i], 1, NULL, pdata->irq[i], > + NULL); > if (ret) > goto fail; > } > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
On Mon, Sep 21, 2020 at 11:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mfd/intel_soc_pmic_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index ddd64f9e3341..b7bbe58dedcc 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -86,7 +86,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > /* Add lookup table for crc-pwm */ > pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > > - ret = mfd_add_devices(dev, -1, config->cell_dev, > + ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE, config->cell_dev, > config->n_cell_devs, NULL, 0, > regmap_irq_get_domain(pmic->irq_chip_data)); > if (ret) > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
On Mon, Sep 21, 2020 at 10:49:35PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
On Mon, Sep 21, 2020 at 10:50:15PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
On Mon, Sep 21, 2020 at 10:50:16PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
On 21 September 2020 21:50, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
On 21 September 2020 21:50, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --] On Mon, 2020-09-21 at 22:49 +0200, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > drivers/mfd/bcm2835-pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c > index 42fe67f1538e..a76014512bde 100644 > --- a/drivers/mfd/bcm2835-pm.c > +++ b/drivers/mfd/bcm2835-pm.c > @@ -44,7 +44,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev) > if (IS_ERR(pm->base)) > return PTR_ERR(pm->base); > > - ret = devm_mfd_add_devices(dev, -1, > + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > bcm2835_pm_devs, ARRAY_SIZE(bcm2835_pm_devs), > NULL, 0, NULL); > if (ret) > @@ -60,7 +60,7 @@ static int bcm2835_pm_probe(struct platform_device *pdev) > if (IS_ERR(pm->asb)) > return PTR_ERR(pm->asb); > > - ret = devm_mfd_add_devices(dev, -1, > + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, > bcm2835_power_devs, > ARRAY_SIZE(bcm2835_power_devs), > NULL, 0, NULL); [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --]
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
> index be185e9d5f16..93df79748a45 100644
> --- a/drivers/mfd/max14577.c
> +++ b/drivers/mfd/max14577.c
> @@ -445,7 +445,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c,
> goto err_max77836;
> }
>
> - ret = mfd_add_devices(max14577->dev, -1, mfd_devs,
> + ret = mfd_add_devices(max14577->dev, PLATFORM_DEVID_NONE, mfd_devs,
> mfd_devs_size, NULL, 0, NULL);
> if (ret < 0)
> goto err_mfd;
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mfd/max77686.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..1f26d00fdd37 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -217,8 +217,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c)
> return ret;
> }
>
> - ret = devm_mfd_add_devices(max77686->dev, -1, cells, n_devs, NULL,
> - 0, NULL);
> + ret = devm_mfd_add_devices(max77686->dev, PLATFORM_DEVID_NONE, cells,
> + n_devs, NULL, 0, NULL);
> if (ret < 0) {
> dev_err(&i2c->dev, "failed to add MFD devices: %d\n", ret);
> return ret;
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 9/22/20 5:49 AM, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mfd/max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 596ed85cab3b..02fbdf0a66c3 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -274,7 +274,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
>
> pm_runtime_set_active(max77693->dev);
>
> - ret = mfd_add_devices(max77693->dev, -1, max77693_devs,
> + ret = mfd_add_devices(max77693->dev, PLATFORM_DEVID_NONE, max77693_devs,
> ARRAY_SIZE(max77693_devs), NULL, 0, NULL);
> if (ret < 0)
> goto err_mfd;
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics