From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DEFC4727C for ; Tue, 22 Sep 2020 06:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFF0723A1D for ; Tue, 22 Sep 2020 06:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728278AbgIVGy2 (ORCPT ); Tue, 22 Sep 2020 02:54:28 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:49222 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbgIVGy2 (ORCPT ); Tue, 22 Sep 2020 02:54:28 -0400 Received: from relay1-d.mail.gandi.net (unknown [217.70.183.193]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 04FCA3AE602; Tue, 22 Sep 2020 06:49:26 +0000 (UTC) X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 02909240007; Tue, 22 Sep 2020 06:49:01 +0000 (UTC) Date: Tue, 22 Sep 2020 08:49:01 +0200 From: Alexandre Belloni To: Krzysztof Kozlowski Cc: Lee Jones , Nicolas Ferre , Ludovic Desroches , Chen-Yu Tsai , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Support Opensource , Andy Shevchenko , Milo Kim , Chanwoo Choi , Bartlomiej Zolnierkiewicz , Sangbeom Kim , Tony Lindgren , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 04/42] mfd: atmel-hlcdc: use PLATFORM_DEVID_NONE Message-ID: <20200922064901.GM9675@piout.net> References: <20200921205016.20461-1-krzk@kernel.org> <20200921205016.20461-4-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921205016.20461-4-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 21/09/2020 22:49:38+0200, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni > --- > drivers/mfd/atmel-hlcdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c > index 3c2414ba4b01..8ba13bc6fcf8 100644 > --- a/drivers/mfd/atmel-hlcdc.c > +++ b/drivers/mfd/atmel-hlcdc.c > @@ -129,7 +129,7 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, hlcdc); > > - return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, > + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, atmel_hlcdc_cells, > ARRAY_SIZE(atmel_hlcdc_cells), > NULL, 0, NULL); > } > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com