From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5971C4727F for ; Wed, 30 Sep 2020 05:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97C2720706 for ; Wed, 30 Sep 2020 05:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725893AbgI3FRE (ORCPT ); Wed, 30 Sep 2020 01:17:04 -0400 Received: from muru.com ([72.249.23.125]:45690 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725320AbgI3FRE (ORCPT ); Wed, 30 Sep 2020 01:17:04 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 783E380BF; Wed, 30 Sep 2020 05:17:05 +0000 (UTC) Date: Wed, 30 Sep 2020 08:16:59 +0300 From: Tony Lindgren To: Linus Walleij Cc: Drew Fustini , Linux ARM , Rob Herring , Linux-OMAP , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Haojian Zhuang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , =?utf-8?Q?Beno=C3=AEt?= Cousson , Jason Kridner , Robert Nelson , Trent Piepho Subject: Re: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Message-ID: <20200930051659.GO9471@atomide.com> References: <20200913210825.2022552-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Linus Walleij [200929 12:51]: > On Sun, Sep 13, 2020 at 11:17 PM Drew Fustini wrote: > > > The property #pinctrl-cells can either be 2 or 3. There is currently > > only a check to make sure that #pinctrl-cells is 2 or greater. This > > patch adds a check to make sure it is not greater than 3. > > > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") > > Reported-by: Trent Piepho > > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > > Signed-off-by: Drew Fustini > > Tony, does this and the other patch look good to you? Hmm well the description looks a bit confusing, #pinctrl-cells can also be 1 that's the default. Might be worth clarifying that part. Regards, Tony