Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2
@ 2020-09-21 22:50 Drew Fustini
  2020-10-01  8:08 ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Drew Fustini @ 2020-09-21 22:50 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Linus Walleij, Jason Kridner,
	Robert Nelson, Trent Piepho, Christina Quast, linux-omap,
	linux-kernel, devicetree, linux-gpio
  Cc: Drew Fustini

Modify the AM33XX_IOPAD macro so that it works now that #pinctrl-cells =
<2>. The third parameter is just a zero and the pinctrl-single driver
will just OR this with the second parameter so it has no actual effect.

There are no longer any dts files using this macro (following my patch
to am335x-guardian.dts), but this will keep dts files not in mainline
from breaking.

Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
Suggested-by: Tony Lindgren <tony@atomide.com>
Reported-by: Trent Piepho <tpiepho@gmail.com>
Link: https://lore.kernel.org/linux-devicetree/20200921064707.GN7101@atomide.com/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
NOTE:
checkpatch complains "Macros with complex values should be enclosed in 
parentheses" but all the other marcos in that section have the same
format so it seems appropriate to ignore checkpatch and maintain the
style.

 include/dt-bindings/pinctrl/omap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/dt-bindings/pinctrl/omap.h b/include/dt-bindings/pinctrl/omap.h
index 2d2a8c737822..f48245ff87e5 100644
--- a/include/dt-bindings/pinctrl/omap.h
+++ b/include/dt-bindings/pinctrl/omap.h
@@ -64,7 +64,7 @@
 #define OMAP3_WKUP_IOPAD(pa, val)	OMAP_IOPAD_OFFSET((pa), 0x2a00) (val)
 #define DM814X_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
 #define DM816X_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
-#define AM33XX_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
+#define AM33XX_IOPAD(pa, val)		OMAP_IOPAD_OFFSET((pa), 0x0800) (val) (0)
 #define AM33XX_PADCONF(pa, conf, mux)	OMAP_IOPAD_OFFSET((pa), 0x0800) (conf) (mux)
 
 /*
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2
  2020-09-21 22:50 [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2 Drew Fustini
@ 2020-10-01  8:08 ` Linus Walleij
  2020-10-01  8:12   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2020-10-01  8:08 UTC (permalink / raw)
  To: Drew Fustini, Tony Lindgren
  Cc: Rob Herring, Jason Kridner, Robert Nelson, Trent Piepho,
	Christina Quast, Linux-OMAP, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:GPIO SUBSYSTEM

On Tue, Sep 22, 2020 at 12:57 AM Drew Fustini <drew@beagleboard.org> wrote:

> Modify the AM33XX_IOPAD macro so that it works now that #pinctrl-cells =
> <2>. The third parameter is just a zero and the pinctrl-single driver
> will just OR this with the second parameter so it has no actual effect.
>
> There are no longer any dts files using this macro (following my patch
> to am335x-guardian.dts), but this will keep dts files not in mainline
> from breaking.
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Suggested-by: Tony Lindgren <tony@atomide.com>
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-devicetree/20200921064707.GN7101@atomide.com/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>

I didn't get a review tag on this one, Tony is this something I
should be applying?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2
  2020-10-01  8:08 ` Linus Walleij
@ 2020-10-01  8:12   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-10-01  8:12 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Drew Fustini, Rob Herring, Jason Kridner, Robert Nelson,
	Trent Piepho, Christina Quast, Linux-OMAP, linux-kernel,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:GPIO SUBSYSTEM

* Linus Walleij <linus.walleij@linaro.org> [201001 08:08]:
> On Tue, Sep 22, 2020 at 12:57 AM Drew Fustini <drew@beagleboard.org> wrote:
> 
> > Modify the AM33XX_IOPAD macro so that it works now that #pinctrl-cells =
> > <2>. The third parameter is just a zero and the pinctrl-single driver
> > will just OR this with the second parameter so it has no actual effect.
> >
> > There are no longer any dts files using this macro (following my patch
> > to am335x-guardian.dts), but this will keep dts files not in mainline
> > from breaking.
> >
> > Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> > Suggested-by: Tony Lindgren <tony@atomide.com>
> > Reported-by: Trent Piepho <tpiepho@gmail.com>
> > Link: https://lore.kernel.org/linux-devicetree/20200921064707.GN7101@atomide.com/
> > Signed-off-by: Drew Fustini <drew@beagleboard.org>
> 
> I didn't get a review tag on this one, Tony is this something I
> should be applying?

Thanks for checking, looks like I already applied into my fixes branch:

b753e41d9999 ("ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2")

Regards,

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 22:50 [PATCH] ARM: dts: am33xx: modify AM33XX_IOPAD for #pinctrl-cells = 2 Drew Fustini
2020-10-01  8:08 ` Linus Walleij
2020-10-01  8:12   ` Tony Lindgren

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git