From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EC0C35257 for ; Fri, 2 Oct 2020 23:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B166207DE for ; Fri, 2 Oct 2020 23:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601679864; bh=wchb8rjkjVP2Ub7v/OSfMn7lefDi7YZt+nvLk2nYH00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=U+ADCLDOazZw9UQSpvGvU/uUWwWry4RoabTARRGyrsTaDZzPRNiYMB5RlTFyb/8R7 XjaGzYqa/3Lv0G9OdWD0RKeReyj9q0AtwvbVlq9T0Tp7WWQUIUe7GqEPSo8biIJjIx VXNwYB6VSrnTb1Jh0lnEdw7OVjZBRAcq6GP1AjTE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725763AbgJBXEX (ORCPT ); Fri, 2 Oct 2020 19:04:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:51004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBXEX (ORCPT ); Fri, 2 Oct 2020 19:04:23 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD2962074B; Fri, 2 Oct 2020 23:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601679863; bh=wchb8rjkjVP2Ub7v/OSfMn7lefDi7YZt+nvLk2nYH00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pI6NnxXw1oRnzkARPkW+Iuzz5ssenhrH1yGwxuWEh/O+qzcgmVmMFPd0BuH04aNvr dU7/qV+Jz+XooMWD4xZZKZn+VdNiwm87h0xhZf4G7RlyIVf09xUkwxFQB5Nx/K0w2f ifQzgeqvSFWfsrzgiNIfnR5VpJc8zOs/pmz1hb5w= Date: Fri, 2 Oct 2020 16:04:21 -0700 From: Jakub Kicinski To: Grygorii Strashko Cc: "David S. Miller" , , Vignesh Raghavendra , Sekhar Nori , , , Murali Karicheri Subject: Re: [PATCH net-next 0/8] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode Message-ID: <20201002160421.59363229@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201001105258.2139-1-grygorii.strashko@ti.com> <20201001160847.3b5d91f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, 2 Oct 2020 12:56:43 +0300 Grygorii Strashko wrote: > On 02/10/2020 02:08, Jakub Kicinski wrote: > > On Thu, 1 Oct 2020 13:52:50 +0300 Grygorii Strashko wrote: > >> This series adds multi-port support in mac-only mode (multi MAC mode) to TI > >> AM65x CPSW driver in preparation for enabling support for multi-port devices, > >> like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. > >> > >> The multi MAC mode is implemented by configuring every enabled port in "mac-only" > >> mode (all ingress packets are sent only to the Host port and egress packets > >> directed to target Ext. Port) and creating separate net_device for > >> every enabled Ext. port. > > > > Do I get it right that you select the mode based on platform? Can the > > other mode still be supported on these platforms? > > > > Is this a transition to normal DSA mode where ports always have netdevs? > > The idea here is to start in multi mac mode by default, as we still > have pretty high demand for this. Then, and we are working on it, the > switchdev mode is going to be introduces (not DSA). The switch > between modes will happen by using devlink option - the approach is > similar to what was used for Sitara CPSW cpsw_new.c driver [1]. What's unclear from the patches is whether the default configuration for already supported platforms will change? All the patches sound like they are "in preparation for support of K3 J721E" etc. So this is just code restructuring with no user-visible changes?