* [PATCH v7 01/12] leds: pwm: Remove platform_data support
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-07 10:03 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
` (11 subsequent siblings)
12 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Denis Osterland-Heim, Marek Behún
Since commit 141f15c66d94 ("leds: pwm: remove header") that platform
interface is not usable from outside and there seems to be no in tree
user anymore. All in-tree users of the leds-pwm driver seem to use DT
currently. Getting rid of the old platform interface allows the
leds-pwm driver to switch over from 'devm_led_classdev_register()' to
'devm_led_classdev_register_ext()'.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Cc: Denis Osterland-Heim <denis.osterland@diehl.com>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
---
Notes:
v6 -> v7:
* (no changes on this patch)
v5 -> v6:
* added Reviewed-by from Marek
* minimal commit message rewording, because a later patch was
already applied
v5:
* added this patch to series (replacing another patch with a not
working, different approach)
drivers/leds/leds-pwm.c | 30 +++++-------------------------
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 2a16ae0bf022..f53f9309ca6c 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -24,11 +24,6 @@ struct led_pwm {
unsigned int max_brightness;
};
-struct led_pwm_platform_data {
- int num_leds;
- struct led_pwm *leds;
-};
-
struct led_pwm_data {
struct led_classdev cdev;
struct pwm_device *pwm;
@@ -60,6 +55,7 @@ static int led_pwm_set(struct led_classdev *led_cdev,
return pwm_apply_state(led_dat->pwm, &led_dat->pwmstate);
}
+__attribute__((nonnull))
static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
struct led_pwm *led, struct fwnode_handle *fwnode)
{
@@ -73,10 +69,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
led_data->cdev.max_brightness = led->max_brightness;
led_data->cdev.flags = LED_CORE_SUSPENDRESUME;
- if (fwnode)
- led_data->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);
- else
- led_data->pwm = devm_pwm_get(dev, led->name);
+ led_data->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);
if (IS_ERR(led_data->pwm))
return dev_err_probe(dev, PTR_ERR(led_data->pwm),
"unable to request PWM for %s\n",
@@ -139,15 +132,11 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
static int led_pwm_probe(struct platform_device *pdev)
{
- struct led_pwm_platform_data *pdata = dev_get_platdata(&pdev->dev);
struct led_pwm_priv *priv;
- int count, i;
int ret = 0;
+ int count;
- if (pdata)
- count = pdata->num_leds;
- else
- count = device_get_child_node_count(&pdev->dev);
+ count = device_get_child_node_count(&pdev->dev);
if (!count)
return -EINVAL;
@@ -157,16 +146,7 @@ static int led_pwm_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;
- if (pdata) {
- for (i = 0; i < count; i++) {
- ret = led_pwm_add(&pdev->dev, priv, &pdata->leds[i],
- NULL);
- if (ret)
- break;
- }
- } else {
- ret = led_pwm_create_fwnode(&pdev->dev, priv);
- }
+ ret = led_pwm_create_fwnode(&pdev->dev, priv);
if (ret)
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 01/12] leds: pwm: Remove platform_data support
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
@ 2020-10-07 10:03 ` Pavel Machek
0 siblings, 0 replies; 38+ messages in thread
From: Pavel Machek @ 2020-10-07 10:03 UTC (permalink / raw)
To: Alexander Dahl
Cc: Dan Murphy, Rob Herring, Alexander Dahl, Jacek Anaszewski,
linux-leds, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, linux-omap, linux-stm32, linux-amlogic,
linux-mips, Denis Osterland-Heim, Marek Behún
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Mon 2020-10-05 22:34:40, Alexander Dahl wrote:
> Since commit 141f15c66d94 ("leds: pwm: remove header") that platform
> interface is not usable from outside and there seems to be no in tree
> user anymore. All in-tree users of the leds-pwm driver seem to use DT
> currently. Getting rid of the old platform interface allows the
> leds-pwm driver to switch over from 'devm_led_classdev_register()' to
> 'devm_led_classdev_register_ext()'.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Cc: Denis Osterland-Heim <denis.osterland@diehl.com>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>
Thanks, applied.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-07 10:02 ` Pavel Machek
` (2 more replies)
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
` (10 subsequent siblings)
12 siblings, 3 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Krzysztof Kozlowski, Rob Herring, Peter Ujfalusi, Russell King
The example was adapted in the following ways:
- make use of the now supported 'function' and 'color' properties
- remove pwm nodes, those are documented elsewhere
- align node names to new dt schema rules and dt recommendations
License was not explicitly set before. The license set now is
recommended by DT project.
Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Russell King <linux@armlinux.org.uk>
---
Notes:
NOTE: Due to license set/change this needs Acked-by or Signed-off-by from:
* Peter Ujfalusi
* Russell King
That was discussed already with Peter (original author), still waiting
for Acked-by though …
Changelog
---------
v6 -> v7:
* added Reviewed-by (Krzysztof Kozlowski)
* reworded commit message (suggested by Krzysztof)
* added Reviewed-by (Rob Herring)
v5 -> v6:
* removed pwm nodes from example (Rob)
* renamed led-controller node in example (Rob)
v4 -> v5:
* updated based on feedback by Rob Herring
* removed Acked-by
v3 -> v4:
* added Cc to original author of the binding
v2 -> v3:
* changed license identifier to recommended one
* added Acked-by
v2:
* added this patch to series (Suggested-by: Jacek Anaszewski)
.../devicetree/bindings/leds/leds-pwm.txt | 50 -------------
.../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++
2 files changed, 70 insertions(+), 50 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt
deleted file mode 100644
index 6c6583c35f2f..000000000000
--- a/Documentation/devicetree/bindings/leds/leds-pwm.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-LED connected to PWM
-
-Required properties:
-- compatible : should be "pwm-leds".
-
-Each LED is represented as a sub-node of the pwm-leds device. Each
-node's name represents the name of the corresponding LED.
-
-LED sub-node properties:
-- pwms : PWM property to point to the PWM device (phandle)/port (id) and to
- specify the period time to be used: <&phandle id period_ns>;
-- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device
- For the pwms and pwm-names property please refer to:
- Documentation/devicetree/bindings/pwm/pwm.txt
-- max-brightness : Maximum brightness possible for the LED
-- active-low : (optional) For PWMs where the LED is wired to supply
- rather than ground.
-- label : (optional)
- see Documentation/devicetree/bindings/leds/common.txt
-- linux,default-trigger : (optional)
- see Documentation/devicetree/bindings/leds/common.txt
-
-Example:
-
-twl_pwm: pwm {
- /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
- compatible = "ti,twl6030-pwm";
- #pwm-cells = <2>;
-};
-
-twl_pwmled: pwmled {
- /* provides one PWM (id 0 for Charing indicator LED) */
- compatible = "ti,twl6030-pwmled";
- #pwm-cells = <2>;
-};
-
-pwmleds {
- compatible = "pwm-leds";
- kpad {
- label = "omap4::keypad";
- pwms = <&twl_pwm 0 7812500>;
- max-brightness = <127>;
- };
-
- charging {
- label = "omap4:green:chrg";
- pwms = <&twl_pwmled 0 7812500>;
- max-brightness = <255>;
- };
-};
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
new file mode 100644
index 000000000000..fe4d5fd25913
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LEDs connected to PWM
+
+maintainers:
+ - Pavel Machek <pavel@ucw.cz>
+
+description:
+ Each LED is represented as a sub-node of the pwm-leds device. Each
+ node's name represents the name of the corresponding LED.
+
+properties:
+ compatible:
+ const: pwm-leds
+
+patternProperties:
+ "^led(-[0-9a-f]+)?$":
+ type: object
+
+ $ref: common.yaml#
+
+ properties:
+ pwms:
+ maxItems: 1
+
+ pwm-names: true
+
+ max-brightness:
+ description:
+ Maximum brightness possible for the LED
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ active-low:
+ description:
+ For PWMs where the LED is wired to supply rather than ground.
+ type: boolean
+
+ required:
+ - pwms
+ - max-brightness
+
+additionalProperties: false
+
+examples:
+ - |
+
+ #include <dt-bindings/leds/common.h>
+
+ led-controller {
+ compatible = "pwm-leds";
+
+ led-1 {
+ label = "omap4::keypad";
+ pwms = <&twl_pwm 0 7812500>;
+ max-brightness = <127>;
+ };
+
+ led-2 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_CHARGING;
+ pwms = <&twl_pwmled 0 7812500>;
+ max-brightness = <255>;
+ };
+ };
+
+...
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
@ 2020-10-07 10:02 ` Pavel Machek
2020-10-07 10:03 ` Krzysztof Kozlowski
2020-10-28 20:39 ` Alexander Dahl
2020-11-25 11:08 ` Pavel Machek
2 siblings, 1 reply; 38+ messages in thread
From: Pavel Machek @ 2020-10-07 10:02 UTC (permalink / raw)
To: Alexander Dahl
Cc: Dan Murphy, Rob Herring, Alexander Dahl, Jacek Anaszewski,
linux-leds, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, linux-omap, linux-stm32, linux-amlogic,
linux-mips, Krzysztof Kozlowski, Rob Herring, Peter Ujfalusi,
Russell King
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Mon 2020-10-05 22:34:41, Alexander Dahl wrote:
> The example was adapted in the following ways:
>
> - make use of the now supported 'function' and 'color' properties
> - remove pwm nodes, those are documented elsewhere
> - align node names to new dt schema rules and dt recommendations
>
> License was not explicitly set before. The license set now is
> recommended by DT project.
>
> Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Russell King <linux@armlinux.org.uk>
> ---
>
> Notes:
> NOTE: Due to license set/change this needs Acked-by or Signed-off-by from:
> * Peter Ujfalusi
> * Russell King
Russell King authored two lines of the documentation. He can state
objections now, but I'll not wait for his Acked-by.
> That was discussed already with Peter (original author), still waiting
> for Acked-by though …
If Peter was okay with license change, I guess we can continue here.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-07 10:02 ` Pavel Machek
@ 2020-10-07 10:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 38+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-07 10:03 UTC (permalink / raw)
To: Pavel Machek
Cc: Alexander Dahl, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Rob Herring, Peter Ujfalusi,
Russell King
On Wed, 7 Oct 2020 at 12:02, Pavel Machek <pavel@ucw.cz> wrote:
>
> On Mon 2020-10-05 22:34:41, Alexander Dahl wrote:
> > The example was adapted in the following ways:
> >
> > - make use of the now supported 'function' and 'color' properties
> > - remove pwm nodes, those are documented elsewhere
> > - align node names to new dt schema rules and dt recommendations
> >
> > License was not explicitly set before. The license set now is
> > recommended by DT project.
> >
> > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > ---
> >
> > Notes:
> > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from:
> > * Peter Ujfalusi
> > * Russell King
>
> Russell King authored two lines of the documentation. He can state
> objections now, but I'll not wait for his Acked-by.
>
> > That was discussed already with Peter (original author), still waiting
> > for Acked-by though …
>
> If Peter was okay with license change, I guess we can continue here.
Having an Ack is not too much to ask to relicense the copyrights.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-07 10:02 ` Pavel Machek
@ 2020-10-28 20:39 ` Alexander Dahl
2020-10-29 13:46 ` Russell King - ARM Linux admin
2020-11-25 11:08 ` Pavel Machek
2 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-28 20:39 UTC (permalink / raw)
To: Peter Ujfalusi, Russell King
Cc: Alexander Dahl, Alexander Dahl, linux-leds, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc, linux-omap,
linux-stm32, linux-amlogic, linux-mips, Rob Herring
[-- Attachment #1: Type: text/plain, Size: 6539 bytes --]
Hello,
Peter, Russel, could you please give your Acked-by or Signed-off-by on
this patch? Your ack is needed, because the license is now explicitly
set (it was not explicit before), and you were the contributors to
this binding before the conversion to yaml.
Thanks and Greets
Alex
On Mon, Oct 05, 2020 at 10:34:41PM +0200, Alexander Dahl wrote:
> The example was adapted in the following ways:
>
> - make use of the now supported 'function' and 'color' properties
> - remove pwm nodes, those are documented elsewhere
> - align node names to new dt schema rules and dt recommendations
>
> License was not explicitly set before. The license set now is
> recommended by DT project.
>
> Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Russell King <linux@armlinux.org.uk>
> ---
>
> Notes:
> NOTE: Due to license set/change this needs Acked-by or Signed-off-by from:
> * Peter Ujfalusi
> * Russell King
>
> That was discussed already with Peter (original author), still waiting
> for Acked-by though …
>
> Changelog
> ---------
> v6 -> v7:
> * added Reviewed-by (Krzysztof Kozlowski)
> * reworded commit message (suggested by Krzysztof)
> * added Reviewed-by (Rob Herring)
>
> v5 -> v6:
> * removed pwm nodes from example (Rob)
> * renamed led-controller node in example (Rob)
>
> v4 -> v5:
> * updated based on feedback by Rob Herring
> * removed Acked-by
>
> v3 -> v4:
> * added Cc to original author of the binding
>
> v2 -> v3:
> * changed license identifier to recommended one
> * added Acked-by
>
> v2:
> * added this patch to series (Suggested-by: Jacek Anaszewski)
>
> .../devicetree/bindings/leds/leds-pwm.txt | 50 -------------
> .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++
> 2 files changed, 70 insertions(+), 50 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> deleted file mode 100644
> index 6c6583c35f2f..000000000000
> --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -LED connected to PWM
> -
> -Required properties:
> -- compatible : should be "pwm-leds".
> -
> -Each LED is represented as a sub-node of the pwm-leds device. Each
> -node's name represents the name of the corresponding LED.
> -
> -LED sub-node properties:
> -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to
> - specify the period time to be used: <&phandle id period_ns>;
> -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device
> - For the pwms and pwm-names property please refer to:
> - Documentation/devicetree/bindings/pwm/pwm.txt
> -- max-brightness : Maximum brightness possible for the LED
> -- active-low : (optional) For PWMs where the LED is wired to supply
> - rather than ground.
> -- label : (optional)
> - see Documentation/devicetree/bindings/leds/common.txt
> -- linux,default-trigger : (optional)
> - see Documentation/devicetree/bindings/leds/common.txt
> -
> -Example:
> -
> -twl_pwm: pwm {
> - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
> - compatible = "ti,twl6030-pwm";
> - #pwm-cells = <2>;
> -};
> -
> -twl_pwmled: pwmled {
> - /* provides one PWM (id 0 for Charing indicator LED) */
> - compatible = "ti,twl6030-pwmled";
> - #pwm-cells = <2>;
> -};
> -
> -pwmleds {
> - compatible = "pwm-leds";
> - kpad {
> - label = "omap4::keypad";
> - pwms = <&twl_pwm 0 7812500>;
> - max-brightness = <127>;
> - };
> -
> - charging {
> - label = "omap4:green:chrg";
> - pwms = <&twl_pwmled 0 7812500>;
> - max-brightness = <255>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> new file mode 100644
> index 000000000000..fe4d5fd25913
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LEDs connected to PWM
> +
> +maintainers:
> + - Pavel Machek <pavel@ucw.cz>
> +
> +description:
> + Each LED is represented as a sub-node of the pwm-leds device. Each
> + node's name represents the name of the corresponding LED.
> +
> +properties:
> + compatible:
> + const: pwm-leds
> +
> +patternProperties:
> + "^led(-[0-9a-f]+)?$":
> + type: object
> +
> + $ref: common.yaml#
> +
> + properties:
> + pwms:
> + maxItems: 1
> +
> + pwm-names: true
> +
> + max-brightness:
> + description:
> + Maximum brightness possible for the LED
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + active-low:
> + description:
> + For PWMs where the LED is wired to supply rather than ground.
> + type: boolean
> +
> + required:
> + - pwms
> + - max-brightness
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
> + #include <dt-bindings/leds/common.h>
> +
> + led-controller {
> + compatible = "pwm-leds";
> +
> + led-1 {
> + label = "omap4::keypad";
> + pwms = <&twl_pwm 0 7812500>;
> + max-brightness = <127>;
> + };
> +
> + led-2 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_CHARGING;
> + pwms = <&twl_pwmled 0 7812500>;
> + max-brightness = <255>;
> + };
> + };
> +
> +...
> --
> 2.20.1
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-28 20:39 ` Alexander Dahl
@ 2020-10-29 13:46 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 38+ messages in thread
From: Russell King - ARM Linux admin @ 2020-10-29 13:46 UTC (permalink / raw)
To: Alexander Dahl
Cc: Peter Ujfalusi, Alexander Dahl, linux-leds, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc, linux-omap,
linux-stm32, linux-amlogic, linux-mips, Rob Herring
On Wed, Oct 28, 2020 at 09:39:54PM +0100, Alexander Dahl wrote:
> Hello,
>
> Peter, Russel, could you please give your Acked-by or Signed-off-by on
> this patch? Your ack is needed, because the license is now explicitly
> set (it was not explicit before), and you were the contributors to
> this binding before the conversion to yaml.
For the license change only:
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
(Please drop the Cc attributation in the commit to
linux@armlinux.org.uk thanks.)
>
> Thanks and Greets
> Alex
>
> On Mon, Oct 05, 2020 at 10:34:41PM +0200, Alexander Dahl wrote:
> > The example was adapted in the following ways:
> >
> > - make use of the now supported 'function' and 'color' properties
> > - remove pwm nodes, those are documented elsewhere
> > - align node names to new dt schema rules and dt recommendations
> >
> > License was not explicitly set before. The license set now is
> > recommended by DT project.
> >
> > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > ---
> >
> > Notes:
> > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from:
> > * Peter Ujfalusi
> > * Russell King
> >
> > That was discussed already with Peter (original author), still waiting
> > for Acked-by though …
> >
> > Changelog
> > ---------
> > v6 -> v7:
> > * added Reviewed-by (Krzysztof Kozlowski)
> > * reworded commit message (suggested by Krzysztof)
> > * added Reviewed-by (Rob Herring)
> >
> > v5 -> v6:
> > * removed pwm nodes from example (Rob)
> > * renamed led-controller node in example (Rob)
> >
> > v4 -> v5:
> > * updated based on feedback by Rob Herring
> > * removed Acked-by
> >
> > v3 -> v4:
> > * added Cc to original author of the binding
> >
> > v2 -> v3:
> > * changed license identifier to recommended one
> > * added Acked-by
> >
> > v2:
> > * added this patch to series (Suggested-by: Jacek Anaszewski)
> >
> > .../devicetree/bindings/leds/leds-pwm.txt | 50 -------------
> > .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++
> > 2 files changed, 70 insertions(+), 50 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt
> > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt
> > deleted file mode 100644
> > index 6c6583c35f2f..000000000000
> > --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt
> > +++ /dev/null
> > @@ -1,50 +0,0 @@
> > -LED connected to PWM
> > -
> > -Required properties:
> > -- compatible : should be "pwm-leds".
> > -
> > -Each LED is represented as a sub-node of the pwm-leds device. Each
> > -node's name represents the name of the corresponding LED.
> > -
> > -LED sub-node properties:
> > -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to
> > - specify the period time to be used: <&phandle id period_ns>;
> > -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device
> > - For the pwms and pwm-names property please refer to:
> > - Documentation/devicetree/bindings/pwm/pwm.txt
> > -- max-brightness : Maximum brightness possible for the LED
> > -- active-low : (optional) For PWMs where the LED is wired to supply
> > - rather than ground.
> > -- label : (optional)
> > - see Documentation/devicetree/bindings/leds/common.txt
> > -- linux,default-trigger : (optional)
> > - see Documentation/devicetree/bindings/leds/common.txt
> > -
> > -Example:
> > -
> > -twl_pwm: pwm {
> > - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
> > - compatible = "ti,twl6030-pwm";
> > - #pwm-cells = <2>;
> > -};
> > -
> > -twl_pwmled: pwmled {
> > - /* provides one PWM (id 0 for Charing indicator LED) */
> > - compatible = "ti,twl6030-pwmled";
> > - #pwm-cells = <2>;
> > -};
> > -
> > -pwmleds {
> > - compatible = "pwm-leds";
> > - kpad {
> > - label = "omap4::keypad";
> > - pwms = <&twl_pwm 0 7812500>;
> > - max-brightness = <127>;
> > - };
> > -
> > - charging {
> > - label = "omap4:green:chrg";
> > - pwms = <&twl_pwmled 0 7812500>;
> > - max-brightness = <255>;
> > - };
> > -};
> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > new file mode 100644
> > index 000000000000..fe4d5fd25913
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LEDs connected to PWM
> > +
> > +maintainers:
> > + - Pavel Machek <pavel@ucw.cz>
> > +
> > +description:
> > + Each LED is represented as a sub-node of the pwm-leds device. Each
> > + node's name represents the name of the corresponding LED.
> > +
> > +properties:
> > + compatible:
> > + const: pwm-leds
> > +
> > +patternProperties:
> > + "^led(-[0-9a-f]+)?$":
> > + type: object
> > +
> > + $ref: common.yaml#
> > +
> > + properties:
> > + pwms:
> > + maxItems: 1
> > +
> > + pwm-names: true
> > +
> > + max-brightness:
> > + description:
> > + Maximum brightness possible for the LED
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + active-low:
> > + description:
> > + For PWMs where the LED is wired to supply rather than ground.
> > + type: boolean
> > +
> > + required:
> > + - pwms
> > + - max-brightness
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +
> > + #include <dt-bindings/leds/common.h>
> > +
> > + led-controller {
> > + compatible = "pwm-leds";
> > +
> > + led-1 {
> > + label = "omap4::keypad";
> > + pwms = <&twl_pwm 0 7812500>;
> > + max-brightness = <127>;
> > + };
> > +
> > + led-2 {
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_CHARGING;
> > + pwms = <&twl_pwmled 0 7812500>;
> > + max-brightness = <255>;
> > + };
> > + };
> > +
> > +...
> > --
> > 2.20.1
>
> --
> /"\ ASCII RIBBON | »With the first link, the chain is forged. The first
> \ / CAMPAIGN | speech censured, the first thought forbidden, the
> X AGAINST | first freedom denied, chains us all irrevocably.«
> / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-07 10:02 ` Pavel Machek
2020-10-28 20:39 ` Alexander Dahl
@ 2020-11-25 11:08 ` Pavel Machek
2 siblings, 0 replies; 38+ messages in thread
From: Pavel Machek @ 2020-11-25 11:08 UTC (permalink / raw)
To: Alexander Dahl
Cc: Dan Murphy, Rob Herring, Alexander Dahl, Jacek Anaszewski,
linux-leds, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, linux-omap, linux-stm32, linux-amlogic,
linux-mips, Krzysztof Kozlowski, Rob Herring, Peter Ujfalusi,
Russell King
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Mon 2020-10-05 22:34:41, Alexander Dahl wrote:
> The example was adapted in the following ways:
>
> - make use of the now supported 'function' and 'color' properties
> - remove pwm nodes, those are documented elsewhere
> - align node names to new dt schema rules and dt recommendations
>
> License was not explicitly set before. The license set now is
> recommended by DT project.
Thanks, applied.
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-06 2:17 ` Jeff LaBundy
` (2 more replies)
2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
` (9 subsequent siblings)
12 siblings, 3 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips, Lee Jones,
Jeff LaBundy
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
/home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* added warning message to commit message (Krzysztof Kozlowski)
v6:
* added this patch to series
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
index 541b06d80e73..92dc48a8dfa7 100644
--- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
+++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
@@ -90,10 +90,11 @@ examples:
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- panel {
+ led-1 {
+ label = "panel";
pwms = <&iqs620a_pwm 0 1000000>;
max-brightness = <255>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
@ 2020-10-06 2:17 ` Jeff LaBundy
2020-10-06 6:34 ` Alexander Dahl
2020-10-06 22:28 ` Rob Herring
2020-10-07 10:03 ` Pavel Machek
2 siblings, 1 reply; 38+ messages in thread
From: Jeff LaBundy @ 2020-10-06 2:17 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Lee Jones
Hi Alexander,
On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v6 -> v7:
> * added warning message to commit message (Krzysztof Kozlowski)
>
> v6:
> * added this patch to series
>
> Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> index 541b06d80e73..92dc48a8dfa7 100644
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -90,10 +90,11 @@ examples:
> };
> };
>
> - pwmleds {
> + led-controller {
> compatible = "pwm-leds";
>
> - panel {
> + led-1 {
> + label = "panel";
> pwms = <&iqs620a_pwm 0 1000000>;
> max-brightness = <255>;
> };
> --
> 2.20.1
>
I like the consistency this brings. My only feedback is that in the other
examples I found (common.yaml and leds-gpio.yaml), the children count off
from 0 (e.g. led-0) instead of 1 as your series appears to.
That's not a huge deal; it simply seems more consistent to count from the
first index allowed by the regex (0). The patch is still fine, and so:
Acked-by: Jeff LaBundy <jeff@labundy.com>
Kind regards,
Jeff LaBundy
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-06 2:17 ` Jeff LaBundy
@ 2020-10-06 6:34 ` Alexander Dahl
2020-10-06 22:27 ` Rob Herring
0 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-06 6:34 UTC (permalink / raw)
To: Jeff LaBundy
Cc: Alexander Dahl, Pavel Machek, Dan Murphy, Rob Herring,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Lee Jones
Hello Jeff,
Am Dienstag, 6. Oktober 2020, 04:17:29 CEST schrieb Jeff LaBundy:
> Hi Alexander,
>
> On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> >
> > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.exampl
> > e.dt.yaml: pwmleds: 'panel' does not match any of the regexes:
> > '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'>
> > From schema:
> > /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/
> > leds-pwm.yaml>
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > ---
> >
> > Notes:
> > v6 -> v7:
> > * added warning message to commit message (Krzysztof Kozlowski)
> >
> > v6:
> > * added this patch to series
> >
> > Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > b/Documentation/devicetree/bindings/mfd/iqs62x.yaml index
> > 541b06d80e73..92dc48a8dfa7 100644
> > --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> >
> > @@ -90,10 +90,11 @@ examples:
> > };
> >
> > };
> >
> > - pwmleds {
> > + led-controller {
> >
> > compatible = "pwm-leds";
> >
> > - panel {
> > + led-1 {
> > + label = "panel";
> >
> > pwms = <&iqs620a_pwm 0 1000000>;
> > max-brightness = <255>;
> >
> > };
>
> I like the consistency this brings. My only feedback is that in the other
> examples I found (common.yaml and leds-gpio.yaml), the children count off
> from 0 (e.g. led-0) instead of 1 as your series appears to.
You're right. And that's also the same in leds-lp50xx.yaml and … well I did
not look close enough, maybe the numbering scheme on the PCB on my desk
confused me.
Okay, we are already talking about starting index. What about the parent
node's "led-controller" then in case there are more than one? IIRC Rob
acknowledged starting from 1 like "led-controller-1", "led-controller-2" and
so on.
> That's not a huge deal; it simply seems more consistent to count from the
> first index allowed by the regex (0). The patch is still fine, and so:
>
> Acked-by: Jeff LaBundy <jeff@labundy.com>
Thanks.
I'm not sure how many more iterations of this series we will need, at least
one for the binding license acks I guess, so I could also adapt the child node
indexes in schema and actual dts files in v8 or so.
Greets
Alex
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-06 6:34 ` Alexander Dahl
@ 2020-10-06 22:27 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2020-10-06 22:27 UTC (permalink / raw)
To: Alexander Dahl
Cc: Jeff LaBundy, Alexander Dahl, Pavel Machek, Dan Murphy,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Lee Jones
On Tue, Oct 06, 2020 at 08:34:23AM +0200, Alexander Dahl wrote:
> Hello Jeff,
>
> Am Dienstag, 6. Oktober 2020, 04:17:29 CEST schrieb Jeff LaBundy:
> > Hi Alexander,
> >
> > On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> > > The node names for devices using the pwm-leds driver follow a certain
> > > naming scheme (now). Parent node name is not enforced, but recommended
> > > by DT project.
> > >
> > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > >
> > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.exampl
> > > e.dt.yaml: pwmleds: 'panel' does not match any of the regexes:
> > > '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'>
> > > From schema:
> > > /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/
> > > leds-pwm.yaml>
> > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > > ---
> > >
> > > Notes:
> > > v6 -> v7:
> > > * added warning message to commit message (Krzysztof Kozlowski)
> > >
> > > v6:
> > > * added this patch to series
> > >
> > > Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > > b/Documentation/devicetree/bindings/mfd/iqs62x.yaml index
> > > 541b06d80e73..92dc48a8dfa7 100644
> > > --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > >
> > > @@ -90,10 +90,11 @@ examples:
> > > };
> > >
> > > };
> > >
> > > - pwmleds {
> > > + led-controller {
> > >
> > > compatible = "pwm-leds";
> > >
> > > - panel {
> > > + led-1 {
> > > + label = "panel";
> > >
> > > pwms = <&iqs620a_pwm 0 1000000>;
> > > max-brightness = <255>;
> > >
> > > };
> >
> > I like the consistency this brings. My only feedback is that in the other
> > examples I found (common.yaml and leds-gpio.yaml), the children count off
> > from 0 (e.g. led-0) instead of 1 as your series appears to.
>
> You're right. And that's also the same in leds-lp50xx.yaml and … well I did
> not look close enough, maybe the numbering scheme on the PCB on my desk
> confused me.
If you can tie the numbering to the PCB, then do that.
> Okay, we are already talking about starting index. What about the parent
> node's "led-controller" then in case there are more than one? IIRC Rob
> acknowledged starting from 1 like "led-controller-1", "led-controller-2" and
> so on.
No, I'd assume we start at 0.
> > That's not a huge deal; it simply seems more consistent to count from the
> > first index allowed by the regex (0). The patch is still fine, and so:
> >
> > Acked-by: Jeff LaBundy <jeff@labundy.com>
>
> Thanks.
>
> I'm not sure how many more iterations of this series we will need, at least
> one for the binding license acks I guess, so I could also adapt the child node
> indexes in schema and actual dts files in v8 or so.
>
> Greets
> Alex
>
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-06 2:17 ` Jeff LaBundy
@ 2020-10-06 22:28 ` Rob Herring
2020-10-07 10:03 ` Pavel Machek
2 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2020-10-06 22:28 UTC (permalink / raw)
To: Alexander Dahl
Cc: Dan Murphy, Jeff LaBundy, Pavel Machek, linux-stm32,
Alexander Dahl, linux-mips, linux-omap, Rob Herring,
Jacek Anaszewski, Lee Jones, linux-leds, linux-samsung-soc,
linux-kernel, linux-amlogic, devicetree, linux-arm-kernel
On Mon, 05 Oct 2020 22:34:42 +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v6 -> v7:
> * added warning message to commit message (Krzysztof Kozlowski)
>
> v6:
> * added this patch to series
>
> Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-06 2:17 ` Jeff LaBundy
2020-10-06 22:28 ` Rob Herring
@ 2020-10-07 10:03 ` Pavel Machek
2020-10-07 10:08 ` Alexander Dahl
2020-10-08 7:33 ` Lee Jones
2 siblings, 2 replies; 38+ messages in thread
From: Pavel Machek @ 2020-10-07 10:03 UTC (permalink / raw)
To: Alexander Dahl
Cc: Dan Murphy, Rob Herring, Alexander Dahl, Jacek Anaszewski,
linux-leds, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, linux-omap, linux-stm32, linux-amlogic,
linux-mips, Lee Jones, Jeff LaBundy
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
Hi!
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
Okay, so I need Rob's ack here, I guess... and rest of the series is
not really for my tree.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-07 10:03 ` Pavel Machek
@ 2020-10-07 10:08 ` Alexander Dahl
2020-10-08 7:33 ` Lee Jones
1 sibling, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-07 10:08 UTC (permalink / raw)
To: Pavel Machek
Cc: Alexander Dahl, Dan Murphy, Rob Herring, Jacek Anaszewski,
linux-leds, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, linux-omap, linux-stm32, linux-amlogic,
linux-mips, Lee Jones, Jeff LaBundy
Hei Pavel,
Am Mittwoch, 7. Oktober 2020, 12:03:59 CEST schrieb Pavel Machek:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> >
> > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.exampl
> > e.dt.yaml: pwmleds: 'panel' does not match any of the regexes:
> > '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'>
> > From schema:
> > /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/
> > leds-pwm.yaml>
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
>
> Okay, so I need Rob's ack here, I guess... and rest of the series is
> not really for my tree.
I think so, too.
I saw you applied patch number 1, all the other patches are DT and from my
side those can wait for the Acks required and maybe I change the indexes again
and I'm fine resending all that after the 5.10 merge window.
Thanks for applying the non-DT patches for leds subsystem, the rest will be
sorted out without hurry.
Greets
Alex
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-07 10:03 ` Pavel Machek
2020-10-07 10:08 ` Alexander Dahl
@ 2020-10-08 7:33 ` Lee Jones
2020-10-08 7:50 ` Pavel Machek
1 sibling, 1 reply; 38+ messages in thread
From: Lee Jones @ 2020-10-08 7:33 UTC (permalink / raw)
To: Pavel Machek
Cc: Alexander Dahl, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Jeff LaBundy
On Wed, 07 Oct 2020, Pavel Machek wrote:
> Hi!
>
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
>
> Okay, so I need Rob's ack here, I guess... and rest of the series is
> not really for my tree.
This patch is not for your tree either. ;)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-10-08 7:33 ` Lee Jones
@ 2020-10-08 7:50 ` Pavel Machek
0 siblings, 0 replies; 38+ messages in thread
From: Pavel Machek @ 2020-10-08 7:50 UTC (permalink / raw)
To: Lee Jones
Cc: Alexander Dahl, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Jeff LaBundy
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hi!
> > > The node names for devices using the pwm-leds driver follow a certain
> > > naming scheme (now). Parent node name is not enforced, but recommended
> > > by DT project.
> > >
> > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > >
> > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> >
> > Okay, so I need Rob's ack here, I guess... and rest of the series is
> > not really for my tree.
>
> This patch is not for your tree either. ;)
Ah, right. Usually we have one patch series for one maintainer...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (2 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl
` (8 subsequent siblings)
12 siblings, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches
Do it the simple way like for the other kizbox boards. This will allow
renaming the led controller node name later without breaking things.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* (no changes on this patch)
v6:
* added this patch to series
arch/arm/boot/dts/at91-smartkiz.dts | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/at91-smartkiz.dts b/arch/arm/boot/dts/at91-smartkiz.dts
index 106f23ba4a3b..b76a6b5ac464 100644
--- a/arch/arm/boot/dts/at91-smartkiz.dts
+++ b/arch/arm/boot/dts/at91-smartkiz.dts
@@ -84,10 +84,8 @@
status = "okay";
};
-&leds {
- blue {
- status = "okay";
- };
+&led_blue {
+ status = "okay";
};
&adc0 {
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (3 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl
` (7 subsequent siblings)
12 siblings, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Nicolas Ferre, Alexandre Belloni, Ludovic Desroches
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/at91-kizbox2-2.dt.yaml
CHECK arch/arm/boot/dts/at91-kizbox2-2.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/at91-kizbox2-2.dt.yaml: pwm_leds: 'blue', 'green', 'red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml
CHECK arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml: pwm_leds: 'blue', 'green', 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
(Warnings above are for armv7 only, armv5 would produce similar warnings.)
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/at91-kizbox.dts | 10 +++++-----
arch/arm/boot/dts/at91-kizbox2-common.dtsi | 8 ++++----
arch/arm/boot/dts/at91-kizbox3-hs.dts | 16 ++++++++--------
arch/arm/boot/dts/at91-kizbox3_common.dtsi | 10 +++++-----
arch/arm/boot/dts/at91-kizboxmini-common.dtsi | 8 ++++----
arch/arm/boot/dts/at91sam9m10g45ek.dts | 10 +++++-----
arch/arm/boot/dts/at91sam9rlek.dts | 10 +++++-----
7 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/arch/arm/boot/dts/at91-kizbox.dts b/arch/arm/boot/dts/at91-kizbox.dts
index 7d938ccf71b0..6ea5e60d881d 100644
--- a/arch/arm/boot/dts/at91-kizbox.dts
+++ b/arch/arm/boot/dts/at91-kizbox.dts
@@ -48,31 +48,31 @@
};
};
- pwm_leds {
+ led-controller {
compatible = "pwm-leds";
- network_green {
+ led-1 {
label = "pwm:green:network";
pwms = <&tcb_pwm 2 10000000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- network_red {
+ led-2 {
label = "pwm:red:network";
pwms = <&tcb_pwm 4 10000000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- user_green {
+ led-3 {
label = "pwm:green:user";
pwms = <&tcb_pwm 0 10000000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- user_red {
+ led-4 {
label = "pwm:red:user";
pwms = <&tcb_pwm 1 10000000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
diff --git a/arch/arm/boot/dts/at91-kizbox2-common.dtsi b/arch/arm/boot/dts/at91-kizbox2-common.dtsi
index af38253a6e7a..8dc880c6b9d0 100644
--- a/arch/arm/boot/dts/at91-kizbox2-common.dtsi
+++ b/arch/arm/boot/dts/at91-kizbox2-common.dtsi
@@ -58,24 +58,24 @@
};
};
- pwm_leds {
+ led-controller {
compatible = "pwm-leds";
- blue {
+ led-1 {
label = "pwm:blue:user";
pwms = <&pwm0 2 10000000 0>;
max-brightness = <255>;
linux,default-trigger = "none";
};
- green {
+ led-2 {
label = "pwm:green:user";
pwms = <&pwm0 1 10000000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-3 {
label = "pwm:red:user";
pwms = <&pwm0 0 10000000 0>;
max-brightness = <255>;
diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts
index 0da1f0557eaf..2799b2a1f4d2 100644
--- a/arch/arm/boot/dts/at91-kizbox3-hs.dts
+++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts
@@ -15,40 +15,40 @@
model = "Overkiz KIZBOX3-HS";
compatible = "overkiz,kizbox3-hs", "atmel,sama5d2", "atmel,sama5";
- pwm_leds {
+ led-controller-1 {
status = "okay";
- red {
+ led-1 {
status = "okay";
};
- green {
+ led-2 {
status = "okay";
};
- blue {
+ led-3 {
status = "okay";
};
- white {
+ led-4 {
status = "okay";
};
};
- leds {
+ led-controller-2 {
compatible = "gpio-leds";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_led_red
&pinctrl_led_white>;
status = "okay";
- red {
+ led-5 {
label = "pio:red:user";
gpios = <&pioA PIN_PB1 GPIO_ACTIVE_HIGH>;
default-state = "off";
};
- white {
+ led-6 {
label = "pio:white:user";
gpios = <&pioA PIN_PB8 GPIO_ACTIVE_HIGH>;
default-state = "off";
diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
index 7c3076e245ef..9ce513dd514b 100644
--- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi
+++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi
@@ -62,7 +62,7 @@
regulator-always-on;
};
- pwm_leds {
+ led-controller-1 {
compatible = "pwm-leds";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pwm0_pwm_h0
@@ -71,7 +71,7 @@
&pinctrl_pwm0_pwm_h3>;
status = "disabled";
- red {
+ led-1 {
label = "pwm:red:user";
pwms = <&pwm0 0 10000000 0>;
max-brightness = <255>;
@@ -79,7 +79,7 @@
status = "disabled";
};
- green {
+ led-2 {
label = "pwm:green:user";
pwms = <&pwm0 1 10000000 0>;
max-brightness = <255>;
@@ -87,14 +87,14 @@
status = "disabled";
};
- blue {
+ led-3 {
label = "pwm:blue:user";
pwms = <&pwm0 2 10000000 0>;
max-brightness = <255>;
status = "disabled";
};
- white {
+ led-4 {
label = "pwm:white:user";
pwms = <&pwm0 3 10000000 0>;
max-brightness = <255>;
diff --git a/arch/arm/boot/dts/at91-kizboxmini-common.dtsi b/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
index fddf267b2d17..5892f20f7b16 100644
--- a/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
+++ b/arch/arm/boot/dts/at91-kizboxmini-common.dtsi
@@ -54,10 +54,10 @@
};
};
- leds: pwm_leds {
+ leds: led-controller-1 {
compatible = "pwm-leds";
- led_blue: pwm_blue {
+ led_blue: led-1 {
label = "pwm:blue:user";
pwms = <&pwm0 2 10000000 0>;
max-brightness = <255>;
@@ -65,14 +65,14 @@
status = "disabled";
};
- led_green: pwm_green {
+ led_green: led-2 {
label = "pwm:green:user";
pwms = <&pwm0 0 10000000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- led_red: pwm_red {
+ led_red: led-3 {
label = "pwm:red:user";
pwms = <&pwm0 1 10000000 0>;
max-brightness = <255>;
diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts
index a3a5c82d9f29..c50706b653d0 100644
--- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
+++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
@@ -313,27 +313,27 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- d8 {
+ led-1 {
label = "d8";
gpios = <&pioD 30 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- d6 {
+ led-2 {
label = "d6";
pwms = <&pwm0 3 5000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
linux,default-trigger = "nand-disk";
};
- d7 {
+ led-3 {
label = "d7";
pwms = <&pwm0 1 5000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
diff --git a/arch/arm/boot/dts/at91sam9rlek.dts b/arch/arm/boot/dts/at91sam9rlek.dts
index 0de75d3c4f18..035ce5dedff7 100644
--- a/arch/arm/boot/dts/at91sam9rlek.dts
+++ b/arch/arm/boot/dts/at91sam9rlek.dts
@@ -218,26 +218,26 @@
};
};
- pwmleds {
+ led-controller-1 {
compatible = "pwm-leds";
- ds1 {
+ led-1 {
label = "ds1";
pwms = <&pwm0 1 5000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
};
- ds2 {
+ led-2 {
label = "ds2";
pwms = <&pwm0 2 5000 PWM_POLARITY_INVERTED>;
max-brightness = <255>;
};
};
- leds {
+ led-controller-2 {
compatible = "gpio-leds";
- ds3 {
+ led-3 {
label = "ds3";
gpios = <&pioD 14 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH v7 06/12] ARM: dts: berlin: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (4 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
` (6 subsequent siblings)
12 siblings, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Jisheng Zhang, Sebastian Hesselbarth
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 56fa951bc86f..c1d91424e658 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -34,19 +34,19 @@
linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
};
- leds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-0 = <&ledpwm_pmux>;
pinctrl-names = "default";
- white {
+ led-1 {
label = "white";
pwms = <&pwm 0 600000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-2 {
label = "red";
pwms = <&pwm 1 600000 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH v7 07/12] ARM: dts: exynos: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (5 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-07 6:25 ` Krzysztof Kozlowski
2020-10-26 18:45 ` Krzysztof Kozlowski
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
` (5 subsequent siblings)
12 siblings, 2 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips, Kukjin Kim,
Krzysztof Kozlowski
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml
CHECK arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml
CHECK arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml
CHECK arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml
CHECK arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/exynos5422-odroidhc1.dts | 4 ++--
arch/arm/boot/dts/exynos5422-odroidxu4.dts | 4 ++--
arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 11 ++++++-----
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidhc1.dts b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
index 812659260278..20c222b33f98 100644
--- a/arch/arm/boot/dts/exynos5422-odroidhc1.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidhc1.dts
@@ -15,10 +15,10 @@
compatible = "hardkernel,odroid-hc1", "samsung,exynos5800", \
"samsung,exynos5";
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- blueled {
+ led-1 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
index 892d389d6d09..955065ee57a0 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
@@ -17,10 +17,10 @@
compatible = "hardkernel,odroid-xu4", "samsung,exynos5800", \
"samsung,exynos5";
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- blueled {
+ led-1 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
diff --git a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
index 56acd832f0b3..2fc3e86dc5f7 100644
--- a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
+++ b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
@@ -11,10 +11,10 @@
#include <dt-bindings/gpio/gpio.h>
/ {
- pwmleds {
+ led-controller-1 {
compatible = "pwm-leds";
- greenled {
+ led-1 {
label = "green:mmc0";
pwms = <&pwm 1 2000000 0>;
pwm-names = "pwm1";
@@ -26,7 +26,7 @@
linux,default-trigger = "mmc0";
};
- blueled {
+ led-2 {
label = "blue:heartbeat";
pwms = <&pwm 2 2000000 0>;
pwm-names = "pwm2";
@@ -35,9 +35,10 @@
};
};
- gpioleds {
+ led-controller-2 {
compatible = "gpio-leds";
- redled {
+
+ led-3 {
label = "red:microSD";
gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
default-state = "off";
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 07/12] ARM: dts: exynos: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
@ 2020-10-07 6:25 ` Krzysztof Kozlowski
2020-10-26 18:45 ` Krzysztof Kozlowski
1 sibling, 0 replies; 38+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-07 6:25 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Kukjin Kim
On Mon, 5 Oct 2020 at 22:36, Alexander Dahl <post@lespocky.de> wrote:
>
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
> CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml
> CHECK arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml
> CHECK arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml
> CHECK arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml
> CHECK arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/exynos5422-odroidhc1.dts | 4 ++--
> arch/arm/boot/dts/exynos5422-odroidxu4.dts | 4 ++--
> arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 11 ++++++-----
> 3 files changed, 10 insertions(+), 9 deletions(-)
Looks OK but it is too late for this cycle. I'll pick it up after merge window.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v7 07/12] ARM: dts: exynos: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
2020-10-07 6:25 ` Krzysztof Kozlowski
@ 2020-10-26 18:45 ` Krzysztof Kozlowski
1 sibling, 0 replies; 38+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-26 18:45 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Kukjin Kim
On Mon, Oct 05, 2020 at 10:34:46PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
> CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Please trim the error logs in the future. No need to paste all warnings,
just one or two from the same type of error. Also your local path
leading to Linux repo should be removed.
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 08/12] ARM: dts: imx: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (6 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-30 7:46 ` Shawn Guo
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
` (4 subsequent siblings)
12 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Russell King
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/imx53-ppd.dt.yaml
CHECK arch/arm/boot/dts/imx53-ppd.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx53-ppd.dt.yaml: leds-brightness: 'alarm-brightness' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
CHECK arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
CHECK arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
CHECK arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
CHECK arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml: pwmleds: 'blue', 'green', 'red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/imx53-ppd.dts | 15 ++++++++-------
arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 4 ++--
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 8 ++++----
3 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
index f7dcdf96e5c0..b480614efb30 100644
--- a/arch/arm/boot/dts/imx53-ppd.dts
+++ b/arch/arm/boot/dts/imx53-ppd.dts
@@ -176,36 +176,37 @@
power-supply = <®_3v3_lcd>;
};
- leds-brightness {
+ led-controller-1 {
compatible = "pwm-leds";
- alarm-brightness {
+ led-1 {
+ label = "alarm-brightness";
pwms = <&pwm1 0 100000>;
max-brightness = <255>;
};
};
- leds {
+ led-controller-2 {
compatible = "gpio-leds";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_alarmled_pins>;
- alarm1 {
+ led-2 {
label = "alarm:red";
gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>;
};
- alarm2 {
+ led-3 {
label = "alarm:yellow";
gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>;
};
- alarm3 {
+ led-4 {
label = "alarm:blue";
gpios = <&gpio7 8 GPIO_ACTIVE_HIGH>;
};
- alarm4 {
+ led-5 {
label = "alarm:silenced";
gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
};
diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 67042793b0ca..1e530d892b76 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -55,12 +55,12 @@
pinctrl-0 = <&pinctrl_cubox_i_ir>;
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_cubox_i_pwm1>;
- front {
+ led-1 {
active-low;
label = "imx6:red:front";
max-brightness = <248>;
diff --git a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
index d25e27d0315f..83bff1a129ec 100644
--- a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
+++ b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
@@ -40,22 +40,22 @@
regulator-max-microvolt = <3300000>;
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- red {
+ led-1 {
label = "red";
max-brightness = <255>;
pwms = <&pwm6 0 50000>;
};
- green {
+ led-2 {
label = "green";
max-brightness = <255>;
pwms = <&pwm2 0 50000>;
};
- blue {
+ led-3 {
label = "blue";
max-brightness = <255>;
pwms = <&pwm1 0 50000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 08/12] ARM: dts: imx: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
@ 2020-10-30 7:46 ` Shawn Guo
0 siblings, 0 replies; 38+ messages in thread
From: Shawn Guo @ 2020-10-30 7:46 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Russell King
On Mon, Oct 05, 2020 at 10:34:47PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/imx53-ppd.dt.yaml
> CHECK arch/arm/boot/dts/imx53-ppd.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/imx53-ppd.dt.yaml: leds-brightness: 'alarm-brightness' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
> CHECK arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
> CHECK arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
> CHECK arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml: pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> DTC arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
> CHECK arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml: pwmleds: 'blue', 'green', 'red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 09/12] ARM: dts: omap: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (7 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-11-10 13:25 ` Tony Lindgren
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
` (3 subsequent siblings)
12 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Benoît Cousson, Tony Lindgren
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/omap3-beagle-xm.dt.yaml
CHECK arch/arm/boot/dts/omap3-beagle-xm.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-beagle-xm.dt.yaml: pwmleds: 'pmu_stat' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-beagle-xm-ab.dt.yaml
CHECK arch/arm/boot/dts/omap3-beagle-xm-ab.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-beagle-xm-ab.dt.yaml: pwmleds: 'pmu_stat' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-alto35.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-alto35.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-alto35.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-chestnut43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-chestnut43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-chestnut43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-gallop43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-gallop43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-gallop43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-palo35.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-palo35.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-palo35.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-palo43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-palo43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-palo43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-alto35.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-alto35.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-alto35.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-chestnut43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-chestnut43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-chestnut43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-gallop43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-gallop43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-gallop43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-palo35.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-palo35.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-palo35.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-palo43.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-palo43.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-palo43.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-summit.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-summit.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-summit.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-tobi.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-tobi.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-tobi.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-storm-tobiduo.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-storm-tobiduo.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-storm-tobiduo.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-summit.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-summit.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-summit.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-tobi.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-tobi.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-tobi.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap3-overo-tobiduo.dt.yaml
CHECK arch/arm/boot/dts/omap3-overo-tobiduo.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap3-overo-tobiduo.dt.yaml: pwmleds: 'overo' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap4-kc1.dt.yaml
CHECK arch/arm/boot/dts/omap4-kc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap4-kc1.dt.yaml: pwmleds: 'green', 'orange' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap4-sdp.dt.yaml
CHECK arch/arm/boot/dts/omap4-sdp.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap4-sdp.dt.yaml: pwmleds: 'charging', 'kpad' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
DTC arch/arm/boot/dts/omap4-sdp-es23plus.dt.yaml
CHECK arch/arm/boot/dts/omap4-sdp-es23plus.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/omap4-sdp-es23plus.dt.yaml: pwmleds: 'charging', 'kpad' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/omap3-beagle-xm.dts | 10 +++++-----
arch/arm/boot/dts/omap3-overo-base.dtsi | 4 ++--
arch/arm/boot/dts/omap4-kc1.dts | 6 +++---
arch/arm/boot/dts/omap4-sdp.dts | 26 +++++++++++++------------
4 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index 05077f3c75cd..cbeab697b89f 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -34,26 +34,26 @@
clock-frequency = <26000000>;
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- heartbeat {
+ led-1 {
label = "beagleboard::usr0";
gpios = <&gpio5 22 GPIO_ACTIVE_HIGH>; /* 150 -> D6 LED */
linux,default-trigger = "heartbeat";
};
- mmc {
+ led-2 {
label = "beagleboard::usr1";
gpios = <&gpio5 21 GPIO_ACTIVE_HIGH>; /* 149 -> D7 LED */
linux,default-trigger = "mmc0";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- pmu_stat {
+ led-3 {
label = "beagleboard::pmu_stat";
pwms = <&twl_pwmled 1 7812500>;
max-brightness = <127>;
diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi
index 971d3e250515..006a6d97231c 100644
--- a/arch/arm/boot/dts/omap3-overo-base.dtsi
+++ b/arch/arm/boot/dts/omap3-overo-base.dtsi
@@ -14,10 +14,10 @@
reg = <0 0>;
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- overo {
+ led-1 {
label = "overo:blue:COM";
pwms = <&twl_pwmled 1 7812500>;
max-brightness = <127>;
diff --git a/arch/arm/boot/dts/omap4-kc1.dts b/arch/arm/boot/dts/omap4-kc1.dts
index 31d856b58f8a..e59d17b25a1d 100644
--- a/arch/arm/boot/dts/omap4-kc1.dts
+++ b/arch/arm/boot/dts/omap4-kc1.dts
@@ -15,16 +15,16 @@
reg = <0x80000000 0x20000000>; /* 512 MB */
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- green {
+ led-1 {
label = "green";
pwms = <&twl_pwm 0 7812500>;
max-brightness = <127>;
};
- orange {
+ led-2 {
label = "orange";
pwms = <&twl_pwm 1 7812500>;
max-brightness = <127>;
diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts
index 79e7a41ecb7e..f5d7539a3668 100644
--- a/arch/arm/boot/dts/omap4-sdp.dts
+++ b/arch/arm/boot/dts/omap4-sdp.dts
@@ -45,58 +45,60 @@
regulator-boot-on;
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- debug0 {
+
+ led-1 {
label = "omap4:green:debug0";
gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>; /* 61 */
};
- debug1 {
+ led-2 {
label = "omap4:green:debug1";
gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>; /* 30 */
};
- debug2 {
+ led-3 {
label = "omap4:green:debug2";
gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>; /* 7 */
};
- debug3 {
+ led-4 {
label = "omap4:green:debug3";
gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; /* 8 */
};
- debug4 {
+ led-5 {
label = "omap4:green:debug4";
gpios = <&gpio2 18 GPIO_ACTIVE_HIGH>; /* 50 */
};
- user1 {
+ led-6 {
label = "omap4:blue:user";
gpios = <&gpio6 9 GPIO_ACTIVE_HIGH>; /* 169 */
};
- user2 {
+ led-7 {
label = "omap4:red:user";
gpios = <&gpio6 10 GPIO_ACTIVE_HIGH>; /* 170 */
};
- user3 {
+ led-8 {
label = "omap4:green:user";
gpios = <&gpio5 11 GPIO_ACTIVE_HIGH>; /* 139 */
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- kpad {
+
+ led-9 {
label = "omap4::keypad";
pwms = <&twl_pwm 0 7812500>;
max-brightness = <127>;
};
- charging {
+ led-10 {
label = "omap4:green:chrg";
pwms = <&twl_pwmled 0 7812500>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 09/12] ARM: dts: omap: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
@ 2020-11-10 13:25 ` Tony Lindgren
0 siblings, 0 replies; 38+ messages in thread
From: Tony Lindgren @ 2020-11-10 13:25 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, Alexander Dahl,
Jacek Anaszewski, linux-leds, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc, linux-omap, linux-stm32,
linux-amlogic, linux-mips, Benoît Cousson
* Alexander Dahl <post@lespocky.de> [201005 23:36]:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
Applying into omap-for-v5.11/dt thanks.
Tony
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (8 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-27 7:03 ` [Linux-stm32] " Ahmad Fatoum
2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl
` (2 subsequent siblings)
12 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Maxime Coquelin, Alexandre Torgue
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 5700e6b700d3..25d548cb975b 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,34 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-1 {
compatible = "gpio-leds";
- led-green {
+ led-1 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-2 {
compatible = "pwm-leds";
- led-red {
+ led-2 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-3 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-4 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
@ 2020-10-27 7:03 ` Ahmad Fatoum
2020-10-27 10:05 ` Alexander Dahl
0 siblings, 1 reply; 38+ messages in thread
From: Ahmad Fatoum @ 2020-10-27 7:03 UTC (permalink / raw)
To: Alexander Dahl, Pavel Machek, Dan Murphy, Rob Herring
Cc: linux-arm-kernel, devicetree, linux-samsung-soc, Alexander Dahl,
linux-kernel, linux-mips, Jacek Anaszewski, Maxime Coquelin,
linux-amlogic, linux-omap, linux-stm32, linux-leds
Hello Alexander,
On 10/5/20 10:34 PM, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
But got two questions below:
> ---
>
> Notes:
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 5700e6b700d3..25d548cb975b 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,34 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-1 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-1 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-2 {
Is a single RGB LED really a controller?
> compatible = "pwm-leds";
>
> - led-red {
> + led-2 {
Shouldn't this have been led-1 as well or is the numbering "global" ?
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-3 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-4 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-27 7:03 ` [Linux-stm32] " Ahmad Fatoum
@ 2020-10-27 10:05 ` Alexander Dahl
2020-10-27 10:58 ` Ahmad Fatoum
0 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-27 10:05 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: Alexander Dahl, Pavel Machek, Dan Murphy, Rob Herring,
linux-arm-kernel, devicetree, linux-samsung-soc, Alexander Dahl,
linux-kernel, linux-mips, Jacek Anaszewski, Maxime Coquelin,
linux-amlogic, linux-omap, linux-stm32, linux-leds
[-- Attachment #1: Type: text/plain, Size: 3392 bytes --]
Hello Ahmad,
thanks for your feedback, comments below.
On Tue, Oct 27, 2020 at 08:03:40AM +0100, Ahmad Fatoum wrote:
> Hello Alexander,
>
> On 10/5/20 10:34 PM, Alexander Dahl wrote:
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> > CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> > /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
>
> Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> But got two questions below:
>
> > ---
> >
> > Notes:
> > v6 -> v7:
> > * split up patch (one per sub arch)
> > * added actual warnings to commit message
> >
> > arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> > index 5700e6b700d3..25d548cb975b 100644
> > --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> > +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> > @@ -36,34 +36,34 @@
> > stdout-path = &uart4;
> > };
> >
> > - led-act {
> > + led-controller-1 {
> > compatible = "gpio-leds";
> >
> > - led-green {
> > + led-1 {
> > label = "mc1:green:act";
> > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> > linux,default-trigger = "heartbeat";
> > };
> > };
> >
> > - led-rgb {
> > + led-controller-2 {
>
> Is a single RGB LED really a controller?
I just followed the recommendations by Rob here.
> > compatible = "pwm-leds";
> >
> > - led-red {
> > + led-2 {
>
> Shouldn't this have been led-1 as well or is the numbering "global" ?
Also good question. This numbering is for dts only, it usually does
not correspond with LEDs on the board, so it could be numbered per
led-controller as well?
Greets
Alex
>
> > label = "mc1:red:rgb";
> > pwms = <&leds_pwm 1 1000000 0>;
> > max-brightness = <255>;
> > active-low;
> > };
> >
> > - led-green {
> > + led-3 {
> > label = "mc1:green:rgb";
> > pwms = <&leds_pwm 2 1000000 0>;
> > max-brightness = <255>;
> > active-low;
> > };
> >
> > - led-blue {
> > + led-4 {
> > label = "mc1:blue:rgb";
> > pwms = <&leds_pwm 3 1000000 0>;
> > max-brightness = <255>;
> >
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-27 10:05 ` Alexander Dahl
@ 2020-10-27 10:58 ` Ahmad Fatoum
2020-10-28 7:34 ` Alexander Dahl
0 siblings, 1 reply; 38+ messages in thread
From: Ahmad Fatoum @ 2020-10-27 10:58 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring, linux-arm-kernel,
devicetree, linux-samsung-soc, Alexander Dahl, linux-kernel,
linux-mips, Jacek Anaszewski, Maxime Coquelin, linux-amlogic,
linux-omap, linux-stm32, linux-leds
Hello,
On 10/27/20 11:05 AM, Alexander Dahl wrote:
> Hello Ahmad,
>
> thanks for your feedback, comments below.
>
>>> - led-rgb {
>>> + led-controller-2 {
>>
>> Is a single RGB LED really a controller?
>
> I just followed the recommendations by Rob here.
Do you happen to know if the new multicolor LED support could be used here?
I find it unfortunate that the device tree loses information relevant to humans
to adhere to a fixed nomenclature. Apparently led-controller isn't even codified
in the YAML binding (It's just in the examples). If you respin, please add a
comment that this is a single RGB led. I'd prefer to keep the information
in the DTB as well though.
>
>>> compatible = "pwm-leds";
>>>
>>> - led-red {
>>> + led-2 {
>>
>> Shouldn't this have been led-1 as well or is the numbering "global" ?
>
> Also good question. This numbering is for dts only, it usually does
> not correspond with LEDs on the board, so it could be numbered per
> led-controller as well?
I'd prefer that it starts by 1. That way it's aligned with PWM channel
ID.
Thanks for fixing the dtschema warnings by the way!
Cheers,
Ahmad
>
> Greets
> Alex
>
>>
>>> label = "mc1:red:rgb";
>>> pwms = <&leds_pwm 1 1000000 0>;
>>> max-brightness = <255>;
>>> active-low;
>>> };
>>>
>>> - led-green {
>>> + led-3 {
>>> label = "mc1:green:rgb";
>>> pwms = <&leds_pwm 2 1000000 0>;
>>> max-brightness = <255>;
>>> active-low;
>>> };
>>>
>>> - led-blue {
>>> + led-4 {
>>> label = "mc1:blue:rgb";
>>> pwms = <&leds_pwm 3 1000000 0>;
>>> max-brightness = <255>;
>>>
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-27 10:58 ` Ahmad Fatoum
@ 2020-10-28 7:34 ` Alexander Dahl
2020-11-02 10:47 ` Ahmad Fatoum
0 siblings, 1 reply; 38+ messages in thread
From: Alexander Dahl @ 2020-10-28 7:34 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: Pavel Machek, Dan Murphy, Rob Herring, linux-arm-kernel,
devicetree, linux-samsung-soc, linux-kernel, linux-mips,
Jacek Anaszewski, Maxime Coquelin, linux-amlogic, linux-omap,
linux-stm32, linux-leds
Hello Ahmad,
Am Dienstag, 27. Oktober 2020, 11:58:10 CET schrieb Ahmad Fatoum:
> Hello,
>
> On 10/27/20 11:05 AM, Alexander Dahl wrote:
> > Hello Ahmad,
> >
> > thanks for your feedback, comments below.
> >
> >>> - led-rgb {
> >>> + led-controller-2 {
> >>
> >> Is a single RGB LED really a controller?
> >
> > I just followed the recommendations by Rob here.
>
> Do you happen to know if the new multicolor LED support could be used here?
AFAIK not yet. The multicolor class should be ready and it is used by some
drivers for I²C connected LED controllers, but if I understood Pavel
correctly, additional work has to be done for a gpio and/or pwm multicolor
driver. See this thread from August for example:
https://lore.kernel.org/linux-leds/2530787.iFCFyWWcSu@g550jk/
>
> I find it unfortunate that the device tree loses information relevant to
> humans to adhere to a fixed nomenclature. Apparently led-controller isn't
> even codified in the YAML binding (It's just in the examples). If you
> respin, please add a comment that this is a single RGB led. I'd prefer to
> keep the information in the DTB as well though.
The "new" attributes 'function' and 'color' attributes should cover this
information. IIRC those were introduced sometime before v5.4 and documentation
is in the leds/common.yaml binding. I don't see it in the scope of this patch
series, but if we would merge this warning fix first, the information is lost,
so maybe those attributes should be added before?
My heuristics on that would be looking at the label and if there's a distinct
color in it, add the color property. I could do that for all pwm LEDs known to
the tree currently. That would be a bigger task for GPIO leds though. ;-)
>
> >>> compatible = "pwm-leds";
> >>>
> >>> - led-red {
> >>> + led-2 {
> >>
> >> Shouldn't this have been led-1 as well or is the numbering "global" ?
> >
> > Also good question. This numbering is for dts only, it usually does
> > not correspond with LEDs on the board, so it could be numbered per
> > led-controller as well?
>
> I'd prefer that it starts by 1. That way it's aligned with PWM channel
> ID.
Ack.
>
> Thanks for fixing the dtschema warnings by the way!
Well, I "introduced" them by converting the leds-pwm binding to yaml (not
merged yet), so I could as well fix the warnings then? ;-)
Greets
Alex
>
> Cheers,
> Ahmad
>
> > Greets
> > Alex
> >
> >>> label = "mc1:red:rgb";
> >>> pwms = <&leds_pwm 1 1000000 0>;
> >>> max-brightness = <255>;
> >>> active-low;
> >>>
> >>> };
> >>>
> >>> - led-green {
> >>> + led-3 {
> >>>
> >>> label = "mc1:green:rgb";
> >>> pwms = <&leds_pwm 2 1000000 0>;
> >>> max-brightness = <255>;
> >>> active-low;
> >>>
> >>> };
> >>>
> >>> - led-blue {
> >>> + led-4 {
> >>>
> >>> label = "mc1:blue:rgb";
> >>> pwms = <&leds_pwm 3 1000000 0>;
> >>> max-brightness = <255>;
--
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-10-28 7:34 ` Alexander Dahl
@ 2020-11-02 10:47 ` Ahmad Fatoum
0 siblings, 0 replies; 38+ messages in thread
From: Ahmad Fatoum @ 2020-11-02 10:47 UTC (permalink / raw)
To: Alexander Dahl
Cc: Pavel Machek, Dan Murphy, Rob Herring, linux-arm-kernel,
devicetree, linux-samsung-soc, linux-kernel, linux-mips,
Jacek Anaszewski, Maxime Coquelin, linux-amlogic, linux-omap,
linux-stm32, linux-leds
Hello Alexander,
On 10/28/20 8:34 AM, Alexander Dahl wrote:
> Hello Ahmad,
>
> Am Dienstag, 27. Oktober 2020, 11:58:10 CET schrieb Ahmad Fatoum:
>> Hello,
>>
>> On 10/27/20 11:05 AM, Alexander Dahl wrote:
>>> Hello Ahmad,
>>>
>>> thanks for your feedback, comments below.
>>>
>>>>> - led-rgb {
>>>>> + led-controller-2 {
>>>>
>>>> Is a single RGB LED really a controller?
>>>
>>> I just followed the recommendations by Rob here.
>>
>> Do you happen to know if the new multicolor LED support could be used here?
>
> AFAIK not yet. The multicolor class should be ready and it is used by some
> drivers for I²C connected LED controllers, but if I understood Pavel
> correctly, additional work has to be done for a gpio and/or pwm multicolor
> driver. See this thread from August for example:
>
> https://lore.kernel.org/linux-leds/2530787.iFCFyWWcSu@g550jk/
I see. Thanks for the info.
>> I find it unfortunate that the device tree loses information relevant to
>> humans to adhere to a fixed nomenclature. Apparently led-controller isn't
>> even codified in the YAML binding (It's just in the examples). If you
>> respin, please add a comment that this is a single RGB led. I'd prefer to
>> keep the information in the DTB as well though.
>
> The "new" attributes 'function' and 'color' attributes should cover this
> information. IIRC those were introduced sometime before v5.4 and documentation
> is in the leds/common.yaml binding. I don't see it in the scope of this patch
> series, but if we would merge this warning fix first, the information is lost,
> so maybe those attributes should be added before?
Does it? The label already says it's a green LED, but the information that
it's a single physical LED 'bulb' is lost.
>
> My heuristics on that would be looking at the label and if there's a distinct
> color in it, add the color property. I could do that for all pwm LEDs known to
> the tree currently. That would be a bigger task for GPIO leds though. ;-)
I would be ok with just the led-containing node hinting that it's a single RGB led.
Cheers,
Ahmad
>
>>
>>>>> compatible = "pwm-leds";
>>>>>
>>>>> - led-red {
>>>>> + led-2 {
>>>>
>>>> Shouldn't this have been led-1 as well or is the numbering "global" ?
>>>
>>> Also good question. This numbering is for dts only, it usually does
>>> not correspond with LEDs on the board, so it could be numbered per
>>> led-controller as well?
>>
>> I'd prefer that it starts by 1. That way it's aligned with PWM channel
>> ID.
>
> Ack.
>
>>
>> Thanks for fixing the dtschema warnings by the way!
>
> Well, I "introduced" them by converting the leds-pwm binding to yaml (not
> merged yet), so I could as well fix the warnings then? ;-)
>
> Greets
> Alex
>
>>
>> Cheers,
>> Ahmad
>>
>>> Greets
>>> Alex
>>>
>>>>> label = "mc1:red:rgb";
>>>>> pwms = <&leds_pwm 1 1000000 0>;
>>>>> max-brightness = <255>;
>>>>> active-low;
>>>>>
>>>>> };
>>>>>
>>>>> - led-green {
>>>>> + led-3 {
>>>>>
>>>>> label = "mc1:green:rgb";
>>>>> pwms = <&leds_pwm 2 1000000 0>;
>>>>> max-brightness = <255>;
>>>>> active-low;
>>>>>
>>>>> };
>>>>>
>>>>> - led-blue {
>>>>> + led-4 {
>>>>>
>>>>> label = "mc1:blue:rgb";
>>>>> pwms = <&leds_pwm 3 1000000 0>;
>>>>> max-brightness = <255>;
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v7 11/12] arm64: dts: meson: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (9 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
12 siblings, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
Notes:
v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message
v6:
* added this patch to series
.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 8bcdffdf55d0..adfc72500e66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bff8ec2c1c70..dcb435af4e0b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH v7 12/12] MIPS: DTS: img: Fix schema warnings for pwm-leds
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (10 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl
@ 2020-10-05 20:34 ` Alexander Dahl
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
12 siblings, 0 replies; 38+ messages in thread
From: Alexander Dahl @ 2020-10-05 20:34 UTC (permalink / raw)
To: Pavel Machek, Dan Murphy, Rob Herring
Cc: Alexander Dahl, Jacek Anaszewski, Alexander Dahl, linux-leds,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
linux-omap, linux-stm32, linux-amlogic, linux-mips,
James Hartley, Rahul Bedarkar, Thomas Bogendoerfer
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v6 -> v7:
* added another explaining sentence to commit message
v6:
* added this patch to series
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts b/arch/mips/boot/dts/img/pistachio_marduk.dts
index bf69da96dc8b..a8708783f04b 100644
--- a/arch/mips/boot/dts/img/pistachio_marduk.dts
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -46,9 +46,10 @@
regulator-max-microvolt = <1800000>;
};
- leds {
+ led-controller {
compatible = "pwm-leds";
- heartbeat {
+
+ led-1 {
label = "marduk:red:heartbeat";
pwms = <&pwm 3 300000>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v7 00/12] leds: pwm: Make automatic labels work
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
` (11 preceding siblings ...)
2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl
@ 2020-10-28 18:56 ` Alexandre Belloni
2020-10-28 19:21 ` Alexandre Belloni
12 siblings, 1 reply; 38+ messages in thread
From: Alexandre Belloni @ 2020-10-28 18:56 UTC (permalink / raw)
To: Pavel Machek, Alexander Dahl, Rob Herring, Dan Murphy
Cc: Alexandre Belloni, linux-leds, linux-samsung-soc, linux-amlogic,
linux-arm-kernel, Jacek Anaszewski, linux-stm32, linux-kernel,
linux-mips, linux-omap, devicetree, Alexander Dahl
On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote:
> Hei hei,
>
> for leds-gpio you can use the properties 'function' and 'color' in the
> devicetree node and omit 'label', the label is constructed
> automatically. This is a common feature supposed to be working for all
> LED drivers. However it did not work until recently for the 'leds-pwm'
> driver.
>
> [...]
Applied, thanks!
[1/2] ARM: dts: at91: smartkiz: Reference led node directly
commit: 02e46262af5db410da5a27783833d68e2bdfb352
[2/2] ARM: dts: at91: Fix schema warnings for pwm-leds
commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v7 00/12] leds: pwm: Make automatic labels work
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
@ 2020-10-28 19:21 ` Alexandre Belloni
0 siblings, 0 replies; 38+ messages in thread
From: Alexandre Belloni @ 2020-10-28 19:21 UTC (permalink / raw)
To: Pavel Machek, Alexander Dahl, Rob Herring, Dan Murphy
Cc: linux-leds, linux-samsung-soc, linux-amlogic, linux-arm-kernel,
Jacek Anaszewski, linux-stm32, linux-kernel, linux-mips,
linux-omap, devicetree, Alexander Dahl
On 28/10/2020 19:56:14+0100, Alexandre Belloni wrote:
> On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote:
> > Hei hei,
> >
> > for leds-gpio you can use the properties 'function' and 'color' in the
> > devicetree node and omit 'label', the label is constructed
> > automatically. This is a common feature supposed to be working for all
> > LED drivers. However it did not work until recently for the 'leds-pwm'
> > driver.
> >
> > [...]
>
> Applied, thanks!
>
> [1/2] ARM: dts: at91: smartkiz: Reference led node directly
> commit: 02e46262af5db410da5a27783833d68e2bdfb352
> [2/2] ARM: dts: at91: Fix schema warnings for pwm-leds
> commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73
This was obviously 04/12 and 05/12.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 38+ messages in thread