From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F01C4363A for ; Wed, 14 Oct 2020 15:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0810022201 for ; Wed, 14 Oct 2020 15:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602689085; bh=eqrTqccSoGxwHnXxBZ2fBIhBBMS6GxKWzR/IHlxG9xM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eo1fBy+4k5FiT2IgmCKH5xLKJ34qj9k98eUaqai1IMN7ifPs2razH8BUFiPD+h38F ObSKxcb5L3zIGaIu5VqkWwX50V///10eZPZwmq2UD3chCL9X3TAxtQU0D5ydMrgpP5 7eH7IlFKq8mIFwRTH2u+3IUru11VHqB51bvBZRnw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730911AbgJNPYk (ORCPT ); Wed, 14 Oct 2020 11:24:40 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:35303 "EHLO mail-ej1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbgJNPYk (ORCPT ); Wed, 14 Oct 2020 11:24:40 -0400 Received: by mail-ej1-f51.google.com with SMTP id p5so2598258ejj.2; Wed, 14 Oct 2020 08:24:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WKtkQewTW29sGezeiY3401LBi0f0aDL6Ojfyn2s8nSY=; b=buMdzOs9oSHhTzhi6CgdQociN3teAYAUMJZw8ZbgCsQllLvNP4k16tx/HGjqhv9IZf gTSbSL54+RyV3kmkO7wSb6mkc4qcC4HMyaNbtvYOp3Vh7JaIPwKUX9P0j+v/uTedaIja n7tSU11Hx6YJOuczhPvpmFImS0lNXl/u8aTdxHAoPxSLo6APg3KQ4ttdfGQo8S0Fgu1f phb1c/bnVQOe0MsBBvM3kevZ9Ax7uHlnBylILcvbgAgN0Vn3AOnWXGsyvMRiss5BtQ5R 6ad44EmwSqDmiLgTYoirkNFibSXu1pxFjKT9cFlVV+Fl7VzqPMaj4XZemh983KG27I/q nyWg== X-Gm-Message-State: AOAM5314bOOoue1XCvbJwloHhnyXV4xP4QglOquGhvOnoidlsbRBL4nB uW/i5vpsL0jljwPg6iNRhcd/x/C+D5s= X-Google-Smtp-Source: ABdhPJzE5XYEVbn6Q5Kzayrkv21WIGmOEMdk2tjCPkMhcq3EL/6zgaBQKbVAHbJ4ODUXmlA5ShI7Qw== X-Received: by 2002:a17:906:8349:: with SMTP id b9mr6110278ejy.88.1602689078419; Wed, 14 Oct 2020 08:24:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id t4sm1954606ejj.6.2020.10.14.08.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 08:24:37 -0700 (PDT) Date: Wed, 14 Oct 2020 17:24:33 +0200 From: Krzysztof Kozlowski To: Thomas Gleixner Cc: LKML , Peter Zijlstra , "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Thomas Winischhofer , Johan Hovold , Mathias Nyman , Valentina Manea , Shuah Khan , Felipe Balbi , Duncan Sands Subject: Re: [patch 08/12] usb: hosts: Remove in_interrupt() from comments Message-ID: <20201014152433.GA3959@kozik-lap> References: <20201014145215.518912759@linutronix.de> <20201014145727.957664398@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201014145727.957664398@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors and make usb_hcd_msp_remove() static. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > > --- > drivers/usb/host/ehci-fsl.c | 9 ++++----- > drivers/usb/host/ehci-pmcmsp.c | 15 +++++++++------ > drivers/usb/host/ohci-at91.c | 11 ++++++++--- > drivers/usb/host/ohci-omap.c | 7 ++++--- > drivers/usb/host/ohci-pxa27x.c | 11 ++++++----- > drivers/usb/host/ohci-s3c2410.c | 12 ++++++------ For the s3c2410: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof