From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A48E7C43457 for ; Wed, 14 Oct 2020 16:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51AC322247 for ; Wed, 14 Oct 2020 16:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728751AbgJNQWK (ORCPT ); Wed, 14 Oct 2020 12:22:10 -0400 Received: from netrider.rowland.org ([192.131.102.5]:41827 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728083AbgJNQWK (ORCPT ); Wed, 14 Oct 2020 12:22:10 -0400 Received: (qmail 719232 invoked by uid 1000); 14 Oct 2020 12:22:09 -0400 Date: Wed, 14 Oct 2020 12:22:09 -0400 From: Alan Stern To: Thomas Gleixner Cc: LKML , Peter Zijlstra , "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Thomas Winischhofer , Johan Hovold , Mathias Nyman , Valentina Manea , Shuah Khan , linux-omap@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Duncan Sands Subject: Re: [patch 10/12] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments Message-ID: <20201014162209.GD712494@rowland.harvard.edu> References: <20201014145215.518912759@linutronix.de> <20201014145728.208701440@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014145728.208701440@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Oct 14, 2020 at 04:52:25PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_irq()/in_interrupt() in drivers is phased out for various > reasons. > > The context description for usb_gadget_giveback_request() is misleading as > in_interupt() means: hard interrupt or soft interrupt or bottom half > disabled regions. But it's also invoked from task context when endpoints > are torn down. Remove it as it's more confusing than helpful. > > Replace also the in_irq() comment with plain text. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > > --- > --- a/drivers/usb/gadget/udc/dummy_hcd.c > +++ b/drivers/usb/gadget/udc/dummy_hcd.c > @@ -1754,8 +1754,9 @@ static int handle_control_request(struct > return ret_val; > } > > -/* drive both sides of the transfers; looks like irq handlers to > - * both drivers except the callbacks aren't in_irq(). > +/* drive both sides of the transfers; looks like irq handlers to both > + * drivers except that the callbacks are invoked from soft interrupt > + * context. > */ You might as well fix the formatting of the multiline comment while you're changing its content. Alan Stern