From: Thomas Zimmermann <tzimmermann@suse.de>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: b.zolnierkie@samsung.com, pakki001@umn.edu,
yuehaibing@huawei.com, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare
Date: Fri, 16 Oct 2020 11:53:56 +0200 [thread overview]
Message-ID: <20201016115356.34c1620b@linux-uq9g> (raw)
In-Reply-To: <20201015100827.1115fa9b@linux-uq9g>
On Thu, 15 Oct 2020 10:08:27 +0200 Thomas Zimmermann <tzimmermann@suse.de>
wrote:
> On Wed, 14 Oct 2020 08:49:20 +0000 Xu Wang <vulab@iscas.ac.cn> wrote:
>
> > Because clk_prepare_enable() and clk_disable_unprepare() already checked
> > NULL clock parameter, so the additional checks are unnecessary, just
> > remove them.
> >
> > Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
Merged into drm-misc-next. Thanks!
> > ---
> > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c
> > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c index
> > 0b0ad20afd63..8895fb8493d8 100644 ---
> > a/drivers/video/fbdev/omap2/omapfb/dss/venc.c +++
> > b/drivers/video/fbdev/omap2/omapfb/dss/venc.c @@ -890,8 +890,7 @@ static
> > int venc_remove(struct platform_device *pdev)
> > static int venc_runtime_suspend(struct device *dev)
> > {
> > - if (venc.tv_dac_clk)
> > - clk_disable_unprepare(venc.tv_dac_clk);
> > + clk_disable_unprepare(venc.tv_dac_clk);
> >
> > dispc_runtime_put();
> >
> > @@ -906,8 +905,7 @@ static int venc_runtime_resume(struct device *dev)
> > if (r < 0)
> > return r;
> >
> > - if (venc.tv_dac_clk)
> > - clk_prepare_enable(venc.tv_dac_clk);
> > + clk_prepare_enable(venc.tv_dac_clk);
> >
> > return 0;
> > }
>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
prev parent reply other threads:[~2020-10-16 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 8:49 Xu Wang
2020-10-15 8:08 ` Thomas Zimmermann
2020-10-16 9:53 ` Thomas Zimmermann
2020-10-16 9:53 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016115356.34c1620b@linux-uq9g \
--to=tzimmermann@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=vulab@iscas.ac.cn \
--cc=yuehaibing@huawei.com \
--subject='Re: [PATCH] omapfb/dss: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).