From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2750C43467 for ; Mon, 19 Oct 2020 16:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 760B3222EC for ; Mon, 19 Oct 2020 16:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730570AbgJSQ2V (ORCPT ); Mon, 19 Oct 2020 12:28:21 -0400 Received: from netrider.rowland.org ([192.131.102.5]:58637 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1730459AbgJSQ2U (ORCPT ); Mon, 19 Oct 2020 12:28:20 -0400 Received: (qmail 902120 invoked by uid 1000); 19 Oct 2020 12:28:19 -0400 Date: Mon, 19 Oct 2020 12:28:19 -0400 From: Alan Stern To: Thomas Gleixner Cc: LKML , Peter Zijlstra , "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Thomas Winischhofer , Johan Hovold , Mathias Nyman , Valentina Manea , Shuah Khan , Felipe Balbi , Duncan Sands Subject: Re: [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments Message-ID: <20201019162819.GA898631@rowland.harvard.edu> References: <20201019100629.419020859@linutronix.de> <20201019101110.439968251@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019101110.439968251@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Oct 19, 2020 at 12:06:37PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Acked-by: Krzysztof Kozlowski > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: Kukjin Kim > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > --- > V2: Split out the static change and add a missing comment > --- > drivers/usb/host/ehci-fsl.c | 9 ++++----- > drivers/usb/host/ehci-pmcmsp.c | 11 +++++++---- > drivers/usb/host/ohci-at91.c | 11 ++++++++--- > drivers/usb/host/ohci-omap.c | 9 ++++++--- > drivers/usb/host/ohci-pxa27x.c | 11 ++++++----- > drivers/usb/host/ohci-s3c2410.c | 12 ++++++------ > 6 files changed, 37 insertions(+), 26 deletions(-) Acked-by: Alan Stern