From: Alan Stern <stern@rowland.harvard.edu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Thomas Winischhofer <thomas@winischhofer.net>,
Johan Hovold <johan@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
linux-omap@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Felipe Balbi <balbi@kernel.org>,
Duncan Sands <duncan.sands@free.fr>
Subject: Re: [patch V2 12/13] usb: core: Replace in_interrupt() in comments
Date: Mon, 19 Oct 2020 12:28:40 -0400 [thread overview]
Message-ID: <20201019162840.GD898631@rowland.harvard.edu> (raw)
In-Reply-To: <20201019101110.851821025@linutronix.de>
On Mon, Oct 19, 2020 at 12:06:41PM +0200, Thomas Gleixner wrote:
> From: Ahmed S. Darwish <a.darwish@linutronix.de>
>
> The usage of in_interrupt() in drivers is phased out for various reasons.
>
> Various comments use !in_interrupt() to describe calling context for
> functions which might sleep. That's wrong because the calling context has
> to be preemptible task context, which is not what !in_interrupt()
> describes.
>
> Replace !in_interrupt() with more accurate plain text descriptions.
>
> The comment for usb_hcd_poll_rh_status() is misleading as this function is
> called from all kinds of contexts including preemptible task
> context. Remove it as there is obviously no restriction.
>
> Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> ---
> V2: Fixup the comments according to review (Alan)
> ---
> drivers/usb/core/buffer.c | 6 ++++--
> drivers/usb/core/hcd-pci.c | 6 ++++--
> drivers/usb/core/hcd.c | 26 +++++++++++++++++---------
> drivers/usb/core/hub.c | 3 ++-
> drivers/usb/core/message.c | 35 ++++++++++++++++++++++-------------
> drivers/usb/core/usb.c | 4 ++--
> 6 files changed, 51 insertions(+), 29 deletions(-)
Acked-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2020-10-19 16:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 10:06 [patch V2 00/13] USB: Cleanup in_interupt/in_irq/in_atomic() usage Thomas Gleixner
2020-10-19 10:06 ` [patch V2 01/13] USB: sisusbvga: Make console support depend on BROKEN Thomas Gleixner
2020-10-19 10:06 ` [patch V2 02/13] USB: serial: keyspan_pda: Replace in_interrupt() usage Thomas Gleixner
2020-10-25 16:56 ` Johan Hovold
2020-10-26 12:47 ` Sebastian Andrzej Siewior
2020-10-27 8:16 ` Johan Hovold
2020-10-19 10:06 ` [patch V2 03/13] USB: serial: keyspan_pda: Consolidate room query Thomas Gleixner
2020-10-25 17:05 ` Johan Hovold
2020-10-19 10:06 ` [patch V2 04/13] USB: serial: digi_acceleport: Remove in_interrupt() usage Thomas Gleixner
2020-10-25 17:16 ` Johan Hovold
2020-10-26 14:03 ` [PATCH v3 04/13 ] " Sebastian Andrzej Siewior
2020-10-27 8:26 ` Johan Hovold
2020-10-19 10:06 ` [patch V2 05/13] usb: xhci: Remove in_interrupt() checks Thomas Gleixner
2020-10-19 10:06 ` [patch V2 06/13] usb: host: isp1362: Replace in_interrupt() usage Thomas Gleixner
2020-10-28 11:27 ` Greg Kroah-Hartman
2020-10-19 10:06 ` [patch V2 07/13] usbip: Remove in_interrupt() check Thomas Gleixner
2020-10-19 10:06 ` [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 09/13] USB: host: ehci-pmcmsp: Cleanup usb_hcd_msp_remove() Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 10/13] usb: gadget: pxa27x_udc: Replace in_interrupt() usage in comments Thomas Gleixner
2020-10-19 10:06 ` [patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern
2020-10-19 10:06 ` [patch V2 12/13] usb: core: Replace in_interrupt() in comments Thomas Gleixner
2020-10-19 16:28 ` Alan Stern [this message]
2020-10-19 10:06 ` [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment Thomas Gleixner
2020-10-19 10:28 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019162840.GD898631@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=a.darwish@linutronix.de \
--cc=balbi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=duncan.sands@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas@winischhofer.net \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).