From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BFEC433E7 for ; Mon, 19 Oct 2020 16:28:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 115BC222EA for ; Mon, 19 Oct 2020 16:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730642AbgJSQ2l (ORCPT ); Mon, 19 Oct 2020 12:28:41 -0400 Received: from netrider.rowland.org ([192.131.102.5]:34811 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1730637AbgJSQ2l (ORCPT ); Mon, 19 Oct 2020 12:28:41 -0400 Received: (qmail 902215 invoked by uid 1000); 19 Oct 2020 12:28:40 -0400 Date: Mon, 19 Oct 2020 12:28:40 -0400 From: Alan Stern To: Thomas Gleixner Cc: LKML , Peter Zijlstra , "Ahmed S. Darwish" , Sebastian Andrzej Siewior , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Thomas Winischhofer , Johan Hovold , Mathias Nyman , Valentina Manea , Shuah Khan , linux-omap@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Felipe Balbi , Duncan Sands Subject: Re: [patch V2 12/13] usb: core: Replace in_interrupt() in comments Message-ID: <20201019162840.GD898631@rowland.harvard.edu> References: <20201019100629.419020859@linutronix.de> <20201019101110.851821025@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201019101110.851821025@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Oct 19, 2020 at 12:06:41PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for > functions which might sleep. That's wrong because the calling context has > to be preemptible task context, which is not what !in_interrupt() > describes. > > Replace !in_interrupt() with more accurate plain text descriptions. > > The comment for usb_hcd_poll_rh_status() is misleading as this function is > called from all kinds of contexts including preemptible task > context. Remove it as there is obviously no restriction. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > --- > V2: Fixup the comments according to review (Alan) > --- > drivers/usb/core/buffer.c | 6 ++++-- > drivers/usb/core/hcd-pci.c | 6 ++++-- > drivers/usb/core/hcd.c | 26 +++++++++++++++++--------- > drivers/usb/core/hub.c | 3 ++- > drivers/usb/core/message.c | 35 ++++++++++++++++++++++------------- > drivers/usb/core/usb.c | 4 ++-- > 6 files changed, 51 insertions(+), 29 deletions(-) Acked-by: Alan Stern