From: Bhushan Shah <bshah@kde.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
clayton@craftyguy.net
Subject: Re: [PATCH] usb: musb: fix idling for suspend after disconnect interrupt
Date: Tue, 27 Oct 2020 10:25:19 +0530 [thread overview]
Message-ID: <20201027045519.GA947883@aquila.localdomain> (raw)
In-Reply-To: <20191126034151.38154-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]
Hi Tony,
On Mon, Nov 25, 2019 at 07:41:51PM -0800, Tony Lindgren wrote:
> When disconnected as USB B-device, we sometimes get a suspend interrupt
> after disconnect interrupt. In that case we have devctl set to 99 with
> VBUS still valid and musb_pm_runtime_check_session() wrongly things we
> have an active session. We have no other interrupts after disconnect
> coming in this case at least with the omap2430 glue.
So I had been debugging a issue with musb_hrdc driver preventing a
suspend on the pinephone, which is Allwinner A64 platform.
Namely, if I have USB connected, and I try to suspend, it would hang
until USB is disconnected. After enabling tracing, I realized that is
hanging after this commit. Reverting it makes device suspend and resume
correctly.
Some more of debugging notes can be found at,
https://gitlab.com/postmarketOS/pmaports/-/issues/839
I wonder what would be right solution here? Disable this quirk somehow
for device?
Regards
> Let's fix the issue by checking the interrupt status again with
> delayed work for the devctl 99 case. In the suspend after disconnect
> case the devctl session bit has cleared by then and musb can idle.
> For a typical USB B-device connect case we just continue with normal
> interrupts.
>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/usb/musb/musb_core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1943,6 +1943,9 @@ ATTRIBUTE_GROUPS(musb);
> #define MUSB_QUIRK_B_INVALID_VBUS_91 (MUSB_DEVCTL_BDEVICE | \
> (2 << MUSB_DEVCTL_VBUS_SHIFT) | \
> MUSB_DEVCTL_SESSION)
> +#define MUSB_QUIRK_B_DISCONNECT_99 (MUSB_DEVCTL_BDEVICE | \
> + (3 << MUSB_DEVCTL_VBUS_SHIFT) | \
> + MUSB_DEVCTL_SESSION)
> #define MUSB_QUIRK_A_DISCONNECT_19 ((3 << MUSB_DEVCTL_VBUS_SHIFT) | \
> MUSB_DEVCTL_SESSION)
>
> @@ -1965,6 +1968,11 @@ static void musb_pm_runtime_check_session(struct musb *musb)
> s = MUSB_DEVCTL_FSDEV | MUSB_DEVCTL_LSDEV |
> MUSB_DEVCTL_HR;
> switch (devctl & ~s) {
> + case MUSB_QUIRK_B_DISCONNECT_99:
> + musb_dbg(musb, "Poll devctl in case of suspend after disconnect\n");
> + schedule_delayed_work(&musb->irq_work,
> + msecs_to_jiffies(1000));
> + break;
> case MUSB_QUIRK_B_INVALID_VBUS_91:
> if (musb->quirk_retries && !musb->flush_irq_work) {
> musb_dbg(musb,
> --
> 2.24.0
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next parent reply other threads:[~2020-10-27 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191126034151.38154-1-tony@atomide.com>
2020-10-27 4:55 ` Bhushan Shah [this message]
2020-10-27 6:17 ` [PATCH] usb: musb: fix idling for suspend after disconnect interrupt Tony Lindgren
2020-10-27 7:59 ` Bhushan Shah
2020-10-28 8:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027045519.GA947883@aquila.localdomain \
--to=bshah@kde.org \
--cc=b-liu@ti.com \
--cc=clayton@craftyguy.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).