* [PATCH 0/8] drivers/mfd: Constify static struct resource
@ 2020-09-22 19:26 Rikard Falkeborn
2020-09-22 19:26 ` [PATCH 3/8] mfd: Constify static struct resource in OMAP2+ drivers Rikard Falkeborn
0 siblings, 1 reply; 3+ messages in thread
From: Rikard Falkeborn @ 2020-09-22 19:26 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Rikard Falkeborn, support.opensource,
Andy Shevchenko, Tony Lindgren, linux-omap, patches, Milo Kim,
Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel,
Maxime Ripard, Chen-Yu Tsai
Constify a number of static struct resource to allow the compiler to put
them in read-only memory. Typically, the only usage of these is to assign
their address to the resources field in the mfd_cell struct, which is a
const pointer (a few drivers also read the value of the start field).
I went through the rest of the static instances of struct resource in
drivers/mfd and all of them are either directly modified by the driver
or has its address passed to mfd_add_devices() which takes a non-const
pointer.
The series is compile-tested only.
I split this into patches per maintainer, I'll happily split it (or squash
it) some other way if that's preferable.
Rikard Falkeborn (8):
mfd: da: Constify static struct resource
mfd: intel: Constify static struct resource
mfd: Constify static struct resource in OMAP2+ drivers
mfd: wm: Constify static struct resource
mfd: lp8788: Constify static struct resource
mfd: stmpe: Constify static struct resource
mfd: sun4i-gpadc: Constify static struct resource
mfd: Constify static struct resource
drivers/mfd/88pm800.c | 2 +-
drivers/mfd/88pm860x-core.c | 50 ++++++++++++------------
drivers/mfd/da9055-core.c | 8 ++--
drivers/mfd/da9062-core.c | 24 ++++++------
drivers/mfd/da9063-core.c | 8 ++--
drivers/mfd/da9150-core.c | 6 +--
drivers/mfd/hi655x-pmic.c | 2 +-
drivers/mfd/intel_msic.c | 18 ++++-----
drivers/mfd/intel_quark_i2c_gpio.c | 4 +-
drivers/mfd/intel_soc_pmic_bxtwc.c | 14 +++----
drivers/mfd/intel_soc_pmic_chtdc_ti.c | 10 ++---
drivers/mfd/intel_soc_pmic_chtwc.c | 4 +-
drivers/mfd/intel_soc_pmic_crc.c | 10 ++---
drivers/mfd/ioc3.c | 16 ++++----
drivers/mfd/lp8788.c | 4 +-
drivers/mfd/max8925-core.c | 56 +++++++++++++--------------
drivers/mfd/rdc321x-southbridge.c | 4 +-
drivers/mfd/retu-mfd.c | 4 +-
drivers/mfd/rk808.c | 8 ++--
drivers/mfd/stmpe.c | 10 ++---
drivers/mfd/sun4i-gpadc.c | 2 +-
drivers/mfd/tc3589x.c | 4 +-
drivers/mfd/tc6387xb.c | 2 +-
drivers/mfd/tc6393xb.c | 6 +--
drivers/mfd/tps65090.c | 2 +-
drivers/mfd/tps65217.c | 4 +-
drivers/mfd/tps6586x.c | 2 +-
drivers/mfd/tps65910.c | 2 +-
drivers/mfd/tps80031.c | 2 +-
drivers/mfd/wm831x-core.c | 52 ++++++++++++-------------
drivers/mfd/wm8994-core.c | 4 +-
31 files changed, 172 insertions(+), 172 deletions(-)
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/8] mfd: Constify static struct resource in OMAP2+ drivers
2020-09-22 19:26 [PATCH 0/8] drivers/mfd: Constify static struct resource Rikard Falkeborn
@ 2020-09-22 19:26 ` Rikard Falkeborn
2020-11-04 10:57 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Rikard Falkeborn @ 2020-09-22 19:26 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Rikard Falkeborn, Tony Lindgren, linux-omap
Constify a number of static struct resource. The only usage of the
structs are to assign their address to the resources field in the
mfd_cell struct. This allows the compiler to put them in read-only
memory. Done with the help of Coccinelle.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/mfd/tps65217.c | 4 ++--
drivers/mfd/tps65910.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
index 2d9c282ec917..8027b0a9e14f 100644
--- a/drivers/mfd/tps65217.c
+++ b/drivers/mfd/tps65217.c
@@ -33,12 +33,12 @@
#include <linux/mfd/core.h>
#include <linux/mfd/tps65217.h>
-static struct resource charger_resources[] = {
+static const struct resource charger_resources[] = {
DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_AC, "AC"),
DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_USB, "USB"),
};
-static struct resource pb_resources[] = {
+static const struct resource pb_resources[] = {
DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_PB, "PB"),
};
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 11959021b50a..a6c28df7aa38 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -21,7 +21,7 @@
#include <linux/of.h>
#include <linux/of_device.h>
-static struct resource rtc_resources[] = {
+static const struct resource rtc_resources[] = {
{
.start = TPS65910_IRQ_RTC_ALARM,
.end = TPS65910_IRQ_RTC_ALARM,
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/8] mfd: Constify static struct resource in OMAP2+ drivers
2020-09-22 19:26 ` [PATCH 3/8] mfd: Constify static struct resource in OMAP2+ drivers Rikard Falkeborn
@ 2020-11-04 10:57 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2020-11-04 10:57 UTC (permalink / raw)
To: Rikard Falkeborn; +Cc: linux-kernel, Tony Lindgren, linux-omap
On Tue, 22 Sep 2020, Rikard Falkeborn wrote:
> Constify a number of static struct resource. The only usage of the
> structs are to assign their address to the resources field in the
> mfd_cell struct. This allows the compiler to put them in read-only
> memory. Done with the help of Coccinelle.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/mfd/tps65217.c | 4 ++--
> drivers/mfd/tps65910.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-04 10:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 19:26 [PATCH 0/8] drivers/mfd: Constify static struct resource Rikard Falkeborn
2020-09-22 19:26 ` [PATCH 3/8] mfd: Constify static struct resource in OMAP2+ drivers Rikard Falkeborn
2020-11-04 10:57 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).