From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C5DC2D0A3 for ; Mon, 9 Nov 2020 11:16:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C915208FE for ; Mon, 9 Nov 2020 11:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aronStbw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727311AbgKILQQ (ORCPT ); Mon, 9 Nov 2020 06:16:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727303AbgKILQP (ORCPT ); Mon, 9 Nov 2020 06:16:15 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B91B9C0613CF for ; Mon, 9 Nov 2020 03:16:15 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53B2DB2B; Mon, 9 Nov 2020 12:16:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604920574; bh=+KJGY4ijKH63lMcqJdU36XoGEfZ118V7qI8Gbv9vgV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aronStbwZNJ936wJtVUlX4Yu5pW3nn+vC3Nkkp5fH+iNbJKIh1xINkCV2sLqxrAzI gtNYj4rhXyQ0TvkcWSUKH7ezKy+Bz7V7nztvdRfj+g3qOoZfPhDdC2rtniC4kEUUNd RgAD4sZiQY1vigGBvFARnK7D/V3MfQy1Ecjb04DI= Date: Mon, 9 Nov 2020 13:16:11 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" Subject: Re: [PATCH v3 53/56] drm/omap: remove unused display.c Message-ID: <20201109111611.GX6029@pendragon.ideasonboard.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-54-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201105120333.947408-54-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Thu, Nov 05, 2020 at 02:03:30PM +0200, Tomi Valkeinen wrote: > The functions in display.c are not used, so drop the file. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/Makefile | 2 +- > drivers/gpu/drm/omapdrm/dss/display.c | 58 --------------------------- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 -- > 3 files changed, 1 insertion(+), 63 deletions(-) > delete mode 100644 drivers/gpu/drm/omapdrm/dss/display.c > > diff --git a/drivers/gpu/drm/omapdrm/Makefile b/drivers/gpu/drm/omapdrm/Makefile > index 33fe7e937680..21e8277ff88f 100644 > --- a/drivers/gpu/drm/omapdrm/Makefile > +++ b/drivers/gpu/drm/omapdrm/Makefile > @@ -18,7 +18,7 @@ omapdrm-y := omap_drv.o \ > > omapdrm-$(CONFIG_DRM_FBDEV_EMULATION) += omap_fbdev.o > > -omapdrm-y += dss/base.o dss/display.o dss/output.o dss/dss.o dss/dispc.o \ > +omapdrm-y += dss/base.o dss/output.o dss/dss.o dss/dispc.o \ > dss/dispc_coefs.o dss/pll.o dss/video-pll.o > omapdrm-$(CONFIG_OMAP2_DSS_DPI) += dss/dpi.o > omapdrm-$(CONFIG_OMAP2_DSS_VENC) += dss/venc.o > diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/drivers/gpu/drm/omapdrm/dss/display.c > deleted file mode 100644 > index 7b7ee2019eae..000000000000 > --- a/drivers/gpu/drm/omapdrm/dss/display.c > +++ /dev/null > @@ -1,58 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * Copyright (C) 2009 Nokia Corporation > - * Author: Tomi Valkeinen > - * > - * Some code and ideas taken from drivers/video/omap/ driver > - * by Imre Deak. > - */ > - > -#define DSS_SUBSYS_NAME "DISPLAY" > - > -#include > -#include > - > -#include > -#include > - > -#include "omapdss.h" > - > -static int disp_num_counter; > - > -void omapdss_display_init(struct omap_dss_device *dssdev) > -{ > - int id; > - > - /* > - * Note: this presumes that all displays either have an DT alias, or > - * none has. > - */ > - id = of_alias_get_id(dssdev->dev->of_node, "display"); > - if (id < 0) > - id = disp_num_counter++; > - > - /* Use 'label' property for name, if it exists */ > - of_property_read_string(dssdev->dev->of_node, "label", &dssdev->name); > - > - if (dssdev->name == NULL) > - dssdev->name = devm_kasprintf(dssdev->dev, GFP_KERNEL, > - "display%u", id); > -} > - > -int omapdss_display_get_modes(struct drm_connector *connector, > - const struct videomode *vm) > -{ > - struct drm_display_mode *mode; > - > - mode = drm_mode_create(connector->dev); > - if (!mode) > - return 0; > - > - drm_display_mode_from_videomode(vm, mode); > - > - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > - drm_mode_set_name(mode); > - drm_mode_probed_add(connector, mode); > - > - return 1; > -} > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index 4e7ae164de4f..90e41c635e45 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -300,10 +300,6 @@ struct dss_pdata { > struct dss_device *dss; > }; > > -void omapdss_display_init(struct omap_dss_device *dssdev); > -int omapdss_display_get_modes(struct drm_connector *connector, > - const struct videomode *vm); > - > void omapdss_device_register(struct omap_dss_device *dssdev); > void omapdss_device_unregister(struct omap_dss_device *dssdev); > struct omap_dss_device *omapdss_device_get(struct omap_dss_device *dssdev); -- Regards, Laurent Pinchart