From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBBFC55ABD for ; Tue, 10 Nov 2020 11:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C31420637 for ; Tue, 10 Nov 2020 11:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbgKJLdu (ORCPT ); Tue, 10 Nov 2020 06:33:50 -0500 Received: from muru.com ([72.249.23.125]:47814 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbgKJLdu (ORCPT ); Tue, 10 Nov 2020 06:33:50 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7DAFC80BA; Tue, 10 Nov 2020 11:33:55 +0000 (UTC) Date: Tue, 10 Nov 2020 13:33:46 +0200 From: Tony Lindgren To: Peter Ujfalusi Cc: linux-omap@vger.kernel.org, Vinod , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dmaengine: ti: omap-dma: Block PM if SDMA is busy to fix audio Message-ID: <20201110113346.GD26857@atomide.com> References: <20201109154013.11950-1-tony@atomide.com> <39089a2c-a883-d9b4-f1d6-493af2190410@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39089a2c-a883-d9b4-f1d6-493af2190410@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Peter Ujfalusi [201110 07:59]: > Hi, > > On 10/11/2020 9.58, Peter Ujfalusi wrote: > > Hi Tony, > > > > On 09/11/2020 17.40, Tony Lindgren wrote: > >> We now use cpu_pm for saving and restoring device context for deeper SoC > >> idle states. But for omap3, we must also block idle if SDMA is busy. > >> > >> If we don't block idle when SDMA is busy, we eventually end up saving and > >> restoring SDMA register state on PER domain idle while SDMA is active and > >> that causes at least audio playback to fail. > > > > Thanks for the fix! > > > > Tested-by: Peter Ujfalusi > > Acked-by: Peter Ujfalusi > > > > Vinod: Can you take this for 5.10 as a fix? The off mode got enabled by > > default in 5.10-rc1 and audio got broken out of box. > > to Vinod with corrected email address.. Sorry about that, I've bounced the original patch too. Vinod let me know if you want me to resend the patch. Regards, Tony