From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support
Date: Tue, 17 Nov 2020 00:30:27 +0100 [thread overview]
Message-ID: <20201116233027.GC1756591@lunn.ch> (raw)
In-Reply-To: <20201116185919.qwaklquxhhhtqttg@skbuf>
> Same as above, just in packets per second.
>
> tc qdisc add dev eth0 clsact
> tc filter add dev eth0 ingress flower skip_sw \
> dst_mac 01:00:00:00:00:00/01:00:00:00:00:00 \
> action police rate 20kpps
I agree with Vladimir here. Since the hardware does PPS limits, the TC
API should also be PPS limit based. And as you said, CPU load is more
a factor of PPS than BPS, so it is a useful feature in general to
have. You just need to implement the software version first, before
you offload it to the hardware.
Andrew
prev parent reply other threads:[~2020-11-16 23:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 3:56 [PATCH net-next 0/3] net: ethernet: ti: cpsw: enable broadcast/multicast rate limit support Grygorii Strashko
2020-11-14 3:56 ` [PATCH net-next 1/3] drivers: net: cpsw: ale: add " Grygorii Strashko
2020-11-14 3:56 ` [PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable " Grygorii Strashko
2020-11-14 19:09 ` Vladimir Oltean
2020-11-16 13:01 ` Grygorii Strashko
2020-11-14 3:56 ` [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: " Grygorii Strashko
2020-11-14 19:17 ` Vladimir Oltean
2020-11-16 18:39 ` Grygorii Strashko
2020-11-16 18:59 ` Vladimir Oltean
2020-11-16 23:30 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116233027.GC1756591@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=olteanv@gmail.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).