From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A2CC5519F for ; Mon, 30 Nov 2020 09:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 177E520643 for ; Mon, 30 Nov 2020 09:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="klBINz1n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgK3J42 (ORCPT ); Mon, 30 Nov 2020 04:56:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgK3J42 (ORCPT ); Mon, 30 Nov 2020 04:56:28 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D36B1C0613D2 for ; Mon, 30 Nov 2020 01:55:47 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 615BD97E; Mon, 30 Nov 2020 10:55:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606730146; bh=F632zAfOnkVUhZDpDRO4KCi2k6m3q4ajdwqJGrR2YWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=klBINz1nb6p/F/LRk5mCz93AhVajhK67Q6oh+HVo4SYGj6AEcBiwNOTJB5//Q9ZvF e8EFcltBt2P5WzJhYmpBa1kOSYuyII4kmKEYrZUIi4IKQfBWAk8ivZQqC8p6e+1HBP HZG3CKaHdQvRpL9nHyap7095zt6hHuJTe/eMgTVw= Date: Mon, 30 Nov 2020 11:55:38 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com Subject: Re: [PATCH v4 59/80] drm/omap: dsi: set trans_mode according to client mode_flags Message-ID: <20201130095538.GK4141@pendragon.ideasonboard.com> References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-60-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201124124538.660710-60-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index c3592c6db977..7fee9cf8782d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -5140,6 +5140,13 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, > dsi->config.lp_clk_min = 7000000; // TODO: get from client? > dsi->config.lp_clk_max = client->lp_rate; > > + if (client->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) > + dsi->config.trans_mode = OMAP_DSS_DSI_BURST_MODE; > + else if (client->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) > + dsi->config.trans_mode = OMAP_DSS_DSI_PULSE_MODE; > + else > + dsi->config.trans_mode = OMAP_DSS_DSI_EVENT_MODE; > + > dsi->ulps_auto_idle = false; > > return 0; > -- Regards, Laurent Pinchart