From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D88C63777 for ; Tue, 1 Dec 2020 00:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C87A320809 for ; Tue, 1 Dec 2020 00:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZnFxT5R/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730850AbgLAAWC (ORCPT ); Mon, 30 Nov 2020 19:22:02 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:35554 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729912AbgLAAWC (ORCPT ); Mon, 30 Nov 2020 19:22:02 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 43F7645D; Tue, 1 Dec 2020 01:21:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1606782080; bh=Lu33/2kcnuW1RbmNV5G6DLZQSxSuhYk9Oe+BD9FRLEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZnFxT5R/MEaAp55v3Y4sU2wjGumKy6GukLh11sLDKmnJo2DBc0mG1wPQ2TMZh6Usq Di6Bb85PMnGduWMG/8pnZ5ytrcfzJ0duVPbDpQ4UCn3Llomn/pU2QO6Xx1IOaU9pMa V8uczcRoYyZOlbv1ZhQ6K2upfVjPntngApzbnNtk= Date: Tue, 1 Dec 2020 02:21:12 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Sebastian Reichel , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com Subject: Re: [PATCH v4 67/80] drm/omap: dsi: use separate VCs for cmd and video Message-ID: <20201201002112.GL25713@pendragon.ideasonboard.com> References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-68-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201124124538.660710-68-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:25PM +0200, Tomi Valkeinen wrote: > For command mode panels we can use a single VC for sending command and > video data, even if we have to change the data source for that VC when > going from command to video or vice versa. > > However, with video mode panels we want to keep the pixel data VC > enabled, and use another VC for command data, and the commands will get > interleaved into the pixel data. > > This patch makes the driver use VC0 for commands and VC1 for video. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 41d6231d6e31..019814a0a264 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -452,7 +452,9 @@ static bool dsi_perf; > module_param(dsi_perf, bool, 0644); > #endif > > -#define VC_DEFAULT 0 > +/* Note: for some reason video mode seems to work only if VC_VIDEO is 0 */ > +#define VC_VIDEO 0 > +#define VC_CMD 1 > > #define drm_bridge_to_dsi(bridge) \ > container_of(bridge, struct dsi_data, bridge) > @@ -3723,7 +3725,7 @@ static void dsi_disable_video_outputs(struct omap_dss_device *dssdev) > dsi_bus_lock(dsi); > dsi->video_enabled = false; > > - dsi_disable_video_output(dssdev, VC_DEFAULT); > + dsi_disable_video_output(dssdev, VC_VIDEO); > > dsi_display_disable(dssdev); > > @@ -3946,7 +3948,7 @@ static int dsi_update_channel(struct omap_dss_device *dssdev, int vc) > > static int dsi_update_all(struct omap_dss_device *dssdev) > { > - return dsi_update_channel(dssdev, VC_DEFAULT); > + return dsi_update_channel(dssdev, VC_VIDEO); > } > > /* Display funcs */ > @@ -4179,7 +4181,7 @@ static void dsi_enable_video_outputs(struct omap_dss_device *dssdev) > > dsi_display_enable(dssdev); > > - dsi_enable_video_output(dssdev, VC_DEFAULT); > + dsi_enable_video_output(dssdev, VC_VIDEO); > > dsi->video_enabled = true; > > @@ -4936,7 +4938,7 @@ static ssize_t omap_dsi_host_transfer(struct mipi_dsi_host *host, > { > struct dsi_data *dsi = host_to_omap(host); > int r; > - int vc = VC_DEFAULT; > + int vc = VC_CMD; > > dsi_bus_lock(dsi); > -- Regards, Laurent Pinchart