From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-omap-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5B9C4167B
	for <linux-omap@archiver.kernel.org>; Fri,  4 Dec 2020 01:43:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 12481224F4
	for <linux-omap@archiver.kernel.org>; Fri,  4 Dec 2020 01:43:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726167AbgLDBnB (ORCPT <rfc822;linux-omap@archiver.kernel.org>);
        Thu, 3 Dec 2020 20:43:01 -0500
Received: from mail.kernel.org ([198.145.29.99]:56336 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725849AbgLDBnB (ORCPT <rfc822;linux-omap@vger.kernel.org>);
        Thu, 3 Dec 2020 20:43:01 -0500
Date:   Thu, 3 Dec 2020 17:42:17 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1607046140;
        bh=pIlJOFEjUZmY29TtuxCmY4kYTaVQoES438UKqoDKQNk=;
        h=From:To:Cc:Subject:In-Reply-To:References:From;
        b=oJpdIFCkSwoEfxEDUW139IdJ8ztuN561G8emRa1x8XLbUfvTSls4/w1HZWPWd5B0H
         ioVAe6PFnPjHrZ4UhhXRibWXc1ciA6ctOuc/R1CVKJFsUs+cPAvz3Tsb8/dwjoUEDs
         OBEPtZEqETuLcTSJI4PdQRrPkYNEIeh4cjewf6ubyTpbTtVtThVuKExGuo9ZhafxUL
         EFmInqPBZfHsXlTzPPAudh5i1nHwzqFgPfrPufbB5TGBwMw4Q2slVqOIS0ieHUkQjl
         EMdNpVMNZcolJpNpvbJ4Hn4Ul4Jhd2/UltRzEq1Tv4q9c0Z8eXRp3p1IVPspS6VvlR
         dp0+d/byl1Iwg==
From:   Jakub Kicinski <kuba@kernel.org>
To:     Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@redhat.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andriin@fb.com>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Romain Perier <romain.perier@gmail.com>,
        Allen Pais <apais@linux.microsoft.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Simon Horman <simon.horman@netronome.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Jiri Benc <jbenc@redhat.com>, oss-drivers@netronome.com,
        linux-omap@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: [PATCH bpf 1/7] xdp: remove the xdp_attachment_flags_ok()
 callback
Message-ID: <20201203174217.7717ea84@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <160703131819.162669.2776807312730670823.stgit@toke.dk>
References: <160703131710.162669.9632344967082582016.stgit@toke.dk>
        <160703131819.162669.2776807312730670823.stgit@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
List-ID: <linux-omap.vger.kernel.org>
X-Mailing-List: linux-omap@vger.kernel.org

On Thu, 03 Dec 2020 22:35:18 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote:
> Since we offloaded and non-offloaded programs can co-exist there doesn't
> really seem to be any reason for the check anyway, and it's only used in
> three drivers so let's just get rid of the callback entirely.

I don't remember exactly now, but I think the concern was that using=20
the unspecified mode is pretty ambiguous when interface has multiple
programs attached.