From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A625BC4361B for ; Mon, 14 Dec 2020 13:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5535B20728 for ; Mon, 14 Dec 2020 13:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729487AbgLNNAd (ORCPT ); Mon, 14 Dec 2020 08:00:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:53986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728559AbgLNNAd (ORCPT ); Mon, 14 Dec 2020 08:00:33 -0500 Date: Mon, 14 Dec 2020 13:59:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607950792; bh=kF6ePMidLoNHq5BFFMKVcAb4qOKFmkwiDdF/N7rPbKQ=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=W8RHPvnQljWKQm32MD/ldEAhZDoPogaNiBL5fcGYywTlTyLTpChk6VcEDwvIa4G6f m1RpgWzt0PLiMpFgZMEnGfedNFahpYe5PIM8pZdirx4W8j7Zr58S0VcO7J4/DzlJ7+ vxjvTgP7MIIjQaRcUrqC2vUe6aGf42HD3AafTHUIX6sQcOBoaSMwXo/UmP4IsaJlhg fM90xwopK50XDWCsXMBRrn98q7jeACRPsZLS+CAjgPAh84wHaKJrAVuPx9PNwA3Xav rdwqo4jw6lI3s2r2u26ekjjm+8KdwKW1YKqmoEgXCzPn/oQht0IKngRRMXEjkmj7na N4MkT5DdvDlIg== From: Sebastian Reichel To: Tomi Valkeinen Cc: Laurent Pinchart , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com Subject: Re: [PATCH v4 60/80] drm/panel: panel-dsi-cm: set column & page at setup Message-ID: <20201214125950.5jeaotj2eas3fxai@earth.universe> References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-61-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mbkxzyrfujxf7reg" Content-Disposition: inline In-Reply-To: <20201124124538.660710-61-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --mbkxzyrfujxf7reg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Nov 24, 2020 at 02:45:18PM +0200, Tomi Valkeinen wrote: > Set the column & page address once during setup, instead of relying the > DSI host driver to set those. >=20 > Signed-off-by: Tomi Valkeinen > --- I'm fine with or without removal of the variables: Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel= /panel-dsi-cm.c > index 59e8e6b18e97..1e7f73340736 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -171,6 +171,26 @@ static int dsicm_get_id(struct panel_drv_data *ddata= , u8 *id1, u8 *id2, u8 *id3) > return 0; > } > =20 > +static int dsicm_set_update_window(struct panel_drv_data *ddata) > +{ > + struct mipi_dsi_device *dsi =3D ddata->dsi; > + int r; > + u16 x1 =3D 0; > + u16 x2 =3D ddata->mode.hdisplay - 1; > + u16 y1 =3D 0; > + u16 y2 =3D ddata->mode.vdisplay - 1; > + > + r =3D mipi_dsi_dcs_set_column_address(dsi, x1, x2); > + if (r < 0) > + return r; > + > + r =3D mipi_dsi_dcs_set_page_address(dsi, y1, y2); > + if (r < 0) > + return r; > + > + return 0; > +} > + > static int dsicm_bl_update_status(struct backlight_device *dev) > { > struct panel_drv_data *ddata =3D dev_get_drvdata(&dev->dev); > @@ -308,6 +328,10 @@ static int dsicm_power_on(struct panel_drv_data *dda= ta) > if (r) > goto err; > =20 > + r =3D dsicm_set_update_window(ddata); > + if (r) > + goto err; > + > r =3D mipi_dsi_dcs_set_display_on(ddata->dsi); > if (r) > goto err; > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --mbkxzyrfujxf7reg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/XYcYACgkQ2O7X88g7 +pqz5w//UCj40j0obj0IwXwcVS9Req9aeN0mx2slWTz829Vr1PM07x4KqwiYHqBC vOllsPxh+YYox18jIxSlmoHvtdkzyBXMMYqPWNIKRbEM97nW4mDXWpReEzJyuzRj qyDUuDFmuteoBLsAHAT3axJTkbhWuFvOnTYAc58Lss28f5zlqSC/Yr2jcmXnObZ9 PMgmql/IMKfVzjTmitLXtuGVJV4wY7A5wghk3ni7piKkq/nwl6zmals2dlWx8Cwe XVEYDrhPq56OrZD2GXbjgpKfLq6RtNtYegJ3b4JBk7eerEX4uBgTpUNx0HzAJh0g /ZQmyErmS/iXDfgxguMDnTOsqSGRG/Km8mxMg/+d6wAJGnPKkQUTq4iDG5qDUWrP BlmWwiW2I6ZHLJivvHzrTN9i50QOMrLnG4jHY3X5V3oHyiTgF4rIoRpMGl7LiJOm FQwlms0AtCL8m59GeC/kn+u+ulFkYDssanR3ffh81MRVNFHf7na2NS8jzCQAm1s9 STuZ8SpfqgfLYosrKtMyGfbqP96VbKkgjgYwS+H4ZjRTOMl1JqkVwkORI8zRh+MT a0GNCYNX+UolqK3VSnwYY457TZjP8FqIVzo7i6hcCiyj4Qz1F4N/1LjU5LdxFccZ pAXpSjQS0zH7gfUPHhmXjI3zM0rGAW6cmdkw734KvMIQg4hmJXM= =sH8E -----END PGP SIGNATURE----- --mbkxzyrfujxf7reg--