From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAF0C1B0E3 for ; Mon, 14 Dec 2020 13:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21CA32231F for ; Mon, 14 Dec 2020 13:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbgLNNKG (ORCPT ); Mon, 14 Dec 2020 08:10:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:56328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbgLNNKF (ORCPT ); Mon, 14 Dec 2020 08:10:05 -0500 Date: Mon, 14 Dec 2020 14:09:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607951364; bh=pn8M9Hin8USzFT67HImYKt0e9V3ni6fDVNQ1wplIdoA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=eW51iyb/ZVqWCuVf87qlvZ0ccqtogAps4iw99MHCMDq8Rwzvkj+F5Tt2VT6NEaFus RIw4lH3q9x29ksVaoqTLVuhDmTucsZvRRKI9hUVjFJu+2ZGd9OxZhH98RJgypiiQmY MF4Sqx72DdS0OaP3nvhtogqZTX23dgDPiS8A2ZRSoq9pQPLdXbWRm970a8JP9UEso6 ba/6El+srOx/lBO7151VPbD8CdLOjgDVU8/96+th5Ye6OX5s1xLIlgdrgA6BWbVD6G 1ZLP50q7d4aaKrz+lKoMWAEIlcSV7RyBPvpsBBpTWOuDkaj2S1HzExzGgPhrBLMl2X jmOx3Fo/ei1VQ== From: Sebastian Reichel To: Tomi Valkeinen Cc: Laurent Pinchart , Nikhil Devshatwar , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com, Sam Ravnborg Subject: Re: [PATCH v5 01/29] drm/panel: panel-dsi-cm: cleanup tear enable Message-ID: <20201214130921.wueiup4bm22eapxc@earth.universe> References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-2-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ihhxurpfhrc3j6eb" Content-Disposition: inline In-Reply-To: <20201208122855.254819-2-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --ihhxurpfhrc3j6eb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 08, 2020 at 02:28:27PM +0200, Tomi Valkeinen wrote: > Simplify the code by moving code from _dsicm_enable_te() into > dsicm_power_on(). >=20 > Signed-off-by: Tomi Valkeinen > Reviewed-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-dsi-cm.c | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel= /panel-dsi-cm.c > index 729b42b4dabd..38f79dca1fd0 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -68,8 +68,6 @@ static inline struct panel_drv_data *panel_to_ddata(str= uct drm_panel *panel) > return container_of(panel, struct panel_drv_data, panel); > } > =20 > -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable); > - > static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) > { > struct backlight_device *backlight; > @@ -313,10 +311,13 @@ static int dsicm_power_on(struct panel_drv_data *dd= ata) > if (r) > goto err; > =20 > - r =3D _dsicm_enable_te(ddata, true); > + r =3D mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLAN= K); > if (r) > goto err; > =20 > + /* possible panel bug */ > + msleep(100); > + > ddata->enabled =3D true; > =20 > if (!ddata->intro_printed) { > @@ -417,22 +418,6 @@ static int dsicm_disable(struct drm_panel *panel) > return r; > } > =20 > -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable) > -{ > - struct mipi_dsi_device *dsi =3D ddata->dsi; > - int r; > - > - if (enable) > - r =3D mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); > - else > - r =3D mipi_dsi_dcs_set_tear_off(dsi); > - > - /* possible panel bug */ > - msleep(100); > - > - return r; > -} > - > static int dsicm_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --ihhxurpfhrc3j6eb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/XZAEACgkQ2O7X88g7 +ppiHg//QkKz71VqsEeXiRmPA3waRe/piZWdSyAu2uqMZyIZ4uc00/7kEC0o3n/3 K9iSlcrRKVEKvgoTm1yyAcY/tOJW52eWt383qEI8LJ+KIU00zPJZWuGYNt3KG5w+ tOEHJk0G33U+IAiIM+Urpa3++O9Ged3IlVA2NUQCtV9fd5dSAwrb3QiqPmswu3hw aPo4NbNXiwmjly8VH2x92HvpDgj7YzIpyIy66f3PYFBGIrReRJKjrTqLaLRiEGJT m+CDh+8iJW576L0EXOuq0ikdoutBUTwP7Jghp70agIAIHqOzx5fRvvLTeiopbyUD KvGC9iBYEfTelDih1vfS66EnE1/9iH7Ab5HuYYk5heFeKK9gIXfO0w6YGGwYV21B aPmz+uGHkk8/BtWgblT3kYUAyFGCMDPJnOkKAA/u3CTorA7ztJTRu31oGKpP0vu6 UzgRaO3QeuEy8yPrle23JXKYpImOouS17dAyx7GpUXZG/hX9H2CDlxKLVOzkae/p 5JwH4x9YA7FtRPcAq3dPoQJDnfNmFOY4C5fLvG/OLGUaZA2HzEVSeYQybyCdcJDw XO53121IaSqDH0TRCSqzLn2xDThYzZEMIbkNJ3CePD5jaNf4S8Evc7wWgmuUcSfV t/LBA8cI7zAEMLRcQi8Oc5btp9t8U6m2slsGLG5jxNC3L6GNI9I= =9bUa -----END PGP SIGNATURE----- --ihhxurpfhrc3j6eb--